You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/05/13 11:25:49 UTC

[GitHub] [trafficserver] cukiernik opened a new pull request #7832: Fixup TS_USE_LINUX_NATIVE_AIO AIO_MODE_NATIVE

cukiernik opened a new pull request #7832:
URL: https://github.com/apache/trafficserver/pull/7832


   ./configure --enable-experimental-linux-native-aio


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] ezelkow1 commented on pull request #7832: Fixup TS_USE_LINUX_NATIVE_AIO AIO_MODE_NATIVE

Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on pull request #7832:
URL: https://github.com/apache/trafficserver/pull/7832#issuecomment-842707032


   [approve ci]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] cukiernik commented on pull request #7832: Fixup TS_USE_LINUX_NATIVE_AIO AIO_MODE_NATIVE

Posted by GitBox <gi...@apache.org>.
cukiernik commented on pull request #7832:
URL: https://github.com/apache/trafficserver/pull/7832#issuecomment-845923254


   Hi
   Is this change correct and acceptable?
   I need linux aio for my investigarion, but the **current _master_ doesn't compile with _--enable-experimental-linux-native-aio_**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] bryancall edited a comment on pull request #7832: Fixup TS_USE_LINUX_NATIVE_AIO AIO_MODE_NATIVE

Posted by GitBox <gi...@apache.org>.
bryancall edited a comment on pull request #7832:
URL: https://github.com/apache/trafficserver/pull/7832#issuecomment-860823746


   @cukiernik Please run clang-format over the code - it is failing the formatting CI test.  Also if you want, can you fix make check.  It is failing in `test_AIO.cc`:
   
   ```
     CXX      test_AIO-test_AIO.o
   ../../../iocore/aio/test_AIO.cc: In function ‘int main(int, char**)’:
   ../../../iocore/aio/test_AIO.cc:426:41: error: ‘class EventProcessor’ has no member named ‘n_threads_for_type’
     426 |   int n_netthreads     = eventProcessor.n_threads_for_type[etype];
         |                                         ^~~~~~~~~~~~~~~~~~
   ../../../iocore/aio/test_AIO.cc:427:41: error: ‘class EventProcessor’ has no member named ‘eventthread’
     427 |   EThread **netthreads = eventProcessor.eventthread[etype];
         |                                         ^~~~~~~~~~~
   make[3]: *** [Makefile:938: test_AIO-test_AIO.o] Error 1
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] bryancall commented on pull request #7832: Fixup TS_USE_LINUX_NATIVE_AIO AIO_MODE_NATIVE

Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7832:
URL: https://github.com/apache/trafficserver/pull/7832#issuecomment-856332457


   I will take a look at this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] bryancall commented on pull request #7832: Fixup TS_USE_LINUX_NATIVE_AIO AIO_MODE_NATIVE

Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7832:
URL: https://github.com/apache/trafficserver/pull/7832#issuecomment-864275501


   [approve ci autest]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] SolidWallOfCode edited a comment on pull request #7832: Fixup TS_USE_LINUX_NATIVE_AIO AIO_MODE_NATIVE

Posted by GitBox <gi...@apache.org>.
SolidWallOfCode edited a comment on pull request #7832:
URL: https://github.com/apache/trafficserver/pull/7832#issuecomment-856336765


   There is support for this already in `EventProcessor`. I'd recommend something more like
   ```
   for ( EThread * et : eventProcessor.active_group_threads(ET_NET)) {
     et->diskHandler = new DiskHandler();
     et->schedule_imm(et->diskHandler);
   }
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] bryancall commented on pull request #7832: Fixup TS_USE_LINUX_NATIVE_AIO AIO_MODE_NATIVE

Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7832:
URL: https://github.com/apache/trafficserver/pull/7832#issuecomment-864122967


   [approve ci]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] bryancall commented on pull request #7832: Fixup TS_USE_LINUX_NATIVE_AIO AIO_MODE_NATIVE

Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7832:
URL: https://github.com/apache/trafficserver/pull/7832#issuecomment-840889736


   [approve ci]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] SolidWallOfCode commented on pull request #7832: Fixup TS_USE_LINUX_NATIVE_AIO AIO_MODE_NATIVE

Posted by GitBox <gi...@apache.org>.
SolidWallOfCode commented on pull request #7832:
URL: https://github.com/apache/trafficserver/pull/7832#issuecomment-856336765


   There is support for this already in `EventProcessor`. I'd recommend something more like
   ```
   for ( EThread * et : eventProcessor.active_group_threads(ET_NET)) {
     et->diskHandler = new DiskHandler();
     et->schedule_imm(et->diskHandler);}
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] bryancall commented on pull request #7832: Fixup TS_USE_LINUX_NATIVE_AIO AIO_MODE_NATIVE

Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7832:
URL: https://github.com/apache/trafficserver/pull/7832#issuecomment-860816652


   [approve ci]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] bryancall commented on pull request #7832: Fixup TS_USE_LINUX_NATIVE_AIO AIO_MODE_NATIVE

Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7832:
URL: https://github.com/apache/trafficserver/pull/7832#issuecomment-860823746


   @cukiernik Please run clang-format over the code - it is failing formatting.  Also if you want, can you fix make check.  It is failing in `test_AIO.cc`:
   
   ```
     CXX      test_AIO-test_AIO.o
   ../../../iocore/aio/test_AIO.cc: In function ‘int main(int, char**)’:
   ../../../iocore/aio/test_AIO.cc:426:41: error: ‘class EventProcessor’ has no member named ‘n_threads_for_type’
     426 |   int n_netthreads     = eventProcessor.n_threads_for_type[etype];
         |                                         ^~~~~~~~~~~~~~~~~~
   ../../../iocore/aio/test_AIO.cc:427:41: error: ‘class EventProcessor’ has no member named ‘eventthread’
     427 |   EThread **netthreads = eventProcessor.eventthread[etype];
         |                                         ^~~~~~~~~~~
   make[3]: *** [Makefile:938: test_AIO-test_AIO.o] Error 1
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] shinrich commented on pull request #7832: Fixup TS_USE_LINUX_NATIVE_AIO AIO_MODE_NATIVE

Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #7832:
URL: https://github.com/apache/trafficserver/pull/7832#issuecomment-853287056


   [approve ci]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] bryancall merged pull request #7832: Fixup TS_USE_LINUX_NATIVE_AIO AIO_MODE_NATIVE

Posted by GitBox <gi...@apache.org>.
bryancall merged pull request #7832:
URL: https://github.com/apache/trafficserver/pull/7832


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org