You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/05/05 22:04:27 UTC
[GitHub] [arrow] kou opened a new pull request, #35454: GH-35442: [C++][FlightRPC] Pass ServerCallContext instead of CallHeaders to ServerMiddlewareFactory::StartCall()
kou opened a new pull request, #35454:
URL: https://github.com/apache/arrow/pull/35454
### Rationale for this change
Because it's also a RPC call like others such as `ListFlights()` and `DoGet()`.
If we pass `ServerCallContext` instead of `CallHeaders`, implementers can also get other information such as client address. For example, https://github.com/apache/arrow-flight-sql-postgresql will use it by `ServerCallContext::peer()`.
### What changes are included in this PR?
Passes `ServerCallContext` instead of `CallHeaders` but keeps a backward compatibility.
Implementers can still use the old signature.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes. But this is still backward compatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35454: GH-35442: [C++][FlightRPC] Pass ServerCallContext instead of CallHeaders to ServerMiddlewareFactory::StartCall()
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35454:
URL: https://github.com/apache/arrow/pull/35454#issuecomment-1536832387
* Closes: #35442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35454: GH-35442: [C++][FlightRPC] Pass ServerCallContext instead of CallHeaders to ServerMiddlewareFactory::StartCall()
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35454:
URL: https://github.com/apache/arrow/pull/35454#issuecomment-1536832422
:warning: GitHub issue #35442 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35454: GH-35442: [C++][FlightRPC] Pass ServerCallContext instead of CallHeaders to ServerMiddlewareFactory::StartCall()
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35454:
URL: https://github.com/apache/arrow/pull/35454#issuecomment-1537240198
Benchmark runs are scheduled for baseline = b43f4cd4ce28e2ddb7bad89081e141f381b09d5e and contender = f0e14539dc546b53ed8614b128ed6df5e3b5feac. f0e14539dc546b53ed8614b128ed6df5e3b5feac is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ef6690ff38714d559cf0aab28f36a55c...e7b361f482374d8985387e6ab3134853/)
[Failed :arrow_down:2.22% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/568ffecd1a834fa78965abdf621761f6...d7ac118a4a7c4d2189d3fab48775a12a/)
[Finished :arrow_down:0.26% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/6c9439e6aff3460ba49775af9ccb4db4...8e57f70c53f04e07a4fdd5f13bbcd6fe/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/cda6b3be6fae4ccfa7e7a28c997a1259...7234d59b5e2a438d9e2b6e4b5bf6dfea/)
Buildkite builds:
[Finished] [`f0e14539` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2824)
[Failed] [`f0e14539` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2861)
[Finished] [`f0e14539` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2824)
[Failed] [`f0e14539` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2851)
[Finished] [`b43f4cd4` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2823)
[Failed] [`b43f4cd4` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2860)
[Finished] [`b43f4cd4` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2823)
[Failed] [`b43f4cd4` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2850)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #35454: GH-35442: [C++][FlightRPC] Pass ServerCallContext instead of CallHeaders to ServerMiddlewareFactory::StartCall()
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #35454:
URL: https://github.com/apache/arrow/pull/35454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35454: GH-35442: [C++][FlightRPC] Pass ServerCallContext instead of CallHeaders to ServerMiddlewareFactory::StartCall()
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35454:
URL: https://github.com/apache/arrow/pull/35454#issuecomment-1537240237
['Python', 'R'] benchmarks have high level of regressions.
[test-mac-arm](https://conbench.ursa.dev/compare/runs/568ffecd1a834fa78965abdf621761f6...d7ac118a4a7c4d2189d3fab48775a12a/)
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/6c9439e6aff3460ba49775af9ccb4db4...8e57f70c53f04e07a4fdd5f13bbcd6fe/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org