You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by "Rick Rineholt (JIRA)" <tu...@ws.apache.org> on 2006/09/30 00:13:19 UTC
[jira] Created: (TUSCANY-767) NPE in CompositeReference.java when
service is defined using interface wsdl
NPE in CompositeReference.java when service is defined using interface wsdl
---------------------------------------------------------------------------
Key: TUSCANY-767
URL: http://issues.apache.org/jira/browse/TUSCANY-767
Project: Tuscany
Issue Type: Bug
Components: Java SCA Core
Affects Versions: Java-M2
Reporter: Rick Rineholt
Priority: Blocker
Fix For: Java-M2
If a service is defined using interface wsdl the service contract does not have an interface class this results in org.apache.tuscany.core.implementation.composite.CompositeReference getting an NPE.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
Re: [jira] Updated: (TUSCANY-767) NPE in CompositeReference.java when service is defined using interface wsdl
Posted by Jim Marino <jm...@myromatours.com>.
Hi Ignacio,
I'll have a look once I am caffeinated.
Jim
On Oct 3, 2006, at 6:19 AM, Ignacio Silva-Lepe (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/TUSCANY-767?page=all ]
>
> Ignacio Silva-Lepe updated TUSCANY-767:
> ---------------------------------------
>
> Attachment: OperationInvocationHandlersWithTestCase.patch
>
> Here's a new patch that also contains a test case. As soon as
> TUSCAY-768 is resolved I should be able to verify this patch with
> the inner.composite sample as well.
>
>> NPE in CompositeReference.java when service is defined using
>> interface wsdl
>> ---------------------------------------------------------------------
>> ------
>>
>> Key: TUSCANY-767
>> URL: http://issues.apache.org/jira/browse/TUSCANY-767
>> Project: Tuscany
>> Issue Type: Bug
>> Components: Java SCA Core
>> Affects Versions: Java-M2
>> Reporter: Rick Rineholt
>> Assigned To: Jim Marino
>> Priority: Blocker
>> Fix For: Java-M2
>>
>> Attachments: OperationInvocationHandlers.patch,
>> OperationInvocationHandlersWithTestCase.patch
>>
>>
>> If a service is defined using interface wsdl the service contract
>> does not have an interface class this results in
>> org.apache.tuscany.core.implementation.composite.CompositeReference g
>> etting an NPE.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the
> administrators: http://issues.apache.org/jira/secure/
> Administrators.jspa
> -
> For more information on JIRA, see: http://www.atlassian.com/
> software/jira
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-767) NPE in CompositeReference.java when
service is defined using interface wsdl
Posted by "Ignacio Silva-Lepe (JIRA)" <tu...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/TUSCANY-767?page=all ]
Ignacio Silva-Lepe updated TUSCANY-767:
---------------------------------------
Attachment: OperationInvocationHandlersWithTestCase.patch
Here's a new patch that also contains a test case. As soon as TUSCAY-768 is resolved I should be able to verify this patch with the inner.composite sample as well.
> NPE in CompositeReference.java when service is defined using interface wsdl
> ---------------------------------------------------------------------------
>
> Key: TUSCANY-767
> URL: http://issues.apache.org/jira/browse/TUSCANY-767
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core
> Affects Versions: Java-M2
> Reporter: Rick Rineholt
> Assigned To: Jim Marino
> Priority: Blocker
> Fix For: Java-M2
>
> Attachments: OperationInvocationHandlers.patch, OperationInvocationHandlersWithTestCase.patch
>
>
> If a service is defined using interface wsdl the service contract does not have an interface class this results in org.apache.tuscany.core.implementation.composite.CompositeReference getting an NPE.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Closed: (TUSCANY-767) NPE in CompositeReference.java when
service is defined using interface wsdl
Posted by "Rick Rineholt (JIRA)" <tu...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/TUSCANY-767?page=all ]
Rick Rineholt closed TUSCANY-767.
---------------------------------
Resolution: Fixed
seems to be working from what I can tell
> NPE in CompositeReference.java when service is defined using interface wsdl
> ---------------------------------------------------------------------------
>
> Key: TUSCANY-767
> URL: http://issues.apache.org/jira/browse/TUSCANY-767
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core
> Affects Versions: Java-M2
> Reporter: Rick Rineholt
> Assigned To: Jim Marino
> Priority: Blocker
> Fix For: Java-M2
>
> Attachments: OperationInvocationHandlers.patch, OperationInvocationHandlersWithTestCase.patch
>
>
> If a service is defined using interface wsdl the service contract does not have an interface class this results in org.apache.tuscany.core.implementation.composite.CompositeReference getting an NPE.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Assigned: (TUSCANY-767) NPE in CompositeReference.java when
service is defined using interface wsdl
Posted by "Jim Marino (JIRA)" <tu...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/TUSCANY-767?page=all ]
Jim Marino reassigned TUSCANY-767:
----------------------------------
Assignee: Jim Marino (was: Ignacio Silva-Lepe)
> NPE in CompositeReference.java when service is defined using interface wsdl
> ---------------------------------------------------------------------------
>
> Key: TUSCANY-767
> URL: http://issues.apache.org/jira/browse/TUSCANY-767
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core
> Affects Versions: Java-M2
> Reporter: Rick Rineholt
> Assigned To: Jim Marino
> Priority: Blocker
> Fix For: Java-M2
>
> Attachments: OperationInvocationHandlers.patch
>
>
> If a service is defined using interface wsdl the service contract does not have an interface class this results in org.apache.tuscany.core.implementation.composite.CompositeReference getting an NPE.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Assigned: (TUSCANY-767) NPE in CompositeReference.java when
service is defined using interface wsdl
Posted by "Ignacio Silva-Lepe (JIRA)" <tu...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/TUSCANY-767?page=all ]
Ignacio Silva-Lepe reassigned TUSCANY-767:
------------------------------------------
Assignee: Ignacio Silva-Lepe
> NPE in CompositeReference.java when service is defined using interface wsdl
> ---------------------------------------------------------------------------
>
> Key: TUSCANY-767
> URL: http://issues.apache.org/jira/browse/TUSCANY-767
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core
> Affects Versions: Java-M2
> Reporter: Rick Rineholt
> Assigned To: Ignacio Silva-Lepe
> Priority: Blocker
> Fix For: Java-M2
>
>
> If a service is defined using interface wsdl the service contract does not have an interface class this results in org.apache.tuscany.core.implementation.composite.CompositeReference getting an NPE.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
Re: [jira] Commented: (TUSCANY-767) NPE in CompositeReference.java when service is defined using interface wsdl
Posted by Jim Marino <jm...@myromatours.com>.
On Oct 2, 2006, at 4:26 PM, Jeremy Boynes wrote:
> On Oct 2, 2006, at 3:49 PM, Ignacio Silva-Lepe wrote:
>
>> Ah, if only test cases were that simple ... :-)
>>
If it isn't simple to unit test that generally indicates we have a
broader problem - e.g. lack of separation of concerns.
>> As it turns out, CompositeReference (as an extension of
>> ReferenceExtension) needs to pass a reference interface class to
>> its parent ctor, which seems most appropriately obtained from the
>> service contract it is given. This does not seem to be very
>> generic, not mention the fact that ServiceContract is an abstract
>> class, not an interface and not directly instantiable either, so
>> the test case cannot be very generic either.
>>
>> So much for that, thoughts?
>
> Use a private inner class to mock out ServiceContract? Use EasyMock
> class extension to generate a instantiable version of
> ServiceContract? Make ServiceContract an interface?
>
Probably should use the inner class approach but I've also found
EasyMock to be useful in mocking out classes as well through its
extension package.
> But more fundamentally, why does ReferenceExtension need a Java
> interface class - shouldn't it be using a ServiceContract?
Yea this seems a bit strange. It should only require one when
generating proxies.
>
> --
> Jeremy
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
Re: [jira] Commented: (TUSCANY-767) NPE in CompositeReference.java when service is defined using interface wsdl
Posted by Jeremy Boynes <jb...@apache.org>.
On Oct 2, 2006, at 3:49 PM, Ignacio Silva-Lepe wrote:
> Ah, if only test cases were that simple ... :-)
>
> As it turns out, CompositeReference (as an extension of
> ReferenceExtension) needs to pass a reference interface class to
> its parent ctor, which seems most appropriately obtained from the
> service contract it is given. This does not seem to be very
> generic, not mention the fact that ServiceContract is an abstract
> class, not an interface and not directly instantiable either, so
> the test case cannot be very generic either.
>
> So much for that, thoughts?
Use a private inner class to mock out ServiceContract? Use EasyMock
class extension to generate a instantiable version of
ServiceContract? Make ServiceContract an interface?
But more fundamentally, why does ReferenceExtension need a Java
interface class - shouldn't it be using a ServiceContract?
--
Jeremy
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
Re: [jira] Commented: (TUSCANY-767) NPE in CompositeReference.java
when service is defined using interface wsdl
Posted by Ignacio Silva-Lepe <is...@verizon.net>.
Ah, if only test cases were that simple ... :-)
As it turns out, CompositeReference (as an extension of ReferenceExtension)
needs to pass a reference interface class to its parent ctor, which seems
most appropriately obtained from the service contract it is given. This does
not seem to be very generic, not mention the fact that ServiceContract is an
abstract class, not an interface and not directly instantiable either, so
the test case cannot be very generic either.
So much for that, thoughts?
----- Original Message -----
From: "Jim Marino (JIRA)" <tu...@ws.apache.org>
To: <tu...@ws.apache.org>
Sent: Monday, October 02, 2006 4:48 PM
Subject: [jira] Commented: (TUSCANY-767) NPE in CompositeReference.java when
service is defined using interface wsdl
> [
> http://issues.apache.org/jira/browse/TUSCANY-767?page=comments#action_12439312 ]
>
> Jim Marino commented on TUSCANY-767:
> ------------------------------------
>
> Ignacio was going to add some testcases to verify behavior and I'll apply.
>
>> NPE in CompositeReference.java when service is defined using interface
>> wsdl
>> ---------------------------------------------------------------------------
>>
>> Key: TUSCANY-767
>> URL: http://issues.apache.org/jira/browse/TUSCANY-767
>> Project: Tuscany
>> Issue Type: Bug
>> Components: Java SCA Core
>> Affects Versions: Java-M2
>> Reporter: Rick Rineholt
>> Assigned To: Jim Marino
>> Priority: Blocker
>> Fix For: Java-M2
>>
>> Attachments: OperationInvocationHandlers.patch
>>
>>
>> If a service is defined using interface wsdl the service contract does
>> not have an interface class this results in
>> org.apache.tuscany.core.implementation.composite.CompositeReference
>> getting an NPE.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-767) NPE in CompositeReference.java when
service is defined using interface wsdl
Posted by "Jim Marino (JIRA)" <tu...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/TUSCANY-767?page=comments#action_12439312 ]
Jim Marino commented on TUSCANY-767:
------------------------------------
Ignacio was going to add some testcases to verify behavior and I'll apply.
> NPE in CompositeReference.java when service is defined using interface wsdl
> ---------------------------------------------------------------------------
>
> Key: TUSCANY-767
> URL: http://issues.apache.org/jira/browse/TUSCANY-767
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core
> Affects Versions: Java-M2
> Reporter: Rick Rineholt
> Assigned To: Jim Marino
> Priority: Blocker
> Fix For: Java-M2
>
> Attachments: OperationInvocationHandlers.patch
>
>
> If a service is defined using interface wsdl the service contract does not have an interface class this results in org.apache.tuscany.core.implementation.composite.CompositeReference getting an NPE.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-767) NPE in CompositeReference.java when
service is defined using interface wsdl
Posted by "Ignacio Silva-Lepe (JIRA)" <tu...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/TUSCANY-767?page=all ]
Ignacio Silva-Lepe updated TUSCANY-767:
---------------------------------------
Attachment: OperationInvocationHandlers.patch
Here's a patch that removes the dependency of CompositeReference target invokers on PojoTargetInvoker and Java reflection. This eliminates the need for CompositeReference to access a null interface class, which should also eliminate the NPE.
Because of TUSCANY-768, I have not been able to verify this patch using the inner.composite sample.
> NPE in CompositeReference.java when service is defined using interface wsdl
> ---------------------------------------------------------------------------
>
> Key: TUSCANY-767
> URL: http://issues.apache.org/jira/browse/TUSCANY-767
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core
> Affects Versions: Java-M2
> Reporter: Rick Rineholt
> Assigned To: Ignacio Silva-Lepe
> Priority: Blocker
> Fix For: Java-M2
>
> Attachments: OperationInvocationHandlers.patch
>
>
> If a service is defined using interface wsdl the service contract does not have an interface class this results in org.apache.tuscany.core.implementation.composite.CompositeReference getting an NPE.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
Re: [jira] Commented: (TUSCANY-767) NPE in CompositeReference.java when service is defined using interface wsdl
Posted by Jim Marino <jm...@myromatours.com>.
I thought we were going to change the composite target invokers to be
like interceptors that when they were invoked would "flip" the
message from the composite reference inbound/outbound pair to the
target service's inbound/outbound chain? I also was thinking the
invokers should not inherit from Pojo invoker or use reflection since
pojos aren't necessarily involved, even for local invocations.
Jim
On Sep 30, 2006, at 6:10 AM, Ignacio Silva-Lepe wrote:
> Ok, I took a look. Fixing CompositeReference to not be interface/
> method centric is not a big deal. However
> CompositeReferenceTargetInvoker and
> CompositeReferenceCallbackTargetInvoker are defined in terms of
> PojoTargetInvoker which itself is interface/method centric. Given
> the current architecture, and the fact that CompositeReference and
> CompositeService are intended for local use, it seems fair to
> assume a dependency on PojoTargetInvoker.
>
> If this is the case, then the fix will not work because
> WSDLServiceContract for instance, even though it extends
> ServiceContract, does not set its interfaceClass or callbackClass,
> hence the NPE. So, under this assumption, either
> WSDLServiceContract would need to set its interfaceClass and
> callbackClass (which seems hard to do), or CompositeReference and
> CompositeService, which represent bindless reference and service
> respectively, should not use WSDLServiceContract, i.e., bindless
> references and services should not use <interface.wsdl>.
>
> If this is not the case, for which would it be interesting to see
> the justification, then a different way of invoking
> CompositeReferences and CompositeServices would need to be used,
> one that does not rely on java reflection.
>
> Thoughts?
>
> ----- Original Message -----
> From: "Raymond Feng (JIRA)" <tu...@ws.apache.org>
> To: <tu...@ws.apache.org>
> Sent: Friday, September 29, 2006 6:25 PM
> Subject: [jira] Commented: (TUSCANY-767) NPE in
> CompositeReference.java when service is defined using interface wsdl
>
>
>> [ http://issues.apache.org/jira/browse/TUSCANY-767?
>> page=comments#action_12438820 ]
>>
>> Raymond Feng commented on TUSCANY-767:
>> --------------------------------------
>>
>> Ignacio, it seems that the CompositeReference code was initially
>> contributed by you, can you take a look? I found this class is
>> still java interface/method centric and cannot handle WSDL
>> portType/operation.
>>
>> Thanks,
>> Raymond
>>
>>> NPE in CompositeReference.java when service is defined using
>>> interface wsdl
>>> --------------------------------------------------------------------
>>> -------
>>>
>>> Key: TUSCANY-767
>>> URL: http://issues.apache.org/jira/browse/
>>> TUSCANY-767
>>> Project: Tuscany
>>> Issue Type: Bug
>>> Components: Java SCA Core
>>> Affects Versions: Java-M2
>>> Reporter: Rick Rineholt
>>> Priority: Blocker
>>> Fix For: Java-M2
>>>
>>>
>>> If a service is defined using interface wsdl the service contract
>>> does not have an interface class this results in
>>> org.apache.tuscany.core.implementation.composite.CompositeReference
>>> getting an NPE.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> If you think it was sent incorrectly contact one of the
>> administrators: http://issues.apache.org/jira/secure/
>> Administrators.jspa
>> -
>> For more information on JIRA, see: http://www.atlassian.com/
>> software/jira
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
>> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
Re: [jira] Commented: (TUSCANY-767) NPE in CompositeReference.java when service is defined using interface wsdl
Posted by Jim Marino <jm...@myromatours.com>.
On Sep 30, 2006, at 9:55 AM, Ignacio Silva-Lepe wrote:
> Ok, yes, let me take that back. Can I claim lack of caffeine? ...
>
Sure I do it all the time ;-)
> A CompositeReferenceTargetInvoker, and certainly a bound reference
> target invoker (e.g., Axis2TargetInvoker) needs to be able to
> handle interface.xxx (java, wsdl, etc).
> The idea with CompositeReference was to reuse the existing outbound
> invocation handler, but that is too restrictive. So yes, this will
> need to work with wsdl interfaces as well.
>
> Apologies for the confusion.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
Re: [jira] Commented: (TUSCANY-767) NPE in CompositeReference.java
when service is defined using interface wsdl
Posted by Ignacio Silva-Lepe <is...@verizon.net>.
Ok, yes, let me take that back. Can I claim lack of caffeine? ...
A CompositeReferenceTargetInvoker, and certainly a bound reference target
invoker (e.g., Axis2TargetInvoker) needs to be able to handle interface.xxx
(java, wsdl, etc).
The idea with CompositeReference was to reuse the existing outbound
invocation handler, but that is too restrictive. So yes, this will need to
work with wsdl interfaces as well.
Apologies for the confusion.
----- Original Message -----
From: "Jeremy Boynes" <jb...@apache.org>
To: <tu...@ws.apache.org>
Sent: Saturday, September 30, 2006 12:33 PM
Subject: Re: [jira] Commented: (TUSCANY-767) NPE in CompositeReference.java
when service is defined using interface wsdl
> On Sep 30, 2006, at 6:10 AM, Ignacio Silva-Lepe wrote:
>
>> Ok, I took a look. Fixing CompositeReference to not be interface/ method
>> centric is not a big deal. However CompositeReferenceTargetInvoker and
>> CompositeReferenceCallbackTargetInvoker are defined in terms of
>> PojoTargetInvoker which itself is interface/method centric. Given the
>> current architecture, and the fact that CompositeReference and
>> CompositeService are intended for local use, it seems fair to assume a
>> dependency on PojoTargetInvoker.
>>
>> If this is the case, then the fix will not work because
>> WSDLServiceContract for instance, even though it extends
>> ServiceContract, does not set its interfaceClass or callbackClass, hence
>> the NPE. So, under this assumption, either WSDLServiceContract would
>> need to set its interfaceClass and callbackClass (which seems hard to
>> do), or CompositeReference and CompositeService, which represent
>> bindless reference and service respectively, should not use
>> WSDLServiceContract, i.e., bindless references and services should not
>> use <interface.wsdl>.
>>
>> If this is not the case, for which would it be interesting to see the
>> justification, then a different way of invoking CompositeReferences and
>> CompositeServices would need to be used, one that does not rely on java
>> reflection.
>>
>> Thoughts?
>
> One of the fundamental concepts in SCA is the ability to specify service
> contracts in a variety of IDLs. It absolutely must be possible to express
> services and references in WSDL (or Java or CORBA IDL or ...) - basically
> the user should be free to use the IDL that is easiest for them and not
> be constrained by the infrastructure.
>
> I can see why PojoTargetInvoker would use reflection as it is responsible
> for dispatching an invocation into a POJO and the only way to do that is
> through some form of reflective invoke.
>
> I don't see why that would apply to a CompositeReferenceTargetInvoker -
> it's job AIUI is not to invoke a Java component but to flow the
> invocation onward to what it is wired to. That is not something that it
> needs an (expensive) reflective call to do - it can just forward the
> invocation.
>
> --
> Jeremy
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
Re: [jira] Commented: (TUSCANY-767) NPE in CompositeReference.java when service is defined using interface wsdl
Posted by Jeremy Boynes <jb...@apache.org>.
On Sep 30, 2006, at 6:10 AM, Ignacio Silva-Lepe wrote:
> Ok, I took a look. Fixing CompositeReference to not be interface/
> method centric is not a big deal. However
> CompositeReferenceTargetInvoker and
> CompositeReferenceCallbackTargetInvoker are defined in terms of
> PojoTargetInvoker which itself is interface/method centric. Given
> the current architecture, and the fact that CompositeReference and
> CompositeService are intended for local use, it seems fair to
> assume a dependency on PojoTargetInvoker.
>
> If this is the case, then the fix will not work because
> WSDLServiceContract for instance, even though it extends
> ServiceContract, does not set its interfaceClass or callbackClass,
> hence the NPE. So, under this assumption, either
> WSDLServiceContract would need to set its interfaceClass and
> callbackClass (which seems hard to do), or CompositeReference and
> CompositeService, which represent bindless reference and service
> respectively, should not use WSDLServiceContract, i.e., bindless
> references and services should not use <interface.wsdl>.
>
> If this is not the case, for which would it be interesting to see
> the justification, then a different way of invoking
> CompositeReferences and CompositeServices would need to be used,
> one that does not rely on java reflection.
>
> Thoughts?
One of the fundamental concepts in SCA is the ability to specify
service contracts in a variety of IDLs. It absolutely must be
possible to express services and references in WSDL (or Java or CORBA
IDL or ...) - basically the user should be free to use the IDL that
is easiest for them and not be constrained by the infrastructure.
I can see why PojoTargetInvoker would use reflection as it is
responsible for dispatching an invocation into a POJO and the only
way to do that is through some form of reflective invoke.
I don't see why that would apply to a CompositeReferenceTargetInvoker
- it's job AIUI is not to invoke a Java component but to flow the
invocation onward to what it is wired to. That is not something that
it needs an (expensive) reflective call to do - it can just forward
the invocation.
--
Jeremy
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
Re: [jira] Commented: (TUSCANY-767) NPE in CompositeReference.java
when service is defined using interface wsdl
Posted by Ignacio Silva-Lepe <is...@verizon.net>.
Ok, I took a look. Fixing CompositeReference to not be interface/method
centric is not a big deal. However CompositeReferenceTargetInvoker and
CompositeReferenceCallbackTargetInvoker are defined in terms of
PojoTargetInvoker which itself is interface/method centric. Given the
current architecture, and the fact that CompositeReference and
CompositeService are intended for local use, it seems fair to assume a
dependency on PojoTargetInvoker.
If this is the case, then the fix will not work because WSDLServiceContract
for instance, even though it extends ServiceContract, does not set its
interfaceClass or callbackClass, hence the NPE. So, under this assumption,
either WSDLServiceContract would need to set its interfaceClass and
callbackClass (which seems hard to do), or CompositeReference and
CompositeService, which represent bindless reference and service
respectively, should not use WSDLServiceContract, i.e., bindless references
and services should not use <interface.wsdl>.
If this is not the case, for which would it be interesting to see the
justification, then a different way of invoking CompositeReferences and
CompositeServices would need to be used, one that does not rely on java
reflection.
Thoughts?
----- Original Message -----
From: "Raymond Feng (JIRA)" <tu...@ws.apache.org>
To: <tu...@ws.apache.org>
Sent: Friday, September 29, 2006 6:25 PM
Subject: [jira] Commented: (TUSCANY-767) NPE in CompositeReference.java when
service is defined using interface wsdl
> [
> http://issues.apache.org/jira/browse/TUSCANY-767?page=comments#action_12438820 ]
>
> Raymond Feng commented on TUSCANY-767:
> --------------------------------------
>
> Ignacio, it seems that the CompositeReference code was initially
> contributed by you, can you take a look? I found this class is still java
> interface/method centric and cannot handle WSDL portType/operation.
>
> Thanks,
> Raymond
>
>> NPE in CompositeReference.java when service is defined using interface
>> wsdl
>> ---------------------------------------------------------------------------
>>
>> Key: TUSCANY-767
>> URL: http://issues.apache.org/jira/browse/TUSCANY-767
>> Project: Tuscany
>> Issue Type: Bug
>> Components: Java SCA Core
>> Affects Versions: Java-M2
>> Reporter: Rick Rineholt
>> Priority: Blocker
>> Fix For: Java-M2
>>
>>
>> If a service is defined using interface wsdl the service contract does
>> not have an interface class this results in
>> org.apache.tuscany.core.implementation.composite.CompositeReference
>> getting an NPE.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
Re: [jira] Commented: (TUSCANY-767) NPE in CompositeReference.java
when service is defined using interface wsdl
Posted by Ignacio Silva-Lepe <is...@verizon.net>.
Ok, I'll take a look.
----- Original Message -----
From: "Raymond Feng (JIRA)" <tu...@ws.apache.org>
To: <tu...@ws.apache.org>
Sent: Friday, September 29, 2006 6:25 PM
Subject: [jira] Commented: (TUSCANY-767) NPE in CompositeReference.java when
service is defined using interface wsdl
> [
> http://issues.apache.org/jira/browse/TUSCANY-767?page=comments#action_12438820 ]
>
> Raymond Feng commented on TUSCANY-767:
> --------------------------------------
>
> Ignacio, it seems that the CompositeReference code was initially
> contributed by you, can you take a look? I found this class is still java
> interface/method centric and cannot handle WSDL portType/operation.
>
> Thanks,
> Raymond
>
>> NPE in CompositeReference.java when service is defined using interface
>> wsdl
>> ---------------------------------------------------------------------------
>>
>> Key: TUSCANY-767
>> URL: http://issues.apache.org/jira/browse/TUSCANY-767
>> Project: Tuscany
>> Issue Type: Bug
>> Components: Java SCA Core
>> Affects Versions: Java-M2
>> Reporter: Rick Rineholt
>> Priority: Blocker
>> Fix For: Java-M2
>>
>>
>> If a service is defined using interface wsdl the service contract does
>> not have an interface class this results in
>> org.apache.tuscany.core.implementation.composite.CompositeReference
>> getting an NPE.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-767) NPE in CompositeReference.java when
service is defined using interface wsdl
Posted by "Raymond Feng (JIRA)" <tu...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/TUSCANY-767?page=comments#action_12438820 ]
Raymond Feng commented on TUSCANY-767:
--------------------------------------
Ignacio, it seems that the CompositeReference code was initially contributed by you, can you take a look? I found this class is still java interface/method centric and cannot handle WSDL portType/operation.
Thanks,
Raymond
> NPE in CompositeReference.java when service is defined using interface wsdl
> ---------------------------------------------------------------------------
>
> Key: TUSCANY-767
> URL: http://issues.apache.org/jira/browse/TUSCANY-767
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core
> Affects Versions: Java-M2
> Reporter: Rick Rineholt
> Priority: Blocker
> Fix For: Java-M2
>
>
> If a service is defined using interface wsdl the service contract does not have an interface class this results in org.apache.tuscany.core.implementation.composite.CompositeReference getting an NPE.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-767) NPE in CompositeReference.java when
service is defined using interface wsdl
Posted by "Jim Marino (JIRA)" <tu...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/TUSCANY-767?page=comments#action_12439768 ]
Jim Marino commented on TUSCANY-767:
------------------------------------
I've applied the patch for kernel with some additional test cases. I think there are execution paths that are not covered so we should probably add more test cases for this.
I did not check in the changes to the sample as I am getting the following error:
org.apache.tuscany.spi.wire.InvocationRuntimeException: java.lang.NullPointerException
at org.apache.tuscany.core.databinding.impl.DataBindingInteceptor.invoke(DataBindingInteceptor.java:76)
at org.apache.tuscany.core.wire.AbstractOutboundInvocationHandler.invoke(AbstractOutboundInvocationHandler.java:65)
at org.apache.tuscany.core.wire.jdk.JDKOutboundInvocationHandler.invoke(JDKOutboundInvocationHandler.java:121)
at $Proxy17.clientMethod(Unknown Source)
at innercomposite.InnerCompositeTestCase.test(InnerCompositeTestCase.java:39)
Caused by: java.lang.NullPointerException
at org.apache.tuscany.core.databinding.impl.DataBindingInteceptor.invoke(DataBindingInteceptor.java:71)
at org.apache.tuscany.core.wire.SynchronousBridgingInterceptor.invoke(SynchronousBridgingInterceptor.java:41)
at org.apache.tuscany.core.wire.SynchronousBridgingInterceptor.invoke(SynchronousBridgingInterceptor.java:41)
at org.apache.tuscany.core.databinding.impl.DataBindingInteceptor.invoke(DataBindingInteceptor.java:71)
at org.apache.tuscany.core.wire.AbstractOutboundInvocationHandler.invoke(AbstractOutboundInvocationHandler.java:65)
at org.apache.tuscany.core.wire.jdk.JDKOutboundInvocationHandler.invoke(JDKOutboundInvocationHandler.java:121)
> NPE in CompositeReference.java when service is defined using interface wsdl
> ---------------------------------------------------------------------------
>
> Key: TUSCANY-767
> URL: http://issues.apache.org/jira/browse/TUSCANY-767
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core
> Affects Versions: Java-M2
> Reporter: Rick Rineholt
> Assigned To: Jim Marino
> Priority: Blocker
> Fix For: Java-M2
>
> Attachments: OperationInvocationHandlers.patch, OperationInvocationHandlersWithTestCase.patch
>
>
> If a service is defined using interface wsdl the service contract does not have an interface class this results in org.apache.tuscany.core.implementation.composite.CompositeReference getting an NPE.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org