You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2015/10/16 06:41:27 UTC
Review Request 39385: Fixed link conversion regexp in website.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39385/
-----------------------------------------------------------
Review request for mesos and Dave Lester.
Repository: mesos
Description
-------
The previous regexp was:
/\((.*)(\.md)\)/
Given text like:
Text (comment): [link](foo.md)
This will greedily match ".*", so \1 is bound to "comment): [link](foo", which
seems unlikely to be the desired result.
Diffs
-----
site/Rakefile 9fe4730579ee0e802880e6e3547b4e550be41c8c
Diff: https://reviews.apache.org/r/39385/diff/
Testing
-------
Thanks,
Neil Conway
Re: Review Request 39385: Fixed link conversion regexp in website.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39385/#review103692
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39385]
All tests passed.
- Mesos ReviewBot
On Oct. 22, 2015, 11:03 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39385/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2015, 11:03 p.m.)
>
>
> Review request for mesos, Adam B and Dave Lester.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The previous regexp was:
>
> /\((.*)(\.md)\)/
>
> Given text like:
>
> Text (comment): [link](foo.md)
>
> This will greedily match ".*", so \1 is bound to "comment): [link](foo", which
> seems unlikely to be the desired result.
>
>
> Diffs
> -----
>
> site/Rakefile 9fe4730579ee0e802880e6e3547b4e550be41c8c
>
> Diff: https://reviews.apache.org/r/39385/diff/
>
>
> Testing
> -------
>
> Tested using support/site-docker -- a few places where the old regexp screwed up were corrected, otherwise no changes observed.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 39385: Fixed link conversion regexp in website.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39385/#review103950
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On Oct. 22, 2015, 4:03 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39385/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2015, 4:03 p.m.)
>
>
> Review request for mesos, Adam B and Dave Lester.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The previous regexp was:
>
> /\((.*)(\.md)\)/
>
> Given text like:
>
> Text (comment): [link](foo.md)
>
> This will greedily match ".*", so \1 is bound to "comment): [link](foo", which
> seems unlikely to be the desired result.
>
>
> Diffs
> -----
>
> site/Rakefile 9fe4730579ee0e802880e6e3547b4e550be41c8c
>
> Diff: https://reviews.apache.org/r/39385/diff/
>
>
> Testing
> -------
>
> Tested using support/site-docker -- a few places where the old regexp screwed up were corrected, otherwise no changes observed.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 39385: Fixed link conversion regexp in website.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39385/#review103951
-----------------------------------------------------------
Ship it!
Looks like a legit regexp improvement to me.
- Adam B
On Oct. 22, 2015, 4:03 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39385/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2015, 4:03 p.m.)
>
>
> Review request for mesos, Adam B and Dave Lester.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The previous regexp was:
>
> /\((.*)(\.md)\)/
>
> Given text like:
>
> Text (comment): [link](foo.md)
>
> This will greedily match ".*", so \1 is bound to "comment): [link](foo", which
> seems unlikely to be the desired result.
>
>
> Diffs
> -----
>
> site/Rakefile 9fe4730579ee0e802880e6e3547b4e550be41c8c
>
> Diff: https://reviews.apache.org/r/39385/diff/
>
>
> Testing
> -------
>
> Tested using support/site-docker -- a few places where the old regexp screwed up were corrected, otherwise no changes observed.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 39385: Fixed link conversion regexp in website.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39385/
-----------------------------------------------------------
(Updated Oct. 22, 2015, 11:03 p.m.)
Review request for mesos, Adam B and Dave Lester.
Changes
-------
More testing.
Repository: mesos
Description
-------
The previous regexp was:
/\((.*)(\.md)\)/
Given text like:
Text (comment): [link](foo.md)
This will greedily match ".*", so \1 is bound to "comment): [link](foo", which
seems unlikely to be the desired result.
Diffs (updated)
-----
site/Rakefile 9fe4730579ee0e802880e6e3547b4e550be41c8c
Diff: https://reviews.apache.org/r/39385/diff/
Testing (updated)
-------
Tested using support/site-docker -- a few places where the old regexp screwed up were corrected, otherwise no changes observed.
Thanks,
Neil Conway
Re: Review Request 39385: Fixed link conversion regexp in website.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39385/#review102895
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39385]
All tests passed.
- Mesos ReviewBot
On Oct. 16, 2015, 4:42 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39385/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2015, 4:42 a.m.)
>
>
> Review request for mesos and Dave Lester.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The previous regexp was:
>
> /\((.*)(\.md)\)/
>
> Given text like:
>
> Text (comment): [link](foo.md)
>
> This will greedily match ".*", so \1 is bound to "comment): [link](foo", which
> seems unlikely to be the desired result.
>
>
> Diffs
> -----
>
> site/Rakefile 9fe4730579ee0e802880e6e3547b4e550be41c8c
>
> Diff: https://reviews.apache.org/r/39385/diff/
>
>
> Testing
> -------
>
> Tested using "http://rubular.com/" -- didn't actually test on mesos-website-container, since it doesn't use the site code from Git just yet.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 39385: Fixed link conversion regexp in website.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39385/
-----------------------------------------------------------
(Updated Oct. 16, 2015, 4:42 a.m.)
Review request for mesos and Dave Lester.
Repository: mesos
Description
-------
The previous regexp was:
/\((.*)(\.md)\)/
Given text like:
Text (comment): [link](foo.md)
This will greedily match ".*", so \1 is bound to "comment): [link](foo", which
seems unlikely to be the desired result.
Diffs
-----
site/Rakefile 9fe4730579ee0e802880e6e3547b4e550be41c8c
Diff: https://reviews.apache.org/r/39385/diff/
Testing (updated)
-------
Tested using "http://rubular.com/" -- didn't actually test on mesos-website-container, since it doesn't use the site code from Git just yet.
Thanks,
Neil Conway