You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/03 13:55:24 UTC
[GitHub] [airflow] malthe opened a new pull request #18014: Fix unexpected bug in exiting hook context manager
malthe opened a new pull request #18014:
URL: https://github.com/apache/airflow/pull/18014
This fixes a minor code issue (which rendered the hook unusable).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #18014: Fix unexpected bug in exiting hook context manager
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #18014:
URL: https://github.com/apache/airflow/pull/18014#issuecomment-912559811
This is where the "autospec" feature of Mock comes in very handy! (Though I'm not sure if this is usable in this particular case)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18014: Fix unexpected bug in exiting PSRPHook.client context manager
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18014:
URL: https://github.com/apache/airflow/pull/18014#issuecomment-912560690
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #18014: Fix unexpected bug in exiting PSRPHook.client context manager
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #18014:
URL: https://github.com/apache/airflow/pull/18014
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18014: Fix unexpected bug in exiting PSRPHook.client context manager
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18014:
URL: https://github.com/apache/airflow/pull/18014#issuecomment-912655052
Great. I will release a new psrp provider version today then - together with hashicorp and celery I have to release. Then I will yank the 1.0.0 version of psrp (makes no sense to yank it because there is only one versin so yanking will not have effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org