You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by je...@apache.org on 2018/11/29 16:46:58 UTC

[sling-org-apache-sling-commons-html] branch SLING-3270 updated: removing void tag support for the moment as there is a logic conflict

This is an automated email from the ASF dual-hosted git repository.

jeb pushed a commit to branch SLING-3270
in repository https://gitbox.apache.org/repos/asf/sling-org-apache-sling-commons-html.git


The following commit(s) were added to refs/heads/SLING-3270 by this push:
     new 219dd96  removing void tag support for the moment as there is a logic conflict
219dd96 is described below

commit 219dd96f48cf6a26b282fc028276798ed96a3364
Author: JE Bailey <je...@apache.org>
AuthorDate: Thu Nov 29 11:46:53 2018 -0500

    removing void tag support for the moment as there is a logic conflict
---
 src/main/java/org/apache/sling/commons/html/internal/DOMBuilder.java | 2 +-
 src/main/java/org/apache/sling/commons/html/util/HtmlSAXSupport.java | 4 ----
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/src/main/java/org/apache/sling/commons/html/internal/DOMBuilder.java b/src/main/java/org/apache/sling/commons/html/internal/DOMBuilder.java
index b4b6868..5df4eea 100644
--- a/src/main/java/org/apache/sling/commons/html/internal/DOMBuilder.java
+++ b/src/main/java/org/apache/sling/commons/html/internal/DOMBuilder.java
@@ -53,7 +53,7 @@ public class DOMBuilder implements ContentHandler, LexicalHandler {
      *
      * @throws IOException If for some reason the <code>TransformerHandler</code> cannot be created.
      */
-    DOMBuilder() throws IOException {
+    public DOMBuilder() throws IOException {
         try {
             final TransformerHandler handler = FACTORY.newTransformerHandler();
             this.contentHandler = handler;
diff --git a/src/main/java/org/apache/sling/commons/html/util/HtmlSAXSupport.java b/src/main/java/org/apache/sling/commons/html/util/HtmlSAXSupport.java
index 8ee4629..810a929 100644
--- a/src/main/java/org/apache/sling/commons/html/util/HtmlSAXSupport.java
+++ b/src/main/java/org/apache/sling/commons/html/util/HtmlSAXSupport.java
@@ -66,10 +66,6 @@ public class HtmlSAXSupport implements Consumer<HtmlElement> {
             case START_TAG:
                 lexicalHandler.startEntity(value);
                 contentHandler.startElement("", value, value, HtmlSAXSupport.convert(element.getAttributes()));
-                if (element.getVoidTag()) {
-                    lexicalHandler.endEntity(value);
-                    contentHandler.endElement("", value, value);
-                }
                 break;
             case TEXT:
                 contentHandler.characters(value.toCharArray(), 0, value.toCharArray().length);