[jira] [Commented] (FLINK-6550) Calling ctx.collect with a null OutputTag should log a warning or throw an exception

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16084138#comment-16084138 ] 

ASF GitHub Bot commented on FLINK-6550:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/4312

    [FLINK-6550] Reject null OutputTags in Context#collect(OutputTag<X>, X)

    @aljoscha what do you think?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 6550

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4312.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4312
    
----
commit 380d250b1cdd9a3fc461679db9eb1683ea5bdf73
Author: zentol <ch...@apache.org>
Date:   2017-06-19T13:57:14Z

    [FLINK-6550] Reject null OutputTags in Context#collect(OutputTag<X>, X)

----


> Calling ctx.collect with a null OutputTag should log a warning or throw an exception
> ------------------------------------------------------------------------------------
>
>                 Key: FLINK-6550
>                 URL: https://issues.apache.org/jira/browse/FLINK-6550
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API
>            Reporter: Chesnay Schepler
>            Priority: Minor
>
> When using side outputs it is currently possible to call {Context#collect(OutputTag<X>, X record)} with null for the OutputTag. Effectively this causes the data to be swallowed. It is unlikely that a user actually intends this, so i propose to either log a warning or throw an exception.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)