You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/05 01:48:52 UTC
[GitHub] [incubator-doris-flink-connector] JNSimba commented on a diff in pull request #31: [fix] build.sh script --flink 1.14.3 --scala 2.12parameters do not take effect
JNSimba commented on code in PR #31:
URL: https://github.com/apache/incubator-doris-flink-connector/pull/31#discussion_r865508505
##########
flink-doris-connector/build.sh:
##########
@@ -73,10 +64,19 @@ while true; do
--scala) SCALA_VERSION=$2 ; shift 2 ;;
--tag) BUILD_FROM_TAG=1 ; shift ;;
--) shift ; break ;;
- *) echo "Internal error" ; exit 1 ;;
+ *) break ;;
esac
Review Comment:
when will it come here？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org