You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "tedyu (via GitHub)" <gi...@apache.org> on 2024/09/20 12:43:49 UTC
[PR] Catch exception from snapshot upload [spark]
tedyu opened a new pull request, #48185:
URL: https://github.com/apache/spark/pull/48185
### What changes were proposed in this pull request?
When `enableChangelogCheckpointing` is true, we call `uploadSnapshot`. If there is exception coming out of this call, currently changelog files are not written.
This PR catches the potential exception from `uploadSnapshot`, write the changelog files and throw the exception.
### Why are the changes needed?
This is to ensure that changelog files are always written.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing test suite.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [Minor] Catch exception from snapshot uploading [spark]
Posted by "tedyu (via GitHub)" <gi...@apache.org>.
tedyu commented on PR #48185:
URL: https://github.com/apache/spark/pull/48185#issuecomment-2363834751
@anishshri-db
Can you take a look ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [Minor] Catch exception from snapshot uploading [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #48185: [Minor] Catch exception from snapshot uploading
URL: https://github.com/apache/spark/pull/48185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [Minor] Catch exception from snapshot uploading [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #48185:
URL: https://github.com/apache/spark/pull/48185#issuecomment-2564883938
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [Minor] Catch exception from snapshot upload [spark]
Posted by "tedyu (via GitHub)" <gi...@apache.org>.
tedyu commented on PR #48185:
URL: https://github.com/apache/spark/pull/48185#issuecomment-2363711072
@HeartSaVioR
Can you take a look ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org