You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org> on 2011/11/21 16:22:52 UTC

[jira] [Commented] (CASSANDRA-3508) requiring --debug to see stack traces for failures in cassandra-cli is a terrible idea (aka silent failure is never a valid option)

    [ https://issues.apache.org/jira/browse/CASSANDRA-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154241#comment-13154241 ] 

Jonathan Ellis commented on CASSANDRA-3508:
-------------------------------------------

We need to be a little judicious here.  Simply printing stacktraces for *all* exceptions is not right either.  For instance, it looks to me like

{code}
             sessionState.err.println(e.getWhy());
 
-            if (sessionState.debug)
-                e.printStackTrace();
+            e.printStackTrace(sessionState.err);
{code}

{code}
-            if (sessionState.debug)
-                e.printStackTrace();
-            
             sessionState.err.println("Login failure. Did you specify 'keyspace', 'username' and 'password'?");
+            e.printStackTrace(sessionState.err);
{code}

should not be stacktraces by default.
                
> requiring --debug to see stack traces for failures in cassandra-cli is a terrible idea (aka silent failure is never a valid option)
> -----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-3508
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3508
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.0.0
>            Reporter: Matthew F. Dennis
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>             Fix For: 1.0.3
>
>         Attachments: CASSANDRA-3508.patch
>
>
> this manifests itself in cassandra-cli by returning null to the user.  In order to see what the problem was (and in many cases, just to know there was a problem at all) requires running cassandra-cli with "--debug"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira