You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by astroshim <gi...@git.apache.org> on 2016/05/30 05:19:45 UTC

[GitHub] incubator-zeppelin pull request: Hotfix - initial notebook name do...

GitHub user astroshim opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/929

    Hotfix - initial notebook name does not increase.

    ### What is this PR for?
    To increase initial notebook name.
    
    
    ### What type of PR is it?
    Bug Fix
    
    
    ### How should this be tested?
    execute create new note.
    
    ### Screenshots (if appropriate)
     - before
    ![image](https://cloud.githubusercontent.com/assets/3348133/15640275/60d1b67e-2671-11e6-9a46-645f28b1a09a.png)
    
    
    - after
    ![image](https://cloud.githubusercontent.com/assets/3348133/15640270/47039e92-2671-11e6-9000-75bfaa5fa21a.png)
    
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/astroshim/incubator-zeppelin hotfix/notename

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/929.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #929
    
----
commit eb0defdb50c5da8a2f562f899a499c66494e6494
Author: astroshim <hs...@nflabs.com>
Date:   2016-05-30T05:13:57Z

    list name has changed.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Hotfix - initial notebook name do...

Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/929#issuecomment-222578009
  
    Looks good to me
     \cc @felizbear @corneadoug for double-check


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Hotfix - initial notebook name do...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/929#issuecomment-222601917
  
    Tested and looks good to me


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Hotfix - initial notebook name do...

Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/929#issuecomment-222578940
  
    As it's marked as HOTFIX (urgent), I will proceed merging it if there is no further discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Hotfix - initial notebook name does not inc...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/929


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Hotfix - initial notebook name do...

Posted by felizbear <gi...@git.apache.org>.
Github user felizbear commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/929#issuecomment-222578766
  
    looks good


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---