You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/02 12:12:51 UTC
[I] [Task] Admin SQL-dialect tests are H2-only in CI (root cause of the open dialect bugs) [shenyu]
Aias00 opened a new issue, #6596:
URL: https://github.com/apache/shenyu/issues/6596
## Description
Admin ships `application-{mysql,pg,og,ob,oracle}.yml` configs and JDBC drivers, but the test suite only ever runs against H2-in-MySQL-mode. No CI job runs the admin JUnit suite against real MySQL/PG/OpenGauss/Oracle. The only dialect exercise is `e2e-k8s.yml:152-162` (h2/mysql/postgres/opengauss compose) — slow e2e, not the unit suite, and does not cover Oracle/OceanBase.
## Location
```
.github/workflows/ci.yml:125-137 (clean test -Prelease)
shenyu-admin/src/test/resources/application.yml (profiles.active: h2)
shenyu-admin/pom.xml:181-266 (mysql/postgresql/opengauss/oracle drivers present but no test profile)
```
## Impact
This is the root-cause class for open bugs #6161, #6175, #6136, #6177, #5631, #5961 — dialect SQL divergences merge undetected.
## Suggested fix
Add a Testcontainers/docker-compose CI matrix running `shenyu-admin` tests with `spring.profiles.active=mysql|pg|og|oracle`; gate it.
## Related existing issue(s)
None
_Identified during the 2026-08-02 audit; full list in [`docs/issue-candidates-2026-08-02.md`](docs/issue-candidates-2026-08-02.md)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Task] Admin SQL-dialect tests are H2-only in CI (root cause of the open dialect bugs) [shenyu]
Posted by "sunnysabor (via GitHub)" <gi...@apache.org>.
sunnysabor commented on issue #6596:
URL: https://github.com/apache/shenyu/issues/6596#issuecomment-5938469732
The proposed full-suite matrix is now running in [PR #7408](https://github.com/apache/shenyu/pull/7408). All four services reached healthy state and all schema-import steps passed. MySQL 8.0 passed all 1,723 tests; PostgreSQL 14 failed with 8 failures/16 errors, openGauss 5.0.1 with 8 failures/19 errors, and Oracle Free 23 with 3 failures/29 errors (1,692 tests executed per non-MySQL run). Representative existing gaps include PostgreSQL/openGauss `plugin_jar` bytea binding through the BLOB mapping, Oracle batch SQL using reserved `ROWID`, database-specific index metadata assertions, transaction expectations, and queries unsupported by the current dialect SQL paths. This confirms the CI gap is hiding real compatibility defects, but it also means a mandatory full-suite gate will remain red until those defects are fixed. I have kept the full suite and gate intact rather than excluding failing tests. Please advise whether this issue should include the first set of dialect fixes before
the gate is made blocking, or whether maintainers prefer a staged rollout; I am continuing to classify the failures and can take a focused follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Task] Admin SQL-dialect tests are H2-only in CI (root cause of the open dialect bugs) [shenyu]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 closed issue #6596: [Task] Admin SQL-dialect tests are H2-only in CI (root cause of the open dialect bugs)
URL: https://github.com/apache/shenyu/issues/6596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Task] Admin SQL-dialect tests are H2-only in CI (root cause of the open dialect bugs) [shenyu]
Posted by "sunnysabor (via GitHub)" <gi...@apache.org>.
sunnysabor commented on issue #6596:
URL: https://github.com/apache/shenyu/issues/6596#issuecomment-5937777724
I would like to work on #6596. I am checking how to run the existing admin test suite against the database services already used by CI, with the goal of adding a focused, reproducible dialect matrix without weakening or replacing the H2 test path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Task] Admin SQL-dialect tests are H2-only in CI (root cause of the open dialect bugs) [shenyu]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #6596:
URL: https://github.com/apache/shenyu/issues/6596#issuecomment-5157762683
👋 Hello @yuluo-yx
A new issue has been opened by @Aias00:
- **Title**: [Task] Admin SQL-dialect tests are H2-only in CI (root cause of the open dialect bugs)
- **Link**: https://github.com/apache/shenyu/issues/6596
Please review when you have time. Thank you! 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Task] Admin SQL-dialect tests are H2-only in CI (root cause of the open dialect bugs) [shenyu]
Posted by "sunnysabor (via GitHub)" <gi...@apache.org>.
sunnysabor commented on issue #6596:
URL: https://github.com/apache/shenyu/issues/6596#issuecomment-5942244318
Update: I kept the complete admin suite and its CI matrix intact, addressed the cross-dialect incompatibilities it exposed, and reran all four database profiles on PR #7408. In hosted run [36924341083](https://github.com/apache/shenyu/actions/runs/36924341083), MySQL 8.0, PostgreSQL 14, openGauss 5.0.1, and Oracle 23 each passed all 1,728 admin tests (0 failures/errors, 1 skipped). No test was excluded to get the matrix green. I updated the PR validation details and moved it from Draft to Ready for review.
The wider PR checks still show the clean-master-reproduced heartbeat test failure from #7401 and an unrelated PostgreSQL storage E2E failure after `httpbin.org` returned 502; the H2/MySQL/openGauss storage siblings were cancelled by fail-fast. These do not affect the passing dialect-suite jobs, and I am not treating this issue as complete before the PR is reviewed and merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Task] Admin SQL-dialect tests are H2-only in CI (root cause of the open dialect bugs) [shenyu]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on issue #6596:
URL: https://github.com/apache/shenyu/issues/6596#issuecomment-5953272239
The current CI setup is comprehensive and meets the project's present needs. We do not need further CI adjustments at this time, so this issue is being closed for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org