You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opennlp.apache.org by jo...@apache.org on 2014/01/27 11:18:39 UTC

svn commit: r1561626 - in /opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/sentdetect: SentenceDetectorEvaluator.java SentenceSample.java

Author: joern
Date: Mon Jan 27 10:18:39 2014
New Revision: 1561626

URL: http://svn.apache.org/r1561626
Log:
OPENNLP-602 White space difference are now ignored during sentence detector evaluation.

Modified:
    opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/sentdetect/SentenceDetectorEvaluator.java
    opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/sentdetect/SentenceSample.java

Modified: opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/sentdetect/SentenceDetectorEvaluator.java
URL: http://svn.apache.org/viewvc/opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/sentdetect/SentenceDetectorEvaluator.java?rev=1561626&r1=1561625&r2=1561626&view=diff
==============================================================================
--- opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/sentdetect/SentenceDetectorEvaluator.java (original)
+++ opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/sentdetect/SentenceDetectorEvaluator.java Mon Jan 27 10:18:39 2014
@@ -51,10 +51,20 @@ public class SentenceDetectorEvaluator e
     this.sentenceDetector = sentenceDetector;
   }
 
+  private Span[] trimSpans(String document, Span spans[]) {
+    Span trimedSpans[] = new Span[spans.length];
+    
+    for (int i = 0; i < spans.length; i++) {
+      trimedSpans[i] = spans[i].trim(document);
+    }
+    
+    return trimedSpans;
+  }
+  
   @Override
   protected SentenceSample processSample(SentenceSample sample) {
-    Span predictions[] = sentenceDetector.sentPosDetect(sample.getDocument());
-    Span[] references = sample.getSentences();
+    Span predictions[] = trimSpans(sample.getDocument(), sentenceDetector.sentPosDetect(sample.getDocument()));
+    Span[] references = trimSpans(sample.getDocument(), sample.getSentences());
 
     fmeasure.updateScores(references, predictions);
     

Modified: opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/sentdetect/SentenceSample.java
URL: http://svn.apache.org/viewvc/opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/sentdetect/SentenceSample.java?rev=1561626&r1=1561625&r2=1561626&view=diff
==============================================================================
--- opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/sentdetect/SentenceSample.java (original)
+++ opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/sentdetect/SentenceSample.java Mon Jan 27 10:18:39 2014
@@ -100,16 +100,6 @@ public class SentenceSample {
     return documentBuilder.toString();
   }
   
-  private Span[] trimSpans(Span spans[]) {
-    Span trimedSpans[] = new Span[spans.length];
-    
-    for (int i = 0; i < spans.length; i++) {
-      trimedSpans[i] = spans[i].trim(document);
-    }
-    
-    return trimedSpans;
-  }
-  
   @Override
   public boolean equals(Object obj) {
     if (this == obj) {
@@ -118,7 +108,7 @@ public class SentenceSample {
       SentenceSample a = (SentenceSample) obj;
       
       return getDocument().equals(a.getDocument())
-          && Arrays.equals(trimSpans(getSentences()), trimSpans(a.getSentences()));
+          && Arrays.equals(getSentences(), a.getSentences());
     } else {
       return false;
     }