You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "pandaapo (via GitHub)" <gi...@apache.org> on 2023/05/12 17:19:34 UTC
[GitHub] [eventmesh] pandaapo opened a new pull request, #3916: [ISSUE #3912]There are boilerplate codes in PrometheusTcpExporter, PrometheusHttpExporter
pandaapo opened a new pull request, #3916:
URL: https://github.com/apache/eventmesh/pull/3916
Fixes #3912.
### Motivation
See "Enhancement Request" in [issue](https://github.com/apache/eventmesh/issues/3912#issue-1707257725).
### Modifications
See "Describe the solution you'd like" in[ issue](https://github.com/apache/eventmesh/issues/3912#issue-1707257725).
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3916: [ISSUE #3912]There are boilerplate codes in PrometheusTcpExporter, PrometheusHttpExporter
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3916:
URL: https://github.com/apache/eventmesh/pull/3916#issuecomment-1567054913
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3916?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#3916](https://app.codecov.io/gh/apache/eventmesh/pull/3916?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b45950c) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/0ce8d57e6a87890354fdc0643f06aae4acb6cc41?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0ce8d57) will **increase** coverage by `0.08%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head b45950c differs from pull request most recent head d1a7aae. Consider uploading reports for the commit d1a7aae to get more accurate results
```diff
@@ Coverage Diff @@
## master #3916 +/- ##
============================================
+ Coverage 14.24% 14.32% +0.08%
Complexity 1320 1320
============================================
Files 579 581 +2
Lines 28967 28764 -203
Branches 2802 2781 -21
============================================
- Hits 4125 4121 -4
+ Misses 24450 24252 -198
+ Partials 392 391 -1
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/3916?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...col/http/body/message/PushMessageResponseBody.java](https://app.codecov.io/gh/apache/eventmesh/pull/3916?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2JvZHkvbWVzc2FnZS9QdXNoTWVzc2FnZVJlc3BvbnNlQm9keS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ol/http/body/message/ReplyMessageResponseBody.java](https://app.codecov.io/gh/apache/eventmesh/pull/3916?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2JvZHkvbWVzc2FnZS9SZXBseU1lc3NhZ2VSZXNwb25zZUJvZHkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ttp/body/message/SendMessageBatchResponseBody.java](https://app.codecov.io/gh/apache/eventmesh/pull/3916?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2JvZHkvbWVzc2FnZS9TZW5kTWVzc2FnZUJhdGNoUmVzcG9uc2VCb2R5LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...p/body/message/SendMessageBatchV2ResponseBody.java](https://app.codecov.io/gh/apache/eventmesh/pull/3916?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2JvZHkvbWVzc2FnZS9TZW5kTWVzc2FnZUJhdGNoVjJSZXNwb25zZUJvZHkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...col/http/body/message/SendMessageResponseBody.java](https://app.codecov.io/gh/apache/eventmesh/pull/3916?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2JvZHkvbWVzc2FnZS9TZW5kTWVzc2FnZVJlc3BvbnNlQm9keS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ics/prometheus/metrics/PrometheusGrpcExporter.java](https://app.codecov.io/gh/apache/eventmesh/pull/3916?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLW1ldHJpY3MtcGx1Z2luL2V2ZW50bWVzaC1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9tZXRyaWNzL3Byb21ldGhldXMvbWV0cmljcy9Qcm9tZXRoZXVzR3JwY0V4cG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ics/prometheus/metrics/PrometheusHttpExporter.java](https://app.codecov.io/gh/apache/eventmesh/pull/3916?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLW1ldHJpY3MtcGx1Z2luL2V2ZW50bWVzaC1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9tZXRyaWNzL3Byb21ldGhldXMvbWV0cmljcy9Qcm9tZXRoZXVzSHR0cEV4cG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...rics/prometheus/metrics/PrometheusTcpExporter.java](https://app.codecov.io/gh/apache/eventmesh/pull/3916?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLW1ldHJpY3MtcGx1Z2luL2V2ZW50bWVzaC1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9tZXRyaWNzL3Byb21ldGhldXMvbWV0cmljcy9Qcm9tZXRoZXVzVGNwRXhwb3J0ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../prometheus/utils/PrometheusExporterConstants.java](https://app.codecov.io/gh/apache/eventmesh/pull/3916?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLW1ldHJpY3MtcGx1Z2luL2V2ZW50bWVzaC1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9tZXRyaWNzL3Byb21ldGhldXMvdXRpbHMvUHJvbWV0aGV1c0V4cG9ydGVyQ29uc3RhbnRzLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...rics/prometheus/utils/PrometheusExporterUtils.java](https://app.codecov.io/gh/apache/eventmesh/pull/3916?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLW1ldHJpY3MtcGx1Z2luL2V2ZW50bWVzaC1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9tZXRyaWNzL3Byb21ldGhldXMvdXRpbHMvUHJvbWV0aGV1c0V4cG9ydGVyVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [12 more](https://app.codecov.io/gh/apache/eventmesh/pull/3916?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/3916/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #3916: [ISSUE #3912]There are boilerplate codes in PrometheusTcpExporter, PrometheusHttpExporter
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3916:
URL: https://github.com/apache/eventmesh/pull/3916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org