You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/18 23:02:37 UTC

[GitHub] [kafka] ijuma opened a new pull request #8899: MINOR: Gate test coverage plugin behind Gradle property

ijuma opened a new pull request #8899:
URL: https://github.com/apache/kafka/pull/8899


   Most builds don't require test coverage output, so it's wasteful
   to spend cycles tracking coverage information for each method
   invoked.
   
   I ran a quick test in a fast desktop machine, the absolute
   difference will be larger in a slower machine. The tests were
   executed after `./gradlew clean` and with a gradlew daemon
   that was started just before the test (and mildly warmed up
   with `./gradlew clean` again).
   
   `./gradlew unitTest --continue --profile`:
   * With coverage enabled: 6m32s
   * With coverage disabled: 5m47s
   
   I ran the same test twice and the results were within 2s of
   each other, so reasonably consistent.
   
   16% reduction in the time taken to run the unit tests is a
   reasonable gain with little downside, so I think this is a
   good change.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma merged pull request #8899: MINOR: Reduce build time by gating test coverage plugins behind a flag

Posted by GitBox <gi...@apache.org>.
ijuma merged pull request #8899:
URL: https://github.com/apache/kafka/pull/8899


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #8899: MINOR: Reduce build time by gating test coverage plugins behind a flag

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #8899:
URL: https://github.com/apache/kafka/pull/8899#issuecomment-646631428


   Flaky test failure:
   
   > 
   org.apache.kafka.connect.mirror.MirrorConnectorsIntegrationTest.testReplication


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma edited a comment on pull request #8899: MINOR: Reduce build time by gating test coverage plugins behind a flag

Posted by GitBox <gi...@apache.org>.
ijuma edited a comment on pull request #8899:
URL: https://github.com/apache/kafka/pull/8899#issuecomment-646631428


   Flaky test failure:
   
   > org.apache.kafka.connect.mirror.MirrorConnectorsIntegrationTest.testReplication


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org