You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by "yikuaibro (via GitHub)" <gi...@apache.org> on 2023/04/04 08:54:14 UTC

[GitHub] [shardingsphere-on-cloud] yikuaibro opened a new issue, #292: [DISCUSS] Introduce new CRD as StorageNode for better usability

yikuaibro opened a new issue, #292:
URL: https://github.com/apache/shardingsphere-on-cloud/issues/292

### StorageNode Design
Similar to ComputeNode, StorageNode should represent an abstraction of a group of storage nodes. In addition to data sources and schemas, its attributes also involve storage topology, type, and implementation.

StorageNode can be manually created and specified or can be automatically created by dynamic-provisioner through the CRD of DatabaseClass.
Then the attributes in ```StorageNodeSpec``` probably include:
- DatabaseClass Name (data source configuration class property)
- total storage capacity
- Allocatable storage capacity

```StorageNodeStatus``` needs to reflect the overall status and condition of the instance or cluster.
Similarly, similar to Kubernetes' StorageClass and IngressClass, DatabaseClass is also an abstract management of storage resources. Since it needs to be consumed by different Controllers (because StorageNodes need to be created), the Spec must be sufficiently abstract. The basic attributes include:
- Provisioner
- Parameters (data source configuration)

@mlycore At present, the temporary design is like this. Is there anything else that I haven't considered? Or which ones are inappropriate?
Looking forward to your guidance and suggestions!

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-on-cloud] mlycore closed issue #292: [DISCUSS] Introduce new CRD as StorageNode for better usability

Posted by "mlycore (via GitHub)" <gi...@apache.org>.

mlycore closed issue #292: [DISCUSS] Introduce new CRD as StorageNode for better usability
URL: https://github.com/apache/shardingsphere-on-cloud/issues/292


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-on-cloud] Xu-Wentao commented on issue #292: [DISCUSS] Introduce new CRD as StorageNode for better usability

Posted by "Xu-Wentao (via GitHub)" <gi...@apache.org>.

Xu-Wentao commented on issue #292:
URL: https://github.com/apache/shardingsphere-on-cloud/issues/292#issuecomment-1517193386

   #314 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-on-cloud] yikuaibro commented on issue #292: [DISCUSS] Introduce new CRD as StorageNode for better usability

Posted by "yikuaibro (via GitHub)" <gi...@apache.org>.

yikuaibro commented on issue #292:
URL: https://github.com/apache/shardingsphere-on-cloud/issues/292#issuecomment-1565425463

   @Xu-Wentao Thank you very much for your guidance, I am honored to participate in the contribution, and I will try to fix them when I am free.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-on-cloud] Xu-Wentao commented on issue #292: [DISCUSS] Introduce new CRD as StorageNode for better usability

Posted by "Xu-Wentao (via GitHub)" <gi...@apache.org>.

Xu-Wentao commented on issue #292:
URL: https://github.com/apache/shardingsphere-on-cloud/issues/292#issuecomment-1495766170

   #293 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-on-cloud] Xu-Wentao commented on issue #292: [DISCUSS] Introduce new CRD as StorageNode for better usability

Posted by "Xu-Wentao (via GitHub)" <gi...@apache.org>.

Xu-Wentao commented on issue #292:
URL: https://github.com/apache/shardingsphere-on-cloud/issues/292#issuecomment-1563925249

   > two things need to fix
   > 
   > 1. when register storage unit, get datasource info from storage node's anno, like db's username and password. If these two param did not exist, need to get info from databaseclass default value.
   > 2. check aws rds instance `CreateInstance` with setDBName if it works.
   
   @yikuaibro If you have free time, plz check upon two points.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-on-cloud] Xu-Wentao commented on issue #292: [DISCUSS] Introduce new CRD as StorageNode for better usability

Posted by "Xu-Wentao (via GitHub)" <gi...@apache.org>.

Xu-Wentao commented on issue #292:
URL: https://github.com/apache/shardingsphere-on-cloud/issues/292#issuecomment-1563924644

   two things need to fix
   1. when register storage unit, get datasource info from storage node's anno, like db's username and password. If these two param did not exist, need to get info from databaseclass default value.
   2. check aws rds instance `CreateInstance` with setDBName if it works.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org