[GitHub] [maven-mvnd] gzm55 commented on pull request #722: Use muti-release jar to fallback mvnd-client to original maven

[GitBox <gi...@apache.org>]

gzm55 commented on PR #722:
URL: https://github.com/apache/maven-mvnd/pull/722#issuecomment-1283540909

   > Do I understand correctly that this is intended to provide an automatic fallback to the embedded vanilla Maven on platforms for which we (1) do not have a GraalVM native executable and (2) they have java <11?
   > 
   > There is no change in behavior on systems where the mvnd native executable works (because that one is inherrently Java 11), right?
   
   Right.
   
   > 
   > I wonder what are the advantages against running Maven in the traditional way on those systems?
   
   Improve the usability, and developers can only install mvnd package for a faster and more reliable maven.
   
   > 
   > I wonder how portable the fallback is: we forward all command line parameters, some of which won't work with the embedded Maven.
   
   Now only few flags break the original maven.
   1. Some of which _should_ break the invokes, e.g. `--completion|--purge|--status|--stop`, they have special effect only for mvnd.
   2. Others, like `-1|--serial|--raw-streams`, could be removed in the fallback `main()` without changing the invoke purpose. Now this fix is not implemented to let the fallback codes clean to review.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org