You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/10/27 05:28:01 UTC
[GitHub] [dubbo-go] codecov-io commented on pull request #808: when it need local ip, it will get it every time. We can get local ip once, and reused it.
codecov-io commented on pull request #808:
URL: https://github.com/apache/dubbo-go/pull/808#issuecomment-716991925
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/808?src=pr&el=h1) Report
> Merging [#808](https://codecov.io/gh/apache/dubbo-go/pull/808?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/bec8195b21a2166e562bf466efa7924f186e5df3?el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `46.66%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/808?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #808 +/- ##
===========================================
+ Coverage 59.92% 59.97% +0.05%
===========================================
Files 259 260 +1
Lines 12752 12756 +4
===========================================
+ Hits 7642 7651 +9
+ Misses 4158 4149 -9
- Partials 952 956 +4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/808?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/808/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `66.66% <0.00%> (ø)` | |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/808/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `53.15% <0.00%> (ø)` | |
| [config\_center/configurator/override.go](https://codecov.io/gh/apache/dubbo-go/pull/808/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9jb25maWd1cmF0b3Ivb3ZlcnJpZGUuZ28=) | `72.22% <0.00%> (ø)` | |
| [registry/consul/utils.go](https://codecov.io/gh/apache/dubbo-go/pull/808/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3V0aWxzLmdv) | `67.50% <0.00%> (ø)` | |
| [common/host\_util.go](https://codecov.io/gh/apache/dubbo-go/pull/808/diff?src=pr&el=tree#diff-Y29tbW9uL2hvc3RfdXRpbC5nbw==) | `50.00% <50.00%> (ø)` | |
| [cluster/cluster\_impl/failover\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/808/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbG92ZXJfY2x1c3Rlcl9pbnZva2VyLmdv) | `70.00% <100.00%> (ø)` | |
| [cluster/router/condition/router.go](https://codecov.io/gh/apache/dubbo-go/pull/808/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY29uZGl0aW9uL3JvdXRlci5nbw==) | `78.91% <100.00%> (ø)` | |
| [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/808/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `74.01% <100.00%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/808/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `60.86% <100.00%> (ø)` | |
| [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/808/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `50.74% <100.00%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/dubbo-go/pull/808/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/808?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/808?src=pr&el=footer). Last update [bec8195...04bb28d](https://codecov.io/gh/apache/dubbo-go/pull/808?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org