[GitHub] [accumulo] cradal commented on a change in pull request #1563: Work-In-Progress Fixes #1473 - Move TabletsMetaData builder to Ample

[GitBox <gi...@apache.org>]

cradal commented on a change in pull request #1563: Work-In-Progress Fixes #1473 - Move TabletsMetaData builder to Ample
URL: https://github.com/apache/accumulo/pull/1563#discussion_r395095182
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/metadata/schema/AmpleImpl.java
 ##########
 @@ -42,4 +43,9 @@ public TabletMetadata readTablet(KeyExtent extent, ColumnType... colsToFetch) {
       return Iterables.getOnlyElement(tablets);
     }
   }
+
+  public TableOptions readTablets() {
+    TableOptions builder = TabletsMetadata.builder();
 
 Review comment:
   @keith-turner I've tried to see if this would work without modifying TabletsMetadata. but I have not come up with anything yet. The builder() function returns a new Builder(), but Builder() is private. Builder()'s build() method is the only public build method. This is also the only way so far to access forTable() and its associated implementation. I will keep looking at it, keeping in mind our goal to keep the implementation in TabletsMetadata.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services