You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@maven.apache.org by John Fallows <jo...@gmail.com> on 2005/07/14 20:21:30 UTC
[m2] MNG-320 .svn files get copied in the generated WAR file
MNG-320 seems to still be a problem in 2.0-alpha-3.
http://jira.codehaus.org/browse/MNG-320
Looking at the WarMojo source on the trunk, it seems there is a TODO
comment indicating that includes and excludes should be applied while
copying resources.
if ( new File( warSourceDirectory ).exists() )
{
//TODO : Use includes and excludes
FileUtils.copyDirectoryStructure( sourceDirectory, webappDirectory );
}
It seems that this should read:
if ( new File( warSourceDirectory ).exists() )
{
FileUtils.copyDirectoryStructure( sourceDirectory, webappDirectory,
includes, excludes );
}
given that all the hard work was done in Plexus-utils to support a
version of FileUtils.copyDirectoryStructure that also takes includes
and excludes, but it is not being called from WarMojo.
Should MNG-320 be reopened, or is something else going on here?
Kind Regards,
John Fallows.
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org
Re: [m2] MNG-320 .svn files get copied in the generated WAR file
Posted by Brett Porter <br...@gmail.com>.
Hi John,
Sorry for the delayed response. I'm looking at it0016 and the WAR does
not include .svn directories (these are excluded by default from the
copyDirectoryStructure method).
Are you still experiencing this? If so, can you try a clean first?
Cheers,
Brett
On 7/15/05, John Fallows <jo...@gmail.com> wrote:
> MNG-320 seems to still be a problem in 2.0-alpha-3.
>
> http://jira.codehaus.org/browse/MNG-320
>
> Looking at the WarMojo source on the trunk, it seems there is a TODO
> comment indicating that includes and excludes should be applied while
> copying resources.
>
> if ( new File( warSourceDirectory ).exists() )
> {
> //TODO : Use includes and excludes
> FileUtils.copyDirectoryStructure( sourceDirectory, webappDirectory );
> }
>
> It seems that this should read:
>
> if ( new File( warSourceDirectory ).exists() )
> {
> FileUtils.copyDirectoryStructure( sourceDirectory, webappDirectory,
> includes, excludes );
> }
>
> given that all the hard work was done in Plexus-utils to support a
> version of FileUtils.copyDirectoryStructure that also takes includes
> and excludes, but it is not being called from WarMojo.
>
> Should MNG-320 be reopened, or is something else going on here?
>
> Kind Regards,
> John Fallows.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> For additional commands, e-mail: users-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org
Re: Réf. : Re: [m2] Tasklist plugin converted: what should I do now?
Posted by Brett Porter <br...@gmail.com>.
Thanks, we'll take a look in the next few days.
- Brett
On 7/22/05, fabrice.belingard@mpsa.com <fa...@mpsa.com> wrote:
>
>
>
>
> Brett,
>
> I posted the code on JIRA. You can find it at:
> http://jira.codehaus.org/browse/MPTASKLIST-13
>
> Feel free to contact me for any information you might need.
>
> Best Regards / Cordialement,
> Fabrice BELLINGARD
> DINQ/DSIN/INSI/EATE/IDVS/AIDV
> (+33) (01 61) 45 15 91 - fabrice.belingard@mpsa.com
>
>
>
> Brett Porter
> <brett.porter@gm
> ail.com> Pour
> Maven Users List
> 21/07/2005 03:59 <us...@maven.apache.org>
> cc
>
> Veuillez Objet
> répondre à Re: [m2] Tasklist plugin converted:
> Maven Users List what should I do now?
> <users@maven.apa
> che.org>
>
>
>
>
>
>
>
>
> That sounds great!
>
> Please submit it as an attachment to JIRA so we can review it.
>
> Cheers,
> Brett
>
> On 7/21/05, fabrice.belingard@mpsa.com <fa...@mpsa.com> wrote:
> >
> >
> >
> >
> > Hi guys!
> >
> > First of all, I'd like to congratulate the m2 team for the great work
> > they've done, especially the various APIs (MOFO, reporting, doxia,
> ...etc)
> > which are a pleasure to use to develop plugins. :o)
> >
> > To discover the m2-style plugin writing, I converted the tasklist plugin
> > into a taglist plugin. "taglist" plugin because I added the possibility
> to
> > look for any kind of user task tag :
> > - Javadoc ones, as it used to be: @todo, @whatever, ...
> > - but also any kind of tag found in a Java comment ("// TODO" for
> > instance). This works for any Java comment (//, /* or /**).
> >
> > What should I do now to contribute this code to the Maven project?
> > Can someone contact me to tell me what to do?
> >
> > Cheers!
> >
> > Best Regards / Cordialement,
> > Fabrice BELLINGARD
> > DINQ/DSIN/INSI/EATE/IDVS/AIDV
> > (+33) (01 61) 45 15 91 - fabrice.belingard@mpsa.com
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> > For additional commands, e-mail: users-help@maven.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> For additional commands, e-mail: users-help@maven.apache.org
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> For additional commands, e-mail: users-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org
Réf. : Re: [m2] Tasklist plugin converted: what should I do now?
Posted by fa...@mpsa.com.
Brett,
I posted the code on JIRA. You can find it at:
http://jira.codehaus.org/browse/MPTASKLIST-13
Feel free to contact me for any information you might need.
Best Regards / Cordialement,
Fabrice BELLINGARD
DINQ/DSIN/INSI/EATE/IDVS/AIDV
(+33) (01 61) 45 15 91 - fabrice.belingard@mpsa.com
Brett Porter
<brett.porter@gm
ail.com> Pour
Maven Users List
21/07/2005 03:59 <us...@maven.apache.org>
cc
Veuillez Objet
répondre à Re: [m2] Tasklist plugin converted:
Maven Users List what should I do now?
<users@maven.apa
che.org>
That sounds great!
Please submit it as an attachment to JIRA so we can review it.
Cheers,
Brett
On 7/21/05, fabrice.belingard@mpsa.com <fa...@mpsa.com> wrote:
>
>
>
>
> Hi guys!
>
> First of all, I'd like to congratulate the m2 team for the great work
> they've done, especially the various APIs (MOFO, reporting, doxia,
...etc)
> which are a pleasure to use to develop plugins. :o)
>
> To discover the m2-style plugin writing, I converted the tasklist plugin
> into a taglist plugin. "taglist" plugin because I added the possibility
to
> look for any kind of user task tag :
> - Javadoc ones, as it used to be: @todo, @whatever, ...
> - but also any kind of tag found in a Java comment ("// TODO" for
> instance). This works for any Java comment (//, /* or /**).
>
> What should I do now to contribute this code to the Maven project?
> Can someone contact me to tell me what to do?
>
> Cheers!
>
> Best Regards / Cordialement,
> Fabrice BELLINGARD
> DINQ/DSIN/INSI/EATE/IDVS/AIDV
> (+33) (01 61) 45 15 91 - fabrice.belingard@mpsa.com
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> For additional commands, e-mail: users-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org
Re: [m2] Tasklist plugin converted: what should I do now?
Posted by Brett Porter <br...@gmail.com>.
That sounds great!
Please submit it as an attachment to JIRA so we can review it.
Cheers,
Brett
On 7/21/05, fabrice.belingard@mpsa.com <fa...@mpsa.com> wrote:
>
>
>
>
> Hi guys!
>
> First of all, I'd like to congratulate the m2 team for the great work
> they've done, especially the various APIs (MOFO, reporting, doxia, ...etc)
> which are a pleasure to use to develop plugins. :o)
>
> To discover the m2-style plugin writing, I converted the tasklist plugin
> into a taglist plugin. "taglist" plugin because I added the possibility to
> look for any kind of user task tag :
> - Javadoc ones, as it used to be: @todo, @whatever, ...
> - but also any kind of tag found in a Java comment ("// TODO" for
> instance). This works for any Java comment (//, /* or /**).
>
> What should I do now to contribute this code to the Maven project?
> Can someone contact me to tell me what to do?
>
> Cheers!
>
> Best Regards / Cordialement,
> Fabrice BELLINGARD
> DINQ/DSIN/INSI/EATE/IDVS/AIDV
> (+33) (01 61) 45 15 91 - fabrice.belingard@mpsa.com
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> For additional commands, e-mail: users-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org
[m2] Tasklist plugin converted: what should I do now?
Posted by fa...@mpsa.com.
Hi guys!
First of all, I'd like to congratulate the m2 team for the great work
they've done, especially the various APIs (MOFO, reporting, doxia, ...etc)
which are a pleasure to use to develop plugins. :o)
To discover the m2-style plugin writing, I converted the tasklist plugin
into a taglist plugin. "taglist" plugin because I added the possibility to
look for any kind of user task tag :
- Javadoc ones, as it used to be: @todo, @whatever, ...
- but also any kind of tag found in a Java comment ("// TODO" for
instance). This works for any Java comment (//, /* or /**).
What should I do now to contribute this code to the Maven project?
Can someone contact me to tell me what to do?
Cheers!
Best Regards / Cordialement,
Fabrice BELLINGARD
DINQ/DSIN/INSI/EATE/IDVS/AIDV
(+33) (01 61) 45 15 91 - fabrice.belingard@mpsa.com
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org
Re: [m2] Build.properties Equivalent - Correction
Posted by David Le Strat <dl...@yahoo.com>.
Thanks John. Great email. I guess the models are just
different.
One of the nice things about the old build.properties
approach is that it offered a way to share properties
between an Ant build and a maven build.
Let say I have a set of components built using Maven
and a larger project (consumer of the components) with
a complicated ant process, let's call it Z. Each
components has a set of dependencies to other. Let
say we have A, B, C. A depends on B, B depends on C.
And all A, B, C are dependencies for Z. When I build
Z, i need to specify the dependency for A, B, C.
In the new world, the way to do this I guess is to
invoke the artifact:dependencies task to set the
dependencies from a maven pom in an Ant path
environment property.
This is quite an elegant approach. Just takes some
getting used to.
Regards,
David Le Strat.
--- John Casey <jd...@commonjava.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> You should never need to do that in maven2. Instead,
> you have an option
> of defining a hierarchy of poms, and within that
> hierarchy defining a
> set of managed dependencies. This is an important
> concept, since it
> allows you to declare properties (notably version)
> of a dependency for
> use in that hierarchy BUT NOT EVERYWHERE. What I
> mean is, you can define
> it once in a parent pom in this way:
>
> <project>
> ...
> ~ <dependencyManagement>
> ~ <dependencies>
> ~ <dependency>
> ~ <groupId>junit</groupId>
> ~ <artifactId>junit</artifactId>
> ~ <version>3.8.1</version>
> ~ <scope>test</scope>
> ~ </dependency>
> ~ </dependencies>
> ~ </dependencyManagement>
> ...
> </project>
>
> in the parent pom, and then refer to this in one or
> more of the child
> poms like so:
>
> <project>
> ...
> ~ <dependencies>
> ~ <dependency>
> ~ <groupId>junit</groupId>
> ~ <artifactId>junit</artifactId>
> ~ </dependency>
> ~ </dependencies>
> ...
> </project>
>
> In this child pom, the scope and version will be
> inferred from the
> managed dependencies section of it's ancestry.
> However, if you define
> another child pom like such:
>
> <project>
> ...
> ~ <dependencies>
> ~ <dependency>
> ~ <groupId>something-else</groupId>
> ~ <artifactId>something-else</artifactId>
> ~ <version>1.0</version>
> ~ </dependency>
> ~ <!-- NOTE: no reference to junit here -->
> ~ </dependencies>
> ...
> </project>
>
> then THIS child will NOT have any dependency on
> junit; it will not be
> included in any of the compile, test, or other
> classpaths during the
> build, and it will not be bundled with that second
> child in any way.
>
> Therefore, the managed dependencies allow you to
> provide standardization
> of the usage for certain dependencies used in your
> project hierarchy,
> without requiring that they be used in all
> subprojects.
>
> For maven2, the pom is completely self-contained for
> portability. In
> rare cases, you may also provide build profiles to
> specify certain
> plugin configurations for different targeted builds,
> like for a
> development environment vs. a testing environment.
> However, in general,
> we're discouraging the old non-portable companion
> file approach that we
> used in maven 1.x.
>
> Hope that helps,
>
> john
>
> David Le Strat wrote:
> | All,
> |
> | Does any one know the equivalent of
> build.properties
> | in M2? How can I do something like
> |
> | pom.xml:
> |
> | ....
> | <dependency>
> | ...
> | <version>${my.dep.version}</version>
> | ...
> | </dependency>
> |
> | Regards,
> |
> | David Le Strat.
> |
> | ________________________
> | David Le Strat
> | Blogging @ http://dlsthoughts.blogspot.com
> |
> |
> |
> |
> ____________________________________________________
> | Start your day with Yahoo! - make it your home
> page
> | http://www.yahoo.com/r/hs
> |
> |
> |
>
---------------------------------------------------------------------
> | To unsubscribe, e-mail:
> users-unsubscribe@maven.apache.org
> | For additional commands, e-mail:
> users-help@maven.apache.org
> |
> |
> |
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.2.6 (GNU/Linux)
>
>
iD8DBQFC1rC+K3h2CZwO/4URAu1OAKCCypl68GInmU50jPrJd+199TLxTwCeOsYN
> IcI3KmCWN7xQWk9BAyKOqUU=
> =o+On
> -----END PGP SIGNATURE-----
>
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> users-unsubscribe@maven.apache.org
> For additional commands, e-mail:
> users-help@maven.apache.org
>
>
________________________
David Le Strat
Blogging @ http://dlsthoughts.blogspot.com
____________________________________________________
Start your day with Yahoo! - make it your home page
http://www.yahoo.com/r/hs
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org
Re: [m2] Build.properties Equivalent - Correction
Posted by John Casey <jd...@commonjava.org>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
You should never need to do that in maven2. Instead, you have an option
of defining a hierarchy of poms, and within that hierarchy defining a
set of managed dependencies. This is an important concept, since it
allows you to declare properties (notably version) of a dependency for
use in that hierarchy BUT NOT EVERYWHERE. What I mean is, you can define
it once in a parent pom in this way:
<project>
...
~ <dependencyManagement>
~ <dependencies>
~ <dependency>
~ <groupId>junit</groupId>
~ <artifactId>junit</artifactId>
~ <version>3.8.1</version>
~ <scope>test</scope>
~ </dependency>
~ </dependencies>
~ </dependencyManagement>
...
</project>
in the parent pom, and then refer to this in one or more of the child
poms like so:
<project>
...
~ <dependencies>
~ <dependency>
~ <groupId>junit</groupId>
~ <artifactId>junit</artifactId>
~ </dependency>
~ </dependencies>
...
</project>
In this child pom, the scope and version will be inferred from the
managed dependencies section of it's ancestry. However, if you define
another child pom like such:
<project>
...
~ <dependencies>
~ <dependency>
~ <groupId>something-else</groupId>
~ <artifactId>something-else</artifactId>
~ <version>1.0</version>
~ </dependency>
~ <!-- NOTE: no reference to junit here -->
~ </dependencies>
...
</project>
then THIS child will NOT have any dependency on junit; it will not be
included in any of the compile, test, or other classpaths during the
build, and it will not be bundled with that second child in any way.
Therefore, the managed dependencies allow you to provide standardization
of the usage for certain dependencies used in your project hierarchy,
without requiring that they be used in all subprojects.
For maven2, the pom is completely self-contained for portability. In
rare cases, you may also provide build profiles to specify certain
plugin configurations for different targeted builds, like for a
development environment vs. a testing environment. However, in general,
we're discouraging the old non-portable companion file approach that we
used in maven 1.x.
Hope that helps,
john
David Le Strat wrote:
| All,
|
| Does any one know the equivalent of build.properties
| in M2? How can I do something like
|
| pom.xml:
|
| ....
| <dependency>
| ...
| <version>${my.dep.version}</version>
| ...
| </dependency>
|
| Regards,
|
| David Le Strat.
|
| ________________________
| David Le Strat
| Blogging @ http://dlsthoughts.blogspot.com
|
|
|
| ____________________________________________________
| Start your day with Yahoo! - make it your home page
| http://www.yahoo.com/r/hs
|
|
| ---------------------------------------------------------------------
| To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
| For additional commands, e-mail: users-help@maven.apache.org
|
|
|
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
iD8DBQFC1rC+K3h2CZwO/4URAu1OAKCCypl68GInmU50jPrJd+199TLxTwCeOsYN
IcI3KmCWN7xQWk9BAyKOqUU=
=o+On
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org
Re: [m2] Build.properties Equivalent - Correction
Posted by David Le Strat <dl...@yahoo.com>.
All,
Does any one know the equivalent of build.properties
in M2? How can I do something like
pom.xml:
....
<dependency>
...
<version>${my.dep.version}</version>
...
</dependency>
Regards,
David Le Strat.
________________________
David Le Strat
Blogging @ http://dlsthoughts.blogspot.com
____________________________________________________
Start your day with Yahoo! - make it your home page
http://www.yahoo.com/r/hs
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org
[m2] Build.properties Equivalent
Posted by David Le Strat <dl...@yahoo.com>.
All,
Does any one know the equivalent of build.properties
in M2? How can I do something like
pom.xml:
....
<dependency>
...
<artifactId>${my.dep.version}</artifactId>
...
</dependency>
Regards,
David Le Strat.
________________________
David Le Strat
Blogging @ http://dlsthoughts.blogspot.com
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org