You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by mj...@apache.org on 2021/10/15 02:00:58 UTC
[kafka] branch trunk updated: HOTFIX: suppress deprecation warnings
to fix compilation errors (#11400)
This is an automated email from the ASF dual-hosted git repository.
mjsax pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 7fbe482 HOTFIX: suppress deprecation warnings to fix compilation errors (#11400)
7fbe482 is described below
commit 7fbe482289fe2c7619bd1e3a1ecfb40aa56c619c
Author: Matthias J. Sax <ma...@confluent.io>
AuthorDate: Thu Oct 14 18:58:20 2021 -0700
HOTFIX: suppress deprecation warnings to fix compilation errors (#11400)
Reviewers: Bill Bejeck <bi...@confluent.io>
---
.../test/java/org/apache/kafka/streams/kstream/JoinWindowsTest.java | 1 +
.../java/org/apache/kafka/streams/kstream/SessionWindowsTest.java | 1 +
.../test/java/org/apache/kafka/streams/kstream/TimeWindowsTest.java | 1 +
.../apache/kafka/streams/kstream/internals/SessionWindowTest.java | 4 ++--
.../org/apache/kafka/streams/kstream/internals/TimeWindowTest.java | 6 +++---
5 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/streams/src/test/java/org/apache/kafka/streams/kstream/JoinWindowsTest.java b/streams/src/test/java/org/apache/kafka/streams/kstream/JoinWindowsTest.java
index 881f0d1..bd604ad 100644
--- a/streams/src/test/java/org/apache/kafka/streams/kstream/JoinWindowsTest.java
+++ b/streams/src/test/java/org/apache/kafka/streams/kstream/JoinWindowsTest.java
@@ -74,6 +74,7 @@ public class JoinWindowsTest {
assertThrows(IllegalArgumentException.class, () -> JoinWindows.ofTimeDifferenceAndGrace(ofMillis(-1), ofMillis(ANY_GRACE)));
}
+ @SuppressWarnings("deprecation")
@Test
public void graceShouldNotCalledAfterGraceSet() {
assertThrows(IllegalStateException.class, () -> JoinWindows.ofTimeDifferenceAndGrace(ofMillis(10), ofMillis(10)).grace(ofMillis(10)));
diff --git a/streams/src/test/java/org/apache/kafka/streams/kstream/SessionWindowsTest.java b/streams/src/test/java/org/apache/kafka/streams/kstream/SessionWindowsTest.java
index c9f44d2..7a8fafd 100644
--- a/streams/src/test/java/org/apache/kafka/streams/kstream/SessionWindowsTest.java
+++ b/streams/src/test/java/org/apache/kafka/streams/kstream/SessionWindowsTest.java
@@ -87,6 +87,7 @@ public class SessionWindowsTest {
assertThrows(IllegalArgumentException.class, () -> SessionWindows.ofInactivityGapWithNoGrace(ofMillis(0)));
}
+ @SuppressWarnings("deprecation")
@Test
public void graceShouldNotCalledAfterGraceSet() {
assertThrows(IllegalStateException.class, () -> SessionWindows.ofInactivityGapAndGrace(ofMillis(10), ofMillis(10)).grace(ofMillis(10)));
diff --git a/streams/src/test/java/org/apache/kafka/streams/kstream/TimeWindowsTest.java b/streams/src/test/java/org/apache/kafka/streams/kstream/TimeWindowsTest.java
index d08c337..2e8f2e7 100644
--- a/streams/src/test/java/org/apache/kafka/streams/kstream/TimeWindowsTest.java
+++ b/streams/src/test/java/org/apache/kafka/streams/kstream/TimeWindowsTest.java
@@ -60,6 +60,7 @@ public class TimeWindowsTest {
assertThrows(IllegalArgumentException.class, () -> TimeWindows.ofSizeWithNoGrace(ofMillis(-1)));
}
+ @SuppressWarnings("deprecation")
@Test
public void graceShouldNotCalledAfterGraceSet() {
assertThrows(IllegalStateException.class, () -> TimeWindows.ofSizeAndGrace(ofMillis(10), ofMillis(10)).grace(ofMillis(10)));
diff --git a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/SessionWindowTest.java b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/SessionWindowTest.java
index 964557a..df23ddd 100644
--- a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/SessionWindowTest.java
+++ b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/SessionWindowTest.java
@@ -24,8 +24,8 @@ import static org.junit.Assert.assertTrue;
public class SessionWindowTest {
- private long start = 50;
- private long end = 100;
+ private final long start = 50;
+ private final long end = 100;
private final SessionWindow window = new SessionWindow(start, end);
private final TimeWindow timeWindow = new TimeWindow(start, end);
diff --git a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/TimeWindowTest.java b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/TimeWindowTest.java
index c558eab..bdfdb16 100644
--- a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/TimeWindowTest.java
+++ b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/TimeWindowTest.java
@@ -27,11 +27,10 @@ import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertThrows;
import static org.junit.Assert.assertTrue;
-@SuppressWarnings("deprecation")
public class TimeWindowTest {
- private long start = 50;
- private long end = 100;
+ private final long start = 50;
+ private final long end = 100;
private final TimeWindow window = new TimeWindow(start, end);
private final SessionWindow sessionWindow = new SessionWindow(start, end);
@@ -125,6 +124,7 @@ public class TimeWindowTest {
assertThrows(IllegalArgumentException.class, () -> window.overlap(sessionWindow));
}
+ @SuppressWarnings("deprecation")
@Test
public void shouldReturnMatchedWindowsOrderedByTimestamp() {
final TimeWindows windows = TimeWindows.of(ofMillis(12L)).advanceBy(ofMillis(5L));