[GitHub] [superset] MayUWish commented on a change in pull request #17944: chore: migrate QueryTable component from jsx to tsx

[GitBox <gi...@apache.org>]

MayUWish commented on a change in pull request #17944:
URL: https://github.com/apache/superset/pull/17944#discussion_r779837346



##########
File path: superset-frontend/package.json
##########
@@ -51,9 +51,9 @@
     "plugins:build-assets": "node ./scripts/copyAssets.js",
     "plugins:build-storybook": "cd packages/superset-ui-demo && npm run build-storybook",
     "plugins:chromatic": "cd packages/superset-ui-demo && npm run chromatic",
-    "plugins:create-conventional-version": "npm run prune && ./scripts/lernaVersion.sh '--conventional-commits --create-release github'",
-    "plugins:create-minor-version": "npm run prune && ./scripts/lernaVersion.sh minor",
-    "plugins:create-patch-version": "npm run prune && ./scripts/lernaVersion.sh patch",
+    "plugins:create-conventional-version": "npm run prune && lerna version --conventional-commits --create-release github --yes",
+    "plugins:create-minor-version": "npm run prune && lerna version minor --yes",
+    "plugins:create-patch-version": "npm run prune && lerna version patch --yes",

Review comment:
       May I know how I can do the rebase? I noticed that package.json and package.lock.json of my files were changed(probably due to installation), thus I copied these 2 files from master branch of this repo and pasted on mine, then I did this pull request. I just compared with master branch one more time, it has line 54-56 in green. **Shall I just replace line 54-56 in green with the original line 56 in red?**




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org