You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by we...@apache.org on 2018/12/04 04:14:46 UTC
spark git commit: [SPARK-25498][SQL][FOLLOW-UP] Return an empty
config set when regenerating the golden files
Repository: spark
Updated Branches:
refs/heads/master 0889fbaf9 -> f7af4a196
[SPARK-25498][SQL][FOLLOW-UP] Return an empty config set when regenerating the golden files
## What changes were proposed in this pull request?
This pr is to return an empty config set when regenerating the golden files in `SQLQueryTestSuite`.
This is the follow-up of #22512.
## How was this patch tested?
N/A
Closes #23212 from maropu/SPARK-25498-FOLLOWUP.
Authored-by: Takeshi Yamamuro <ya...@apache.org>
Signed-off-by: Wenchen Fan <we...@databricks.com>
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/f7af4a19
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/f7af4a19
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/f7af4a19
Branch: refs/heads/master
Commit: f7af4a1965b1052d3c77505ab1b660a294757bed
Parents: 0889fba
Author: Takeshi Yamamuro <ya...@apache.org>
Authored: Tue Dec 4 12:14:38 2018 +0800
Committer: Wenchen Fan <we...@databricks.com>
Committed: Tue Dec 4 12:14:38 2018 +0800
----------------------------------------------------------------------
.../test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/f7af4a19/sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
----------------------------------------------------------------------
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
index fd180ce..cf4585b 100644
--- a/sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
+++ b/sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
@@ -154,14 +154,10 @@ class SQLQueryTestSuite extends QueryTest with SharedSQLContext {
val (conf, value) = confAndValue.span(_ != '=')
conf.trim -> value.substring(1).trim
})
- // When we are regenerating the golden files we don't need to run all the configs as they
+ // When we are regenerating the golden files, we don't need to set any config as they
// all need to return the same result
if (regenerateGoldenFiles) {
- if (configs.nonEmpty) {
- configs.take(1)
- } else {
- Array.empty[Array[(String, String)]]
- }
+ Array.empty[Array[(String, String)]]
} else {
if (configs.nonEmpty) {
codegenConfigSets.flatMap { codegenConfig =>
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org