You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/07/09 16:47:40 UTC
[GitHub] [ozone] dombizita opened a new pull request #2402: HDDS-3983 Ozone RocksDB Iterator wrapper should not expose key() and value() API.
dombizita opened a new pull request #2402:
URL: https://github.com/apache/ozone/pull/2402
## What changes were proposed in this pull request?
It was found that there is discrepancy in the implementation of the next(), key() and value() methods in the RDBStoreIterator wrapper class.
next() returns the current rocksdb entry and moves ahead to the next entry.
key() returns current rocksdb entry's key.
value() returns current rocksdb entry's value.
This means that during iteration next() returns the current value, and subsequent calls to key() / value() after next() will return the next value. To solve this, we can remove those 2 APIs from the iterator class, and have the usages follow this pattern.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3983
## How was this patch tested?
Unit tests locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant commented on pull request #2402: HDDS-3983 Ozone RocksDB Iterator wrapper should not expose key() and value() API.
Posted by GitBox <gi...@apache.org>.
bshashikant commented on pull request #2402:
URL: https://github.com/apache/ozone/pull/2402#issuecomment-932172584
@dombizita , can you please rebase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] errose28 merged pull request #2402: HDDS-3983 Ozone RocksDB Iterator wrapper should not expose key() and value() API.
Posted by GitBox <gi...@apache.org>.
errose28 merged pull request #2402:
URL: https://github.com/apache/ozone/pull/2402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] errose28 merged pull request #2402: HDDS-3983 Ozone RocksDB Iterator wrapper should not expose key() and value() API.
Posted by GitBox <gi...@apache.org>.
errose28 merged pull request #2402:
URL: https://github.com/apache/ozone/pull/2402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org