You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/31 03:55:04 UTC
[GitHub] [skywalking] wu-sheng opened a new pull request #4597: Move to 8.0.0
wu-sheng opened a new pull request #4597: Move to 8.0.0
URL: https://github.com/apache/skywalking/pull/4597
Hi Dev Team
After the experiences of removing endpoint_inventory, I found out this
strategy is successful.
Especially, we totally get rid of register, so I want to do more.
### SkyWalking 8.0.0
First, it is already unexpected for me, we have to move to 8.0.0 so
quickly, but after the discussion with @hanahmily, and thinking about this for several days, I think
we have to.
#### The key chances are following
1. Remove service, service instance, and network address register. The old
register protocols are totally going to be removed.
2. The agent doesn't need to do register anymore. Service name and Service
Instance name are generated by the agent itself, but the extra information,
such as IP, hostname, language, should report to backend separately.
3. Service Traffic should be added just like the endpoint traffic but keep
the time bucket as we need accurate service name in the given duration
4. Service Instance Traffic should be added too, with external information,
such as language, hostname.
5. Trace context propagation context should be changed to accept string in
service instance name, endpoint name and network address. This could ease
the agent logic, but also, requires changes in all language agent and
plugin test tool,
6. Trace report protocol requires to change too, in order to adopt the
string.
7. e2e tests have to ignore PHP and LUA at first, and remove the 6.x
compatibility test(doesn't support anymore). @heyanlong @moonming @dmsolr
#### The benefits we will get are
1. Don't worry about the inventory(s) that has been deleted randomly by end
users. (We received a lot of issue reports about this)
2. The upgrade could be easier erasing the whole storage and reboot the new
one. (Users don't feel comfortable about upgrade)
3. No hot-reboot case in the agent side
4. No cache of network address register information in the agent.
5. No service and service instance cache in the OAP
6. No register lock in the OAP
7. No file buffer mechanism in the OAP too, same as no register happens.
In my mind, I think this totally break upgrade is super meaningful and will
be good change. Even we break many things, they are easy to follow.
@mrproliu I think by following this, we need
to change the collaboration header to `sw8` :) As no 7.1.0 release will
happen.
Mail list, https://lists.apache.org/thread.html/rda36fa8d191fc5750fc793993c69e14a917138bf97f9c2a461b72811%40%3Cdev.skywalking.apache.org%3E
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4597: Move to 8.0.0
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4597: Move to 8.0.0
URL: https://github.com/apache/skywalking/pull/4597#issuecomment-606394992
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4597?src=pr&el=h1) Report
> Merging [#4597](https://codecov.io/gh/apache/skywalking/pull/4597?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/54fb6e7285d695b1bd467edb6df0c3a3254adc12&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4597?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4597 +/- ##
==========================================
- Coverage 26.93% 26.92% -0.01%
==========================================
Files 1256 1256
Lines 28968 28968
Branches 3958 3958
==========================================
- Hits 7802 7800 -2
- Misses 20454 20455 +1
- Partials 712 713 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4597?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../agent/core/context/SW8CorrelationCarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4597/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDb3JyZWxhdGlvbkNhcnJpZXJJdGVtLmphdmE=) | `100.00% <ø> (ø)` | |
| [...walking/apm/agent/core/context/ContextCarrier.java](https://codecov.io/gh/apache/skywalking/pull/4597/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0Q2Fycmllci5qYXZh) | `72.41% <100.00%> (ø)` | |
| [.../skywalking/apm/plugin/spring/patch/MatchUtil.java](https://codecov.io/gh/apache/skywalking/pull/4597/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvY29yZS1wYXRjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9wYXRjaC9NYXRjaFV0aWwuamF2YQ==) | `37.50% <0.00%> (-12.50%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4597?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4597?src=pr&el=footer). Last update [54fb6e7...503fd9d](https://codecov.io/gh/apache/skywalking/pull/4597?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng merged pull request #4597: Move to 8.0.0
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4597: Move to 8.0.0
URL: https://github.com/apache/skywalking/pull/4597
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services