You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Sammy Nah (Code Review)" <ge...@cloudera.org> on 2023/04/18 21:16:22 UTC
[kudu-CR] [BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW
Sammy Nah has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19764
Change subject: [BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW
......................................................................
[BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW
Blocked by https://gerrit.cloudera.org/#/c/19726/
This commit adds support for a high bandwidth memory cache
based on hbwmalloc[1]. The cache is configured using
a new flag --block_cache_type=HBW.
For testing purposes, the new cache implementation wil be run on
DRAM by calling hbw_set_policy() with HBW_POLICY_PREFERRED though
there is not likely to be a performance advantage.
The code changes contained are:
* introduce the new flags to select the cache implementation
* introduce the new cache implementation, which uses hbwmalloc APIs to
allocate/free memory
* cfile-test and block_cache-test are made into value-parameterized tests
and test with all three cache types.
[1] http://memkind.github.io/memkind/man_pages/hbwmalloc.html
Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
---
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
M src/kudu/util/cache.h
A src/kudu/util/hbw_cache.cc
A src/kudu/util/hbw_cache.h
A src/kudu/util/memkind_cache.cc
A src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
11 files changed, 1,011 insertions(+), 473 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/19764/1
--
To view, visit http://gerrit.cloudera.org:8080/19764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
Gerrit-Change-Number: 19764
Gerrit-PatchSet: 1
Gerrit-Owner: Sammy Nah <sa...@intel.com>
[kudu-CR] [hbw cache] KUDU-3342 Add an implementation of the block cache on HBW
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Yuqi Du, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19764
to look at the new patch set (#21).
Change subject: [hbw_cache] KUDU-3342 Add an implementation of the block cache on HBW
......................................................................
[hbw_cache] KUDU-3342 Add an implementation of the block cache on HBW
This commit adds support for a high bandwidth memory cache
based on hbwmalloc[1]. The cache is configured using
a new flag --block_cache_type=HBW.
For testing purposes, the new cache implementation will be run on
DRAM by calling hbw_set_policy() with HBW_POLICY_PREFERRED though
there is not likely to be a performance advantage.
The code changes contained are,
* introduce the new flags to select the cache implementation
* introduce the new cache implementation, which uses hbwmalloc APIs to
allocate/free memory
* cfile-test and block_cache-test are made into value-parameterized tests
and test with all three cache types.
[1] http://memkind.github.io/memkind/man_pages/hbwmalloc.html
Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
---
M docs/installation.adoc
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
M src/kudu/util/cache.h
A src/kudu/util/hbw_cache.cc
A src/kudu/util/hbw_cache.h
M src/kudu/util/memkind_cache.cc
M src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
M src/kudu/util/nvm_cache.h
13 files changed, 448 insertions(+), 116 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/19764/21
--
To view, visit http://gerrit.cloudera.org:8080/19764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
Gerrit-Change-Number: 19764
Gerrit-PatchSet: 21
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [tablet] KUDU-3342 Add an implementation of the block cache on HBW
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19764
to look at the new patch set (#16).
Change subject: [tablet] KUDU-3342 Add an implementation of the block cache on HBW
......................................................................
[tablet] KUDU-3342 Add an implementation of the block cache on HBW
This commit adds support for a high bandwidth memory cache
based on hbwmalloc[1]. The cache is configured using
a new flag --block_cache_type=HBW.
For testing purposes, the new cache implementation wil be run on
DRAM by calling hbw_set_policy() with HBW_POLICY_PREFERRED though
there is not likely to be a performance advantage.
The code changes contained are:
* introduce the new flags to select the cache implementation
* introduce the new cache implementation, which uses hbwmalloc APIs to
allocate/free memory
* cfile-test and block_cache-test are made into value-parameterized tests
and test with all three cache types.
[1] http://memkind.github.io/memkind/man_pages/hbwmalloc.html
Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
---
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
M src/kudu/util/cache.h
A src/kudu/util/hbw_cache.cc
A src/kudu/util/hbw_cache.h
M src/kudu/util/memkind_cache.cc
M src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
M src/kudu/util/nvm_cache.h
12 files changed, 442 insertions(+), 110 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/19764/16
--
To view, visit http://gerrit.cloudera.org:8080/19764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
Gerrit-Change-Number: 19764
Gerrit-PatchSet: 16
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [hbw cache] KUDU-3342 Add an implementation of the block cache on HBW
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Yuqi Du, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19764
to look at the new patch set (#23).
Change subject: [hbw_cache] KUDU-3342 Add an implementation of the block cache on HBW
......................................................................
[hbw_cache] KUDU-3342 Add an implementation of the block cache on HBW
This commit adds support for a high bandwidth memory cache
based on hbwmalloc[1]. The cache is configured using
a new flag --block_cache_type=HBW.
For testing purposes, the new cache implementation will be run on
DRAM by calling hbw_set_policy() with HBW_POLICY_PREFERRED though
there is not likely to be a performance advantage.
The code changes contained are:
* introduce the new flags to select the cache implementation
* introduce the new cache implementation, which uses hbwmalloc APIs to
allocate/free memory
* cfile-test and block_cache-test are made into value-parameterized tests
and test with all three cache types.
[1] http://memkind.github.io/memkind/man_pages/hbwmalloc.html
Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
---
M docs/installation.adoc
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
M src/kudu/util/cache.h
A src/kudu/util/hbw_cache.cc
A src/kudu/util/hbw_cache.h
M src/kudu/util/memkind_cache.cc
M src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
M src/kudu/util/nvm_cache.h
13 files changed, 448 insertions(+), 116 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/19764/23
--
To view, visit http://gerrit.cloudera.org:8080/19764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
Gerrit-Change-Number: 19764
Gerrit-PatchSet: 23
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW Blocked by https://gerrit.cloudera.org/#/c/19726/
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19764
to look at the new patch set (#4).
Change subject: [BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW Blocked by https://gerrit.cloudera.org/#/c/19726/
......................................................................
[BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW
Blocked by https://gerrit.cloudera.org/#/c/19726/
This commit adds support for a high bandwidth memory cache
based on hbwmalloc[1]. The cache is configured using
a new flag --block_cache_type=HBW.
For testing purposes, the new cache implementation wil be run on
DRAM by calling hbw_set_policy() with HBW_POLICY_PREFERRED though
there is not likely to be a performance advantage.
The code changes contained are:
* introduce the new flags to select the cache implementation
* introduce the new cache implementation, which uses hbwmalloc APIs to
allocate/free memory
* cfile-test and block_cache-test are made into value-parameterized tests
and test with all three cache types.
[1] http://memkind.github.io/memkind/man_pages/hbwmalloc.html
Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
---
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
M src/kudu/util/cache.h
A src/kudu/util/hbw_cache.cc
A src/kudu/util/hbw_cache.h
A src/kudu/util/memkind_cache.cc
A src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
11 files changed, 1,053 insertions(+), 473 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/19764/4
--
To view, visit http://gerrit.cloudera.org:8080/19764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
Gerrit-Change-Number: 19764
Gerrit-PatchSet: 4
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [hbw cache] KUDU-3342 Add an implementation of the block cache on HBW
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Yuqi Du, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19764
to look at the new patch set (#18).
Change subject: [hbw_cache] KUDU-3342 Add an implementation of the block cache on HBW
......................................................................
[hbw_cache] KUDU-3342 Add an implementation of the block cache on HBW
This commit adds support for a high bandwidth memory cache
based on hbwmalloc[1]. The cache is configured using
a new flag --block_cache_type=HBW.
For testing purposes, the new cache implementation will be run on
DRAM by calling hbw_set_policy() with HBW_POLICY_PREFERRED though
there is not likely to be a performance advantage.
The code changes contained are:
* introduce the new flags to select the cache implementation
* introduce the new cache implementation, which uses hbwmalloc APIs to
allocate/free memory
* cfile-test and block_cache-test are made into value-parameterized tests
and test with all three cache types.
[1] http://memkind.github.io/memkind/man_pages/hbwmalloc.html
Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
---
M docs/installation.adoc
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
M src/kudu/util/cache.h
A src/kudu/util/hbw_cache.cc
A src/kudu/util/hbw_cache.h
M src/kudu/util/memkind_cache.cc
M src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
M src/kudu/util/nvm_cache.h
13 files changed, 448 insertions(+), 116 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/19764/18
--
To view, visit http://gerrit.cloudera.org:8080/19764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
Gerrit-Change-Number: 19764
Gerrit-PatchSet: 18
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [hbw cache] KUDU-3342 Add an implementation of the block cache on HBW
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Yuqi Du, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19764
to look at the new patch set (#22).
Change subject: [hbw_cache] KUDU-3342 Add an implementation of the block cache on HBW
......................................................................
[hbw_cache] KUDU-3342 Add an implementation of the block cache on HBW
This commit adds support for a high bandwidth memory cache
based on hbwmalloc[1]. The cache is configured using
a new flag --block_cache_type=HBW.
For testing purposes, the new cache implementation will be run on
DRAM by calling hbw_set_policy() with HBW_POLICY_PREFERRED though
there is not likely to be a performance advantage.
The code changes contained are:
* introduce the new flags to select the cache implementation
* introduce the new cache implementation, which uses hbwmalloc APIs to
allocate/free memory
* cfile-test and block_cache-test are made into value-parameterized tests
and test with all three cache types.
[1] http://memkind.github.io/memkind/man_pages/hbwmalloc.html
Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
---
M docs/installation.adoc
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
M src/kudu/util/cache.h
A src/kudu/util/hbw_cache.cc
A src/kudu/util/hbw_cache.h
M src/kudu/util/memkind_cache.cc
M src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
M src/kudu/util/nvm_cache.h
13 files changed, 448 insertions(+), 116 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/19764/22
--
To view, visit http://gerrit.cloudera.org:8080/19764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
Gerrit-Change-Number: 19764
Gerrit-PatchSet: 22
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19764
to look at the new patch set (#5).
Change subject: [BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW
......................................................................
[BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW
Blocked by https://gerrit.cloudera.org/#/c/19726/
This commit adds support for a high bandwidth memory cache
based on hbwmalloc[1]. The cache is configured using
a new flag --block_cache_type=HBW.
For testing purposes, the new cache implementation wil be run on
DRAM by calling hbw_set_policy() with HBW_POLICY_PREFERRED though
there is not likely to be a performance advantage.
The code changes contained are:
* introduce the new flags to select the cache implementation
* introduce the new cache implementation, which uses hbwmalloc APIs to
allocate/free memory
* cfile-test and block_cache-test are made into value-parameterized tests
and test with all three cache types.
[1] http://memkind.github.io/memkind/man_pages/hbwmalloc.html
Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
---
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
M src/kudu/util/cache.h
A src/kudu/util/hbw_cache.cc
A src/kudu/util/hbw_cache.h
A src/kudu/util/memkind_cache.cc
A src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
11 files changed, 1,053 insertions(+), 473 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/19764/5
--
To view, visit http://gerrit.cloudera.org:8080/19764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
Gerrit-Change-Number: 19764
Gerrit-PatchSet: 5
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19764
to look at the new patch set (#8).
Change subject: [BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW
......................................................................
[BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW
Blocked by https://gerrit.cloudera.org/#/c/19726/
This commit adds support for a high bandwidth memory cache
based on hbwmalloc[1]. The cache is configured using
a new flag --block_cache_type=HBW.
For testing purposes, the new cache implementation wil be run on
DRAM by calling hbw_set_policy() with HBW_POLICY_PREFERRED though
there is not likely to be a performance advantage.
The code changes contained are:
* introduce the new flags to select the cache implementation
* introduce the new cache implementation, which uses hbwmalloc APIs to
allocate/free memory
* cfile-test and block_cache-test are made into value-parameterized tests
and test with all three cache types.
[1] http://memkind.github.io/memkind/man_pages/hbwmalloc.html
Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
---
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
M src/kudu/util/cache.h
A src/kudu/util/hbw_cache.cc
A src/kudu/util/hbw_cache.h
M src/kudu/util/memkind_cache.cc
M src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
M src/kudu/util/nvm_cache.h
12 files changed, 441 insertions(+), 110 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/19764/8
--
To view, visit http://gerrit.cloudera.org:8080/19764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
Gerrit-Change-Number: 19764
Gerrit-PatchSet: 8
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [hbw cache] KUDU-3342 Add an implementation of the block cache on HBW
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Yuqi Du, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19764
to look at the new patch set (#24).
Change subject: [hbw_cache] KUDU-3342 Add an implementation of the block cache on HBW
......................................................................
[hbw_cache] KUDU-3342 Add an implementation of the block cache on HBW
This commit adds support for a high bandwidth memory cache
based on hbwmalloc[1]. The cache is configured using
a new flag --block_cache_type=HBW.
For testing purposes, the new cache implementation will be run on
DRAM by calling hbw_set_policy() with HBW_POLICY_PREFERRED though
there is not likely to be a performance advantage.
The code changes contained are:
* introduce the new flags to select the cache implementation
* introduce the new cache implementation, which uses hbwmalloc APIs to
allocate/free memory
* cfile-test and block_cache-test are made into value-parameterized tests
and test with all three cache types.
[1] http://memkind.github.io/memkind/man_pages/hbwmalloc.html
Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
---
M docs/installation.adoc
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
M src/kudu/util/cache.h
A src/kudu/util/hbw_cache.cc
A src/kudu/util/hbw_cache.h
M src/kudu/util/memkind_cache.cc
M src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
M src/kudu/util/nvm_cache.h
13 files changed, 448 insertions(+), 116 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/19764/24
--
To view, visit http://gerrit.cloudera.org:8080/19764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
Gerrit-Change-Number: 19764
Gerrit-PatchSet: 24
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19764
to look at the new patch set (#3).
Change subject: [BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW
......................................................................
[BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW
Blocked by https://gerrit.cloudera.org/#/c/19726/
This commit adds support for a high bandwidth memory cache
based on hbwmalloc[1]. The cache is configured using
a new flag --block_cache_type=HBW.
For testing purposes, the new cache implementation wil be run on
DRAM by calling hbw_set_policy() with HBW_POLICY_PREFERRED though
there is not likely to be a performance advantage.
The code changes contained are:
* introduce the new flags to select the cache implementation
* introduce the new cache implementation, which uses hbwmalloc APIs to
allocate/free memory
* cfile-test and block_cache-test are made into value-parameterized tests
and test with all three cache types.
[1] http://memkind.github.io/memkind/man_pages/hbwmalloc.html
Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
---
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
M src/kudu/util/cache.h
A src/kudu/util/hbw_cache.cc
A src/kudu/util/hbw_cache.h
A src/kudu/util/memkind_cache.cc
A src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
11 files changed, 1,053 insertions(+), 473 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/19764/3
--
To view, visit http://gerrit.cloudera.org:8080/19764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
Gerrit-Change-Number: 19764
Gerrit-PatchSet: 3
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tablet] KUDU-3342 Add an implementation of the block cache on HBW
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19764
to look at the new patch set (#14).
Change subject: [tablet] KUDU-3342 Add an implementation of the block cache on HBW
......................................................................
[tablet] KUDU-3342 Add an implementation of the block cache on HBW
This commit adds support for a high bandwidth memory cache
based on hbwmalloc[1]. The cache is configured using
a new flag --block_cache_type=HBW.
For testing purposes, the new cache implementation wil be run on
DRAM by calling hbw_set_policy() with HBW_POLICY_PREFERRED though
there is not likely to be a performance advantage.
The code changes contained are:
* introduce the new flags to select the cache implementation
* introduce the new cache implementation, which uses hbwmalloc APIs to
allocate/free memory
* cfile-test and block_cache-test are made into value-parameterized tests
and test with all three cache types.
[1] http://memkind.github.io/memkind/man_pages/hbwmalloc.html
Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
---
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
M src/kudu/util/cache.h
A src/kudu/util/hbw_cache.cc
A src/kudu/util/hbw_cache.h
M src/kudu/util/memkind_cache.cc
M src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
M src/kudu/util/nvm_cache.h
12 files changed, 442 insertions(+), 110 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/19764/14
--
To view, visit http://gerrit.cloudera.org:8080/19764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
Gerrit-Change-Number: 19764
Gerrit-PatchSet: 14
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19764
to look at the new patch set (#7).
Change subject: [BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW
......................................................................
[BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW
Blocked by https://gerrit.cloudera.org/#/c/19726/
This commit adds support for a high bandwidth memory cache
based on hbwmalloc[1]. The cache is configured using
a new flag --block_cache_type=HBW.
For testing purposes, the new cache implementation wil be run on
DRAM by calling hbw_set_policy() with HBW_POLICY_PREFERRED though
there is not likely to be a performance advantage.
The code changes contained are:
* introduce the new flags to select the cache implementation
* introduce the new cache implementation, which uses hbwmalloc APIs to
allocate/free memory
* cfile-test and block_cache-test are made into value-parameterized tests
and test with all three cache types.
[1] http://memkind.github.io/memkind/man_pages/hbwmalloc.html
Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
---
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
M src/kudu/util/cache.h
A src/kudu/util/hbw_cache.cc
A src/kudu/util/hbw_cache.h
M src/kudu/util/memkind_cache.cc
M src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
M src/kudu/util/nvm_cache.h
12 files changed, 438 insertions(+), 111 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/19764/7
--
To view, visit http://gerrit.cloudera.org:8080/19764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
Gerrit-Change-Number: 19764
Gerrit-PatchSet: 7
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19764
to look at the new patch set (#2).
Change subject: [BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW
......................................................................
[BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW
Blocked by https://gerrit.cloudera.org/#/c/19726/
This commit adds support for a high bandwidth memory cache
based on hbwmalloc[1]. The cache is configured using
a new flag --block_cache_type=HBW.
For testing purposes, the new cache implementation wil be run on
DRAM by calling hbw_set_policy() with HBW_POLICY_PREFERRED though
there is not likely to be a performance advantage.
The code changes contained are:
* introduce the new flags to select the cache implementation
* introduce the new cache implementation, which uses hbwmalloc APIs to
allocate/free memory
* cfile-test and block_cache-test are made into value-parameterized tests
and test with all three cache types.
[1] http://memkind.github.io/memkind/man_pages/hbwmalloc.html
Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
---
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
M src/kudu/util/cache.h
A src/kudu/util/hbw_cache.cc
A src/kudu/util/hbw_cache.h
A src/kudu/util/memkind_cache.cc
A src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
11 files changed, 1,009 insertions(+), 473 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/19764/2
--
To view, visit http://gerrit.cloudera.org:8080/19764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
Gerrit-Change-Number: 19764
Gerrit-PatchSet: 2
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tablet] KUDU-3342 Add an implementation of the block cache on HBW
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Yuqi Du, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19764
to look at the new patch set (#17).
Change subject: [tablet] KUDU-3342 Add an implementation of the block cache on HBW
......................................................................
[tablet] KUDU-3342 Add an implementation of the block cache on HBW
This commit adds support for a high bandwidth memory cache
based on hbwmalloc[1]. The cache is configured using
a new flag --block_cache_type=HBW.
For testing purposes, the new cache implementation will be run on
DRAM by calling hbw_set_policy() with HBW_POLICY_PREFERRED though
there is not likely to be a performance advantage.
The code changes contained are:
* introduce the new flags to select the cache implementation
* introduce the new cache implementation, which uses hbwmalloc APIs to
allocate/free memory
* cfile-test and block_cache-test are made into value-parameterized tests
and test with all three cache types.
[1] http://memkind.github.io/memkind/man_pages/hbwmalloc.html
Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
---
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
M src/kudu/util/cache.h
A src/kudu/util/hbw_cache.cc
A src/kudu/util/hbw_cache.h
M src/kudu/util/memkind_cache.cc
M src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
M src/kudu/util/nvm_cache.h
12 files changed, 442 insertions(+), 110 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/19764/17
--
To view, visit http://gerrit.cloudera.org:8080/19764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
Gerrit-Change-Number: 19764
Gerrit-PatchSet: 17
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19764
to look at the new patch set (#11).
Change subject: [BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW
......................................................................
[BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW
- blocked by https://gerrit.cloudera.org/#/c/19726/
This commit adds support for a high bandwidth memory cache
based on hbwmalloc[1]. The cache is configured using
a new flag --block_cache_type=HBW.
For testing purposes, the new cache implementation wil be run on
DRAM by calling hbw_set_policy() with HBW_POLICY_PREFERRED though
there is not likely to be a performance advantage.
The code changes contained are:
* introduce the new flags to select the cache implementation
* introduce the new cache implementation, which uses hbwmalloc APIs to
allocate/free memory
* cfile-test and block_cache-test are made into value-parameterized tests
and test with all three cache types.
[1] http://memkind.github.io/memkind/man_pages/hbwmalloc.html
Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
---
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
M src/kudu/util/cache.h
A src/kudu/util/hbw_cache.cc
A src/kudu/util/hbw_cache.h
M src/kudu/util/memkind_cache.cc
M src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
M src/kudu/util/nvm_cache.h
12 files changed, 441 insertions(+), 110 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/19764/11
--
To view, visit http://gerrit.cloudera.org:8080/19764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
Gerrit-Change-Number: 19764
Gerrit-PatchSet: 11
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [KUDU-3342] Add an implementation of the block cache on HBW
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19764
to look at the new patch set (#12).
Change subject: [KUDU-3342] Add an implementation of the block cache on HBW
......................................................................
[KUDU-3342] Add an implementation of the block cache on HBW
This commit adds support for a high bandwidth memory cache
based on hbwmalloc[1]. The cache is configured using
a new flag --block_cache_type=HBW.
For testing purposes, the new cache implementation wil be run on
DRAM by calling hbw_set_policy() with HBW_POLICY_PREFERRED though
there is not likely to be a performance advantage.
The code changes contained are:
* introduce the new flags to select the cache implementation
* introduce the new cache implementation, which uses hbwmalloc APIs to
allocate/free memory
* cfile-test and block_cache-test are made into value-parameterized tests
and test with all three cache types.
[1] http://memkind.github.io/memkind/man_pages/hbwmalloc.html
Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
---
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
M src/kudu/util/cache.h
A src/kudu/util/hbw_cache.cc
A src/kudu/util/hbw_cache.h
M src/kudu/util/memkind_cache.cc
M src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
M src/kudu/util/nvm_cache.h
12 files changed, 441 insertions(+), 110 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/19764/12
--
To view, visit http://gerrit.cloudera.org:8080/19764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
Gerrit-Change-Number: 19764
Gerrit-PatchSet: 12
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [hbw cache] KUDU-3342 Add an implementation of the block cache on HBW
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Yuqi Du, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19764
to look at the new patch set (#20).
Change subject: [hbw_cache] KUDU-3342 Add an implementation of the block cache on HBW
......................................................................
[hbw_cache] KUDU-3342 Add an implementation of the block cache on HBW
This commit adds support for a high bandwidth memory cache
based on hbwmalloc[1]. The cache is configured using
a new flag --block_cache_type=HBW.
For testing purposes, the new cache implementation will be run on
DRAM by calling hbw_set_policy() with HBW_POLICY_PREFERRED though
there is not likely to be a performance advantage.
The code changes contained are:
* introduce the new flags to select the cache implementation
* introduce the new cache implementation, which uses hbwmalloc APIs to
allocate/free memory
* cfile-test and block_cache-test are made into value-parameterized tests
and test with all three cache types.
[1] http://memkind.github.io/memkind/man_pages/hbwmalloc.html
Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
---
M docs/installation.adoc
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
M src/kudu/util/cache.h
A src/kudu/util/hbw_cache.cc
A src/kudu/util/hbw_cache.h
M src/kudu/util/memkind_cache.cc
M src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
M src/kudu/util/nvm_cache.h
13 files changed, 448 insertions(+), 116 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/19764/20
--
To view, visit http://gerrit.cloudera.org:8080/19764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
Gerrit-Change-Number: 19764
Gerrit-PatchSet: 20
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [hbw cache] KUDU-3342 Add an implementation of the block cache on HBW
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Yuqi Du, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19764
to look at the new patch set (#19).
Change subject: [hbw_cache] KUDU-3342 Add an implementation of the block cache on HBW
......................................................................
[hbw_cache] KUDU-3342 Add an implementation of the block cache on HBW
This commit adds support for a high bandwidth memory cache
based on hbwmalloc[1]. The cache is configured using
a new flag --block_cache_type=HBW.
For testing purposes, the new cache implementation will be run on
DRAM by calling hbw_set_policy() with HBW_POLICY_PREFERRED though
there is not likely to be a performance advantage.
The code changes contained are:
* introduce the new flags to select the cache implementation
* introduce the new cache implementation, which uses hbwmalloc APIs to
allocate/free memory
* cfile-test and block_cache-test are made into value-parameterized tests
and test with all three cache types.
[1] http://memkind.github.io/memkind/man_pages/hbwmalloc.html
Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
---
M docs/installation.adoc
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
M src/kudu/util/cache.h
A src/kudu/util/hbw_cache.cc
A src/kudu/util/hbw_cache.h
M src/kudu/util/memkind_cache.cc
M src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
M src/kudu/util/nvm_cache.h
13 files changed, 448 insertions(+), 116 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/19764/19
--
To view, visit http://gerrit.cloudera.org:8080/19764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
Gerrit-Change-Number: 19764
Gerrit-PatchSet: 19
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [tablet] KUDU-3342 Add an implementation of the block cache on HBW
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19764
to look at the new patch set (#13).
Change subject: [tablet] KUDU-3342 Add an implementation of the block cache on HBW
......................................................................
[tablet] KUDU-3342 Add an implementation of the block cache on HBW
This commit adds support for a high bandwidth memory cache
based on hbwmalloc[1]. The cache is configured using
a new flag --block_cache_type=HBW.
For testing purposes, the new cache implementation wil be run on
DRAM by calling hbw_set_policy() with HBW_POLICY_PREFERRED though
there is not likely to be a performance advantage.
The code changes contained are:
* introduce the new flags to select the cache implementation
* introduce the new cache implementation, which uses hbwmalloc APIs to
allocate/free memory
* cfile-test and block_cache-test are made into value-parameterized tests
and test with all three cache types.
[1] http://memkind.github.io/memkind/man_pages/hbwmalloc.html
Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
---
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
M src/kudu/util/cache.h
A src/kudu/util/hbw_cache.cc
A src/kudu/util/hbw_cache.h
M src/kudu/util/memkind_cache.cc
M src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
M src/kudu/util/nvm_cache.h
12 files changed, 441 insertions(+), 110 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/19764/13
--
To view, visit http://gerrit.cloudera.org:8080/19764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
Gerrit-Change-Number: 19764
Gerrit-PatchSet: 13
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19764
to look at the new patch set (#6).
Change subject: [BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW
......................................................................
[BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW
Blocked by https://gerrit.cloudera.org/#/c/19726/
This commit adds support for a high bandwidth memory cache
based on hbwmalloc[1]. The cache is configured using
a new flag --block_cache_type=HBW.
For testing purposes, the new cache implementation wil be run on
DRAM by calling hbw_set_policy() with HBW_POLICY_PREFERRED though
there is not likely to be a performance advantage.
The code changes contained are:
* introduce the new flags to select the cache implementation
* introduce the new cache implementation, which uses hbwmalloc APIs to
allocate/free memory
* cfile-test and block_cache-test are made into value-parameterized tests
and test with all three cache types.
[1] http://memkind.github.io/memkind/man_pages/hbwmalloc.html
Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
---
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
M src/kudu/util/cache.h
A src/kudu/util/hbw_cache.cc
A src/kudu/util/hbw_cache.h
8 files changed, 477 insertions(+), 44 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/19764/6
--
To view, visit http://gerrit.cloudera.org:8080/19764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
Gerrit-Change-Number: 19764
Gerrit-PatchSet: 6
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tablet] KUDU-3342 Add an implementation of the block cache on HBW
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Sammy Nah has posted comments on this change. ( http://gerrit.cloudera.org:8080/19764 )
Change subject: [tablet] KUDU-3342 Add an implementation of the block cache on HBW
......................................................................
Patch Set 16:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/19764/16//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19764/16//COMMIT_MSG@13
PS16, Line 13: wil
> nit: will
Done
http://gerrit.cloudera.org:8080/#/c/19764/16/src/kudu/cfile/block_cache.cc
File src/kudu/cfile/block_cache.cc:
http://gerrit.cloudera.org:8080/#/c/19764/16/src/kudu/cfile/block_cache.cc@58
PS16, Line 58: To use 'NVM' or 'HBW', libmemkind 1.8.0 or newer
> It seems this library is not a system library, so it may be not present at
libmemkind is a optional requirement for kudu installation per the official document. https://kudu.apache.org/docs/installation.html#rhel_from_source (step 3). This library has been integrated in 946e2bc.
http://gerrit.cloudera.org:8080/#/c/19764/16/src/kudu/util/hbw_cache.cc
File src/kudu/util/hbw_cache.cc:
http://gerrit.cloudera.org:8080/#/c/19764/16/src/kudu/util/hbw_cache.cc@13
PS16, Line 13: wtih
> nit: with
Done
--
To view, visit http://gerrit.cloudera.org:8080/19764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
Gerrit-Change-Number: 19764
Gerrit-PatchSet: 16
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 25 Apr 2023 15:18:31 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tablet] KUDU-3342 Add an implementation of the block cache on HBW
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/19764 )
Change subject: [tablet] KUDU-3342 Add an implementation of the block cache on HBW
......................................................................
Patch Set 16:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/19764/16//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19764/16//COMMIT_MSG@13
PS16, Line 13: wil
nit: will
http://gerrit.cloudera.org:8080/#/c/19764/16/src/kudu/cfile/block_cache.cc
File src/kudu/cfile/block_cache.cc:
http://gerrit.cloudera.org:8080/#/c/19764/16/src/kudu/cfile/block_cache.cc@58
PS16, Line 58: To use 'NVM' or 'HBW', libmemkind 1.8.0 or newer
It seems this library is not a system library, so it may be not present at some compiler environments.
If it is necessary to add a dependency(download and build it) for this library?
Jenkins has passed, is jenkins machines have installed this library?
http://gerrit.cloudera.org:8080/#/c/19764/16/src/kudu/util/hbw_cache.cc
File src/kudu/util/hbw_cache.cc:
http://gerrit.cloudera.org:8080/#/c/19764/16/src/kudu/util/hbw_cache.cc@13
PS16, Line 13: wtih
nit: with
--
To view, visit http://gerrit.cloudera.org:8080/19764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
Gerrit-Change-Number: 19764
Gerrit-PatchSet: 16
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 25 Apr 2023 07:04:52 +0000
Gerrit-HasComments: Yes
[kudu-CR] [BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19764
to look at the new patch set (#9).
Change subject: [BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW
......................................................................
[BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW
- Blocked by https://gerrit.cloudera.org/#/c/19726/
This commit adds support for a high bandwidth memory cache
based on hbwmalloc[1]. The cache is configured using
a new flag --block_cache_type=HBW.
For testing purposes, the new cache implementation wil be run on
DRAM by calling hbw_set_policy() with HBW_POLICY_PREFERRED though
there is not likely to be a performance advantage.
The code changes contained are:
* introduce the new flags to select the cache implementation
* introduce the new cache implementation, which uses hbwmalloc APIs to
allocate/free memory
* cfile-test and block_cache-test are made into value-parameterized tests
and test with all three cache types.
[1] http://memkind.github.io/memkind/man_pages/hbwmalloc.html
Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
---
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
M src/kudu/util/cache.h
A src/kudu/util/hbw_cache.cc
A src/kudu/util/hbw_cache.h
M src/kudu/util/memkind_cache.cc
M src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
M src/kudu/util/nvm_cache.h
12 files changed, 441 insertions(+), 110 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/19764/9
--
To view, visit http://gerrit.cloudera.org:8080/19764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
Gerrit-Change-Number: 19764
Gerrit-PatchSet: 9
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW
Posted by "Sammy Nah (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19764
to look at the new patch set (#10).
Change subject: [BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW
......................................................................
[BLOCKED][KUDU-3342] Add an implementation of the block cache on HBW
blocked by https://gerrit.cloudera.org/#/c/19726/
This commit adds support for a high bandwidth memory cache
based on hbwmalloc[1]. The cache is configured using
a new flag --block_cache_type=HBW.
For testing purposes, the new cache implementation wil be run on
DRAM by calling hbw_set_policy() with HBW_POLICY_PREFERRED though
there is not likely to be a performance advantage.
The code changes contained are:
* introduce the new flags to select the cache implementation
* introduce the new cache implementation, which uses hbwmalloc APIs to
allocate/free memory
* cfile-test and block_cache-test are made into value-parameterized tests
and test with all three cache types.
[1] http://memkind.github.io/memkind/man_pages/hbwmalloc.html
Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
---
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
M src/kudu/util/cache.h
A src/kudu/util/hbw_cache.cc
A src/kudu/util/hbw_cache.h
M src/kudu/util/memkind_cache.cc
M src/kudu/util/memkind_cache.h
M src/kudu/util/nvm_cache.cc
M src/kudu/util/nvm_cache.h
12 files changed, 441 insertions(+), 110 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/19764/10
--
To view, visit http://gerrit.cloudera.org:8080/19764
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I854fff10ad124445f4a5f96c389057c59dac8164
Gerrit-Change-Number: 19764
Gerrit-PatchSet: 10
Gerrit-Owner: Sammy Nah <sa...@intel.com>
Gerrit-Reviewer: Kudu Jenkins (120)