You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/31 11:54:05 UTC

[GitHub] [arrow] lidavidm commented on a diff in pull request #13206: ARROW-15906: [C++][Python][R] By default, don't create or delete S3 buckets

lidavidm commented on code in PR #13206:
URL: https://github.com/apache/arrow/pull/13206#discussion_r885543144


##########
cpp/src/arrow/filesystem/s3fs.h:
##########
@@ -130,6 +130,9 @@ struct ARROW_EXPORT S3Options {
   /// Whether OutputStream writes will be issued in the background, without blocking.
   bool background_writes = true;
 
+  /// Whether to allow creation of new buckets
+  bool allow_create_buckets = false;

Review Comment:
   Perhaps `create_buckets` and `delete_buckets`? That reads more consistently with `background_writes` to me. Or `allow_creating_buckets`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org