You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2023/03/29 19:29:28 UTC
[GitHub] [arrow-nanoarrow] paleolimbot opened a new pull request, #176: chore(extensions/nanoarrow_ipc): Test files from the arrow-testing repo
paleolimbot opened a new pull request, #176:
URL: https://github.com/apache/arrow-nanoarrow/pull/176
TODO:
- CI
- Fuzz-tested files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] lidavidm commented on a diff in pull request #176: chore(extensions/nanoarrow_ipc): Test files from the arrow-testing repo
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #176:
URL: https://github.com/apache/arrow-nanoarrow/pull/176#discussion_r1153519992
##########
src/nanoarrow/array.c:
##########
@@ -910,10 +910,6 @@ ArrowErrorCode ArrowArrayViewValidateFull(struct ArrowArrayView* array_view,
struct ArrowError* error) {
for (int i = 0; i < 3; i++) {
switch (array_view->layout.buffer_type[i]) {
- case NANOARROW_BUFFER_TYPE_UNION_OFFSET:
Review Comment:
Hmm, dense union offsets don't have to be increasing?
##########
src/nanoarrow/array.c:
##########
@@ -910,10 +910,6 @@ ArrowErrorCode ArrowArrayViewValidateFull(struct ArrowArrayView* array_view,
struct ArrowError* error) {
for (int i = 0; i < 3; i++) {
switch (array_view->layout.buffer_type[i]) {
- case NANOARROW_BUFFER_TYPE_UNION_OFFSET:
Review Comment:
Ah, "The respective offsets for each child value array must be in order / increasing." So if we want to validate this it'll be trickier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] paleolimbot commented on a diff in pull request #176: chore(extensions/nanoarrow_ipc): Test files from the arrow-testing repo
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on code in PR #176:
URL: https://github.com/apache/arrow-nanoarrow/pull/176#discussion_r1153541487
##########
src/nanoarrow/array.c:
##########
@@ -910,10 +910,6 @@ ArrowErrorCode ArrowArrayViewValidateFull(struct ArrowArrayView* array_view,
struct ArrowError* error) {
for (int i = 0; i < 3; i++) {
switch (array_view->layout.buffer_type[i]) {
- case NANOARROW_BUFFER_TYPE_UNION_OFFSET:
Review Comment:
Yes, having this included resulted in an incorrect validation failure for the integration test file. I added this to the TODO list for #178.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] paleolimbot merged pull request #176: chore(extensions/nanoarrow_ipc): Test files from the arrow-testing repo
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #176:
URL: https://github.com/apache/arrow-nanoarrow/pull/176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] codecov-commenter commented on pull request #176: chore(extensions/nanoarrow_ipc): Test files from the arrow-testing repo
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #176:
URL: https://github.com/apache/arrow-nanoarrow/pull/176#issuecomment-1490419233
## [Codecov](https://codecov.io/gh/apache/arrow-nanoarrow/pull/176?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#176](https://codecov.io/gh/apache/arrow-nanoarrow/pull/176?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a98400c) into [main](https://codecov.io/gh/apache/arrow-nanoarrow/commit/20e5bae8db24737857e725801d6a965ed21a4f7a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (20e5bae) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a98400c differs from pull request most recent head 8b5035d. Consider uploading reports for the commit 8b5035d to get more accurate results
```diff
@@ Coverage Diff @@
## main #176 +/- ##
==========================================
- Coverage 93.43% 93.42% -0.01%
==========================================
Files 7 7
Lines 1767 1765 -2
Branches 57 57
==========================================
- Hits 1651 1649 -2
Misses 84 84
Partials 32 32
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-nanoarrow/pull/176?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [src/nanoarrow/array.c](https://codecov.io/gh/apache/arrow-nanoarrow/pull/176?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL25hbm9hcnJvdy9hcnJheS5j) | `93.29% <ø> (-0.03%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org