[GitHub] [spark] MaxGekk commented on a diff in pull request #36553: [SPARK-39214][SQL] Improve errors related to CAST

[GitBox <gi...@apache.org>]

MaxGekk commented on code in PR #36553:
URL: https://github.com/apache/spark/pull/36553#discussion_r875133200


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -22,8 +22,12 @@
   "CANNOT_UP_CAST_DATATYPE" : {
     "message" : [ "Cannot up cast <value> from <sourceType> to <targetType>.\n<details>" ]
   },
-  "CAST_CAUSES_OVERFLOW" : {
-    "message" : [ "Casting <value> to <type> causes overflow. To return NULL instead, use 'try_cast'. If necessary set <config> to false to bypass this error." ],
+  "CAST_INVALID_INPUT" : {
+    "message" : [ "The value <value> of the type <sourceType> cannot be cast to <targetType> because it is malformed. To return NULL instead, use `try_cast`. If necessary set <config> to false to bypass this error.<details>" ],
+    "sqlState" : "42000"
+  },
+  "CAST_OVERFLOW" : {
+    "message" : [ "The value <value> of the type <sourceType> cannot be cast to <targetType> due to an overflow. To return NULL instead, use `try_cast`. If necessary set <config> to false to bypass this error." ],

Review Comment:
   It would be nice to provide the error context in the error. Opened the JIRA https://issues.apache.org/jira/browse/SPARK-39188



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org