You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/01/27 15:55:30 UTC
[GitHub] [shardingsphere] ThanoshanMV commented on a change in pull request #9178: Add SQL definition for `COMMIT` of Oracle database
ThanoshanMV commented on a change in pull request #9178:
URL: https://github.com/apache/shardingsphere/pull/9178#discussion_r565424561
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/TCLStatement.g4
##########
@@ -24,15 +24,27 @@ setTransaction
;
commit
- : COMMIT
+ : COMMIT WORK? (commentClause? | writeClause? | forceClause)?
Review comment:
Hi @wgy8283335,
Since there is a vertical bar between `commentClause` and `writeClause`, I specified it as `|`.
Please let me know what are the changed I need to make.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org