You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/09/14 02:24:43 UTC
[GitHub] [doris] morningman opened a new pull request, #12578: [fix](load) add scan tuple for stream load scan node only when vectorization is enable
morningman opened a new pull request, #12578:
URL: https://github.com/apache/doris/pull/12578
# Proposed changes
Issue Number: close #xxx
## Problem summary
Introduced from #12302
Inspired by this PR #12509
The scan tuple is only needed when vectorization is enabled.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Gabriel39 commented on a diff in pull request #12578: [fix](load) add scan tuple for stream load scan node only when vectorization is enable
Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on code in PR #12578:
URL: https://github.com/apache/doris/pull/12578#discussion_r970254304
##########
fe/fe-core/src/main/java/org/apache/doris/planner/StreamLoadPlanner.java:
##########
@@ -138,20 +141,22 @@ public TExecPlanFragmentParams plan(TUniqueId loadId) throws UserException {
slotDesc.setColumn(col);
slotDesc.setIsNullable(col.isAllowNull());
- SlotDescriptor scanSlotDesc = descTable.addSlotDescriptor(scanTupleDesc);
- scanSlotDesc.setIsMaterialized(true);
- scanSlotDesc.setColumn(col);
- scanSlotDesc.setIsNullable(col.isAllowNull());
- for (ImportColumnDesc importColumnDesc : taskInfo.getColumnExprDescs().descs) {
- try {
- if (!importColumnDesc.isColumn() && importColumnDesc.getColumnName() != null
- && importColumnDesc.getColumnName().equals(col.getName())) {
- scanSlotDesc.setIsNullable(importColumnDesc.getExpr().isNullable());
- break;
+ if (Config.enable_vectorized_load) {
Review Comment:
Use `VectorizedUtil.isVectorized()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #12578: [fix](load) add scan tuple for stream load scan node only when vectorization is enable
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #12578:
URL: https://github.com/apache/doris/pull/12578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #12578: [fix](load) add scan tuple for stream load scan node only when vectorization is enable
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12578:
URL: https://github.com/apache/doris/pull/12578#issuecomment-1246799621
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #12578: [fix](load) add scan tuple for stream load scan node only when vectorization is enable
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #12578:
URL: https://github.com/apache/doris/pull/12578#discussion_r970811724
##########
fe/fe-core/src/main/java/org/apache/doris/planner/StreamLoadPlanner.java:
##########
@@ -138,20 +141,22 @@ public TExecPlanFragmentParams plan(TUniqueId loadId) throws UserException {
slotDesc.setColumn(col);
slotDesc.setIsNullable(col.isAllowNull());
- SlotDescriptor scanSlotDesc = descTable.addSlotDescriptor(scanTupleDesc);
- scanSlotDesc.setIsMaterialized(true);
- scanSlotDesc.setColumn(col);
- scanSlotDesc.setIsNullable(col.isAllowNull());
- for (ImportColumnDesc importColumnDesc : taskInfo.getColumnExprDescs().descs) {
- try {
- if (!importColumnDesc.isColumn() && importColumnDesc.getColumnName() != null
- && importColumnDesc.getColumnName().equals(col.getName())) {
- scanSlotDesc.setIsNullable(importColumnDesc.getExpr().isNullable());
- break;
+ if (Config.enable_vectorized_load) {
Review Comment:
`VectorizedUtil.isVectorized()` is only for query
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #12578: [fix](load) add scan tuple for stream load scan node only when vectorization is enable
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12578:
URL: https://github.com/apache/doris/pull/12578#issuecomment-1246799580
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org