You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@crunch.apache.org by "Matthias Friedrich (JIRA)" <ji...@apache.org> on 2012/11/17 10:39:11 UTC
[jira] [Created] (CRUNCH-115) The binary distribution must include
licenses of dependencies
Matthias Friedrich created CRUNCH-115:
-----------------------------------------
Summary: The binary distribution must include licenses of dependencies
Key: CRUNCH-115
URL: https://issues.apache.org/jira/browse/CRUNCH-115
Project: Crunch
Issue Type: Bug
Affects Versions: 0.4.0
Reporter: Matthias Friedrich
Assignee: Matthias Friedrich
Our binary distribution contains libraries distributed under various licenses. We have to include these licenses in our LICENSE and NOTICE files, where necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CRUNCH-115) The binary distribution must
include licenses of dependencies
Posted by "Josh Wills (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503546#comment-13503546 ]
Josh Wills commented on CRUNCH-115:
-----------------------------------
+1 to removing the version numbers-- are we leaving this open for some other reason?
> The binary distribution must include licenses of dependencies
> -------------------------------------------------------------
>
> Key: CRUNCH-115
> URL: https://issues.apache.org/jira/browse/CRUNCH-115
> Project: Crunch
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Fix For: 0.5.0
>
> Attachments: CRUNCH-115-Fix-licensing-issues.patch, CRUNCH-115-Fix-licensing-issues-v2.patch, CRUNCH-115-Fix-licensing-issues-v3.patch, CRUNCH-115-remove-version-numbers.patch
>
>
> Our binary distribution contains libraries distributed under various licenses. We have to include these licenses in our LICENSE and NOTICE files, where necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (CRUNCH-115) The binary distribution must include
licenses of dependencies
Posted by "Matthias Friedrich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Friedrich reopened CRUNCH-115:
---------------------------------------
Good point, I'll make a patch to remove the version numbers. Regarding junit and friends: They are compile time dependencies of crunch-test, not just test scope dependencies, so I'm afraid we have to ship them.
> The binary distribution must include licenses of dependencies
> -------------------------------------------------------------
>
> Key: CRUNCH-115
> URL: https://issues.apache.org/jira/browse/CRUNCH-115
> Project: Crunch
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Fix For: 0.5.0
>
> Attachments: CRUNCH-115-Fix-licensing-issues.patch, CRUNCH-115-Fix-licensing-issues-v2.patch, CRUNCH-115-Fix-licensing-issues-v3.patch
>
>
> Our binary distribution contains libraries distributed under various licenses. We have to include these licenses in our LICENSE and NOTICE files, where necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CRUNCH-115) The binary distribution must include
licenses of dependencies
Posted by "Matthias Friedrich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Friedrich resolved CRUNCH-115.
---------------------------------------
Resolution: Fixed
Fix Version/s: 0.5.0
Thanks, I have committed the current version. Everyone is still invited to review this, please reopen this issue if you find any problems.
> The binary distribution must include licenses of dependencies
> -------------------------------------------------------------
>
> Key: CRUNCH-115
> URL: https://issues.apache.org/jira/browse/CRUNCH-115
> Project: Crunch
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Fix For: 0.5.0
>
> Attachments: CRUNCH-115-Fix-licensing-issues.patch, CRUNCH-115-Fix-licensing-issues-v2.patch, CRUNCH-115-Fix-licensing-issues-v3.patch
>
>
> Our binary distribution contains libraries distributed under various licenses. We have to include these licenses in our LICENSE and NOTICE files, where necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CRUNCH-115) The binary distribution must
include licenses of dependencies
Posted by "Josh Wills (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499602#comment-13499602 ]
Josh Wills commented on CRUNCH-115:
-----------------------------------
+1, both to the patch and to the virtues of few dependencies.
> The binary distribution must include licenses of dependencies
> -------------------------------------------------------------
>
> Key: CRUNCH-115
> URL: https://issues.apache.org/jira/browse/CRUNCH-115
> Project: Crunch
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Attachments: CRUNCH-115-Fix-licensing-issues.patch, CRUNCH-115-Fix-licensing-issues-v2.patch, CRUNCH-115-Fix-licensing-issues-v3.patch
>
>
> Our binary distribution contains libraries distributed under various licenses. We have to include these licenses in our LICENSE and NOTICE files, where necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CRUNCH-115) The binary distribution must include
licenses of dependencies
Posted by "Matthias Friedrich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Friedrich updated CRUNCH-115:
--------------------------------------
Attachment: CRUNCH-115-Fix-licensing-issues.patch
First attempt, added licenses to our LICENSE file. I haven't touched NOTICE yet, I need some help with that. I think we need to add statements as per section 4(d) of the Apache License; we have that for ASF projects, but not for others. Correct?
Unfortunately, the source repos at Google Code are down, so I can't get at all license files. I'll make a second pass when it's up again.
> The binary distribution must include licenses of dependencies
> -------------------------------------------------------------
>
> Key: CRUNCH-115
> URL: https://issues.apache.org/jira/browse/CRUNCH-115
> Project: Crunch
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Attachments: CRUNCH-115-Fix-licensing-issues.patch
>
>
> Our binary distribution contains libraries distributed under various licenses. We have to include these licenses in our LICENSE and NOTICE files, where necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CRUNCH-115) The binary distribution must
include licenses of dependencies
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500400#comment-13500400 ]
Tom White commented on CRUNCH-115:
----------------------------------
That makes sense about JUnit and Mockito. I had a quick look at crunch-test and it didn't look very Crunch-specific - is it something that could live in MRUnit instead? No you've got the binary dependencies worked out it may not matter much, but I thought I'd mention it anyway.
> The binary distribution must include licenses of dependencies
> -------------------------------------------------------------
>
> Key: CRUNCH-115
> URL: https://issues.apache.org/jira/browse/CRUNCH-115
> Project: Crunch
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Fix For: 0.5.0
>
> Attachments: CRUNCH-115-Fix-licensing-issues.patch, CRUNCH-115-Fix-licensing-issues-v2.patch, CRUNCH-115-Fix-licensing-issues-v3.patch
>
>
> Our binary distribution contains libraries distributed under various licenses. We have to include these licenses in our LICENSE and NOTICE files, where necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CRUNCH-115) The binary distribution must
include licenses of dependencies
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500208#comment-13500208 ]
Tom White commented on CRUNCH-115:
----------------------------------
This change looks good to me. I had a couple of follow on comments:
* Listing the version numbers of libraries in the LICENSE file is not necessary and will make future library updates more error prone (since there will be two places to change the version numbers).
* Projects don't usually ship test artifacts, so why are JUnit and Mockito in the binary distibution at all? Is this an oversight or are they needed by the main code?
> The binary distribution must include licenses of dependencies
> -------------------------------------------------------------
>
> Key: CRUNCH-115
> URL: https://issues.apache.org/jira/browse/CRUNCH-115
> Project: Crunch
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Fix For: 0.5.0
>
> Attachments: CRUNCH-115-Fix-licensing-issues.patch, CRUNCH-115-Fix-licensing-issues-v2.patch, CRUNCH-115-Fix-licensing-issues-v3.patch
>
>
> Our binary distribution contains libraries distributed under various licenses. We have to include these licenses in our LICENSE and NOTICE files, where necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CRUNCH-115) The binary distribution must include
licenses of dependencies
Posted by "Matthias Friedrich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Friedrich updated CRUNCH-115:
--------------------------------------
Attachment: CRUNCH-115-Fix-licensing-issues-v3.patch
Gah. Checked the JARs: snappy-java and mockito-all bundle other software. I've added their licenses, too. Mockito comes with a NOTICE file, BTW, but since it's MIT licensed, it has no effect on us.
This whole episode is another excellent reason to keep your set of dependencies small.
> The binary distribution must include licenses of dependencies
> -------------------------------------------------------------
>
> Key: CRUNCH-115
> URL: https://issues.apache.org/jira/browse/CRUNCH-115
> Project: Crunch
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Attachments: CRUNCH-115-Fix-licensing-issues.patch, CRUNCH-115-Fix-licensing-issues-v2.patch, CRUNCH-115-Fix-licensing-issues-v3.patch
>
>
> Our binary distribution contains libraries distributed under various licenses. We have to include these licenses in our LICENSE and NOTICE files, where necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CRUNCH-115) The binary distribution must
include licenses of dependencies
Posted by "Josh Wills (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502187#comment-13502187 ]
Josh Wills commented on CRUNCH-115:
-----------------------------------
We have the benefit of having [~brocknoland], the VP of MRUnit, on our PMC. He can weigh in on their interest level.
> The binary distribution must include licenses of dependencies
> -------------------------------------------------------------
>
> Key: CRUNCH-115
> URL: https://issues.apache.org/jira/browse/CRUNCH-115
> Project: Crunch
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Fix For: 0.5.0
>
> Attachments: CRUNCH-115-Fix-licensing-issues.patch, CRUNCH-115-Fix-licensing-issues-v2.patch, CRUNCH-115-Fix-licensing-issues-v3.patch, CRUNCH-115-remove-version-numbers.patch
>
>
> Our binary distribution contains libraries distributed under various licenses. We have to include these licenses in our LICENSE and NOTICE files, where necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CRUNCH-115) The binary distribution must include
licenses of dependencies
Posted by "Matthias Friedrich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Friedrich updated CRUNCH-115:
--------------------------------------
Attachment: CRUNCH-115-remove-version-numbers.patch
Here's a patch that removes the version numbers.
Good idea about mrunit; I'm just not sure if they are interested. I'll put this on my TODO list, I like getting rid of code :)
> The binary distribution must include licenses of dependencies
> -------------------------------------------------------------
>
> Key: CRUNCH-115
> URL: https://issues.apache.org/jira/browse/CRUNCH-115
> Project: Crunch
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Fix For: 0.5.0
>
> Attachments: CRUNCH-115-Fix-licensing-issues.patch, CRUNCH-115-Fix-licensing-issues-v2.patch, CRUNCH-115-Fix-licensing-issues-v3.patch, CRUNCH-115-remove-version-numbers.patch
>
>
> Our binary distribution contains libraries distributed under various licenses. We have to include these licenses in our LICENSE and NOTICE files, where necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CRUNCH-115) The binary distribution must include
licenses of dependencies
Posted by "Matthias Friedrich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Friedrich resolved CRUNCH-115.
---------------------------------------
Resolution: Fixed
Nope, I left it open because of the version numbers patch. It's committed now, thanks!
> The binary distribution must include licenses of dependencies
> -------------------------------------------------------------
>
> Key: CRUNCH-115
> URL: https://issues.apache.org/jira/browse/CRUNCH-115
> Project: Crunch
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Fix For: 0.5.0
>
> Attachments: CRUNCH-115-Fix-licensing-issues.patch, CRUNCH-115-Fix-licensing-issues-v2.patch, CRUNCH-115-Fix-licensing-issues-v3.patch, CRUNCH-115-remove-version-numbers.patch
>
>
> Our binary distribution contains libraries distributed under various licenses. We have to include these licenses in our LICENSE and NOTICE files, where necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CRUNCH-115) The binary distribution must
include licenses of dependencies
Posted by "Brock Noland (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502284#comment-13502284 ]
Brock Noland commented on CRUNCH-115:
-------------------------------------
MRUnit is doing some similar things and they do seem generic enough to be useful to others. I have created MRUNIT-162 to discuss with the MRUnit community.
> The binary distribution must include licenses of dependencies
> -------------------------------------------------------------
>
> Key: CRUNCH-115
> URL: https://issues.apache.org/jira/browse/CRUNCH-115
> Project: Crunch
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Fix For: 0.5.0
>
> Attachments: CRUNCH-115-Fix-licensing-issues.patch, CRUNCH-115-Fix-licensing-issues-v2.patch, CRUNCH-115-Fix-licensing-issues-v3.patch, CRUNCH-115-remove-version-numbers.patch
>
>
> Our binary distribution contains libraries distributed under various licenses. We have to include these licenses in our LICENSE and NOTICE files, where necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CRUNCH-115) The binary distribution must
include licenses of dependencies
Posted by "Josh Wills (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499444#comment-13499444 ]
Josh Wills commented on CRUNCH-115:
-----------------------------------
That is my understanding; the BSD and MIT licenses do not require entries in the NOTICE file.
> The binary distribution must include licenses of dependencies
> -------------------------------------------------------------
>
> Key: CRUNCH-115
> URL: https://issues.apache.org/jira/browse/CRUNCH-115
> Project: Crunch
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Attachments: CRUNCH-115-Fix-licensing-issues.patch
>
>
> Our binary distribution contains libraries distributed under various licenses. We have to include these licenses in our LICENSE and NOTICE files, where necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CRUNCH-115) The binary distribution must include
licenses of dependencies
Posted by "Matthias Friedrich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CRUNCH-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Friedrich updated CRUNCH-115:
--------------------------------------
Attachment: CRUNCH-115-Fix-licensing-issues-v2.patch
Google Code is back up, second version. Except for snappy-java, none of the non-ASF Apache-licensed projects contains a NOTICE file, so I think we're safe regarding statement 4(d). I'm not sure what to add for snappy-java because they're using the NOTICE file wrong (I think); I gave it my best shot.
BSD and MIT don't require NOTICE entries, but JUnit's Common Public License requires a link in 3(iv). I've also added a notice for javassist, which is triple-licensed.
This is it, to the best of my knowledge. Now we need reviewers.
> The binary distribution must include licenses of dependencies
> -------------------------------------------------------------
>
> Key: CRUNCH-115
> URL: https://issues.apache.org/jira/browse/CRUNCH-115
> Project: Crunch
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Attachments: CRUNCH-115-Fix-licensing-issues.patch, CRUNCH-115-Fix-licensing-issues-v2.patch
>
>
> Our binary distribution contains libraries distributed under various licenses. We have to include these licenses in our LICENSE and NOTICE files, where necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira