You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2016/03/16 00:59:35 UTC
Review Request 44871: Speed up Vagrant provisioning by using a custom
base box.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44871/
-----------------------------------------------------------
Review request for Aurora, John Sirois and Zameer Manji.
Repository: aurora
Description
-------
Relevant docs on packer can be found here: https://www.packer.io/docs/
To support this, i have created the [`apache-aurora` org](https://atlas.hashicorp.com/apache-aurora). If we move forward with this patch, i will be looking to add other committers to the org and improve the bus factor.
Diffs
-----
.gitignore 1af09a251b3f76c13813033d32aa7efba9aef304
Vagrantfile 2d6c2ae598e80035840f7e517e161be266b581dd
build-support/packer/README.md PRE-CREATION
build-support/packer/aurora.json PRE-CREATION
build-support/packer/build.sh PRE-CREATION
examples/vagrant/provision-dev-cluster.sh df33a30c1dcc0ea832899c849be05fe9deb47433
Diff: https://reviews.apache.org/r/44871/diff/
Testing
-------
I can run `vagrant up`. Currently looking into a possible configuration issue in end-to-end tests, to be corrected before submitting.
Reviewers - you can do this as well by applying the patch. You will observe a long fetch on the first run (much like you would with the current repo if you wiped your local vagrant boxes). However, subsequent `vagrant destroy`, `vagrant up` cycles should be relatively fast, about 1m30s for me.
Thanks,
Bill Farner
Re: Review Request 44871: Speed up Vagrant provisioning by using a
custom base box.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44871/#review123985
-----------------------------------------------------------
Ship it!
Master (6537581) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 17, 2016, 5:44 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44871/
> -----------------------------------------------------------
>
> (Updated March 17, 2016, 5:44 a.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Relevant docs on packer can be found here: https://www.packer.io/docs/
>
> To support this, i have created the [`apache-aurora` org](https://atlas.hashicorp.com/apache-aurora). If we move forward with this patch, i will be looking to add other committers to the org and improve the bus factor.
>
>
> Diffs
> -----
>
> .gitignore 1af09a251b3f76c13813033d32aa7efba9aef304
> Vagrantfile 2d6c2ae598e80035840f7e517e161be266b581dd
> build-support/packer/README.md PRE-CREATION
> build-support/packer/aurora.json PRE-CREATION
> build-support/packer/build.sh PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-master/ip PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-master/roles PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/containerizers PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/hostname PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/ip PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/modules PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/resource_estimator PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/resources PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/work_dir PRE-CREATION
> examples/vagrant/provision-dev-cluster.sh df33a30c1dcc0ea832899c849be05fe9deb47433
> examples/vagrant/upstart/aurora-scheduler-kerberos.conf eec5ee3a2f041ae25fa664b80004e27ed8b5e2b0
> examples/vagrant/upstart/aurora-scheduler.conf 7e10b2c7690087bb150a9033cbd576ab82b1b185
> examples/vagrant/upstart/mesos-master.conf a2ed953d871a7b28444a188ee0fc152853c5b088
> examples/vagrant/upstart/mesos-slave.conf d97fa1fcf99580ef3f0997e9c78cb9775b91a818
>
> Diff: https://reviews.apache.org/r/44871/diff/
>
>
> Testing
> -------
>
> I can run `vagrant up`, end-to-end tests pass.
>
> Reviewers - you can do this as well by applying the patch. You will observe a long fetch on the first run (much like you would with the current repo if you wiped your local vagrant boxes). However, subsequent `vagrant destroy`, `vagrant up` cycles should be relatively fast, about 1m30s for me.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 44871: Speed up Vagrant provisioning by using a
custom base box.
Posted by Bill Farner <wf...@apache.org>.
> On March 17, 2016, 11:01 a.m., Aurora ReviewBot wrote:
> > Master (6537581) is red with this patch.
> > ./build-support/jenkins/build.sh
> >
> > [1m proxy_driver = ProxyDriver()[0m
> > [1m with temporary_dir() as checkpoint_root:[0m
> > [1m te = AuroraExecutor([0m
> > [1m> runner_provider=make_provider(checkpoint_root),[0m
> > [1m sandbox_provider=DefaultTestSandboxProvider())[0m
> >
> > src/test/python/apache/aurora/executor/test_thermos_executor.py:580:
> > _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> > src/test/python/apache/aurora/executor/test_thermos_executor.py:193: in make_provider
> > [1m pex_location=thermos_runner_path(),[0m
> > _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> >
> > build = True
> >
> > [1m def thermos_runner_path(build=True):[0m
> > [1m if not build:[0m
> > [1m return getattr(thermos_runner_path, 'value', None)[0m
> > [1m [0m
> > [1m if not hasattr(thermos_runner_path, 'value'):[0m
> > [1m pex_dir = safe_mkdtemp()[0m
> > [1m> assert subprocess.call(["./pants", "--pants-distdir=%s" % pex_dir, "binary",[0m
> > [1m "src/main/python/apache/thermos/runner:thermos_runner"]) == 0[0m
> > [1m[31mE assert 1 == 0[0m
> > [1m[31mE + where 1 = <function call at 0x7f83cd239b18>(['./pants', '--pants-distdir=/tmp/user/10021/tmp0RrjAm', 'binary', 'src/main/python/apache/thermos/runner:thermos_runner'])[0m
> > [1m[31mE + where <function call at 0x7f83cd239b18> = subprocess.call[0m
> >
> > src/test/python/apache/aurora/executor/test_thermos_executor.py:185: AssertionError
> > -------------- Captured stderr call --------------
> > Traceback (most recent call last):
> > File "/home/jenkins/.cache/pants/setup/bootstrap-Linux-x86_64/0.0.75/bin/pants", line 7, in <module>
> > from pants.bin.pants_exe import main
> > ImportError: No module named pants.bin.pants_exe
> > generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
> > [1m[31m 16 failed, 639 passed, 5 skipped, 1 warnings, 8 error in 216.63 seconds [0m
> >
> > FAILURE
> >
> >
> > 18:00:57 04:20 [complete][31m
> > FAILURE[0m
> >
> >
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
Noticed this error in another review reply. I've wiped the workspace for this job in the hopes that it's an issue of bad state.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44871/#review124062
-----------------------------------------------------------
On March 17, 2016, 10:28 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44871/
> -----------------------------------------------------------
>
> (Updated March 17, 2016, 10:28 a.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Relevant docs on packer can be found here: https://www.packer.io/docs/
>
> To support this, i have created the [`apache-aurora` org](https://atlas.hashicorp.com/apache-aurora). If we move forward with this patch, i will be looking to add other committers to the org and improve the bus factor.
>
>
> Diffs
> -----
>
> .gitignore 1af09a251b3f76c13813033d32aa7efba9aef304
> Vagrantfile 2d6c2ae598e80035840f7e517e161be266b581dd
> build-support/packer/README.md PRE-CREATION
> build-support/packer/aurora.json PRE-CREATION
> build-support/packer/build.sh PRE-CREATION
> examples/vagrant/mesos_config/README.md PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-master/ip PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-master/roles PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/containerizers PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/hostname PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/ip PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/modules PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/resource_estimator PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/resources PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/work_dir PRE-CREATION
> examples/vagrant/provision-dev-cluster.sh df33a30c1dcc0ea832899c849be05fe9deb47433
> examples/vagrant/upstart/aurora-scheduler-kerberos.conf eec5ee3a2f041ae25fa664b80004e27ed8b5e2b0
> examples/vagrant/upstart/aurora-scheduler.conf 7e10b2c7690087bb150a9033cbd576ab82b1b185
> examples/vagrant/upstart/mesos-master.conf a2ed953d871a7b28444a188ee0fc152853c5b088
> examples/vagrant/upstart/mesos-slave.conf d97fa1fcf99580ef3f0997e9c78cb9775b91a818
>
> Diff: https://reviews.apache.org/r/44871/diff/
>
>
> Testing
> -------
>
> I can run `vagrant up`, end-to-end tests pass.
>
> Reviewers - you can do this as well by applying the patch. You will observe a long fetch on the first run (much like you would with the current repo if you wiped your local vagrant boxes). However, subsequent `vagrant destroy`, `vagrant up` cycles should be relatively fast, about 1m30s for me.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 44871: Speed up Vagrant provisioning by using a
custom base box.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44871/#review124062
-----------------------------------------------------------
Master (6537581) is red with this patch.
./build-support/jenkins/build.sh
[1m proxy_driver = ProxyDriver()[0m
[1m with temporary_dir() as checkpoint_root:[0m
[1m te = AuroraExecutor([0m
[1m> runner_provider=make_provider(checkpoint_root),[0m
[1m sandbox_provider=DefaultTestSandboxProvider())[0m
src/test/python/apache/aurora/executor/test_thermos_executor.py:580:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
src/test/python/apache/aurora/executor/test_thermos_executor.py:193: in make_provider
[1m pex_location=thermos_runner_path(),[0m
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
build = True
[1m def thermos_runner_path(build=True):[0m
[1m if not build:[0m
[1m return getattr(thermos_runner_path, 'value', None)[0m
[1m [0m
[1m if not hasattr(thermos_runner_path, 'value'):[0m
[1m pex_dir = safe_mkdtemp()[0m
[1m> assert subprocess.call(["./pants", "--pants-distdir=%s" % pex_dir, "binary",[0m
[1m "src/main/python/apache/thermos/runner:thermos_runner"]) == 0[0m
[1m[31mE assert 1 == 0[0m
[1m[31mE + where 1 = <function call at 0x7f83cd239b18>(['./pants', '--pants-distdir=/tmp/user/10021/tmp0RrjAm', 'binary', 'src/main/python/apache/thermos/runner:thermos_runner'])[0m
[1m[31mE + where <function call at 0x7f83cd239b18> = subprocess.call[0m
src/test/python/apache/aurora/executor/test_thermos_executor.py:185: AssertionError
-------------- Captured stderr call --------------
Traceback (most recent call last):
File "/home/jenkins/.cache/pants/setup/bootstrap-Linux-x86_64/0.0.75/bin/pants", line 7, in <module>
from pants.bin.pants_exe import main
ImportError: No module named pants.bin.pants_exe
generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
[1m[31m 16 failed, 639 passed, 5 skipped, 1 warnings, 8 error in 216.63 seconds [0m
FAILURE
18:00:57 04:20 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 17, 2016, 5:28 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44871/
> -----------------------------------------------------------
>
> (Updated March 17, 2016, 5:28 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Relevant docs on packer can be found here: https://www.packer.io/docs/
>
> To support this, i have created the [`apache-aurora` org](https://atlas.hashicorp.com/apache-aurora). If we move forward with this patch, i will be looking to add other committers to the org and improve the bus factor.
>
>
> Diffs
> -----
>
> .gitignore 1af09a251b3f76c13813033d32aa7efba9aef304
> Vagrantfile 2d6c2ae598e80035840f7e517e161be266b581dd
> build-support/packer/README.md PRE-CREATION
> build-support/packer/aurora.json PRE-CREATION
> build-support/packer/build.sh PRE-CREATION
> examples/vagrant/mesos_config/README.md PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-master/ip PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-master/roles PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/containerizers PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/hostname PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/ip PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/modules PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/resource_estimator PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/resources PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/work_dir PRE-CREATION
> examples/vagrant/provision-dev-cluster.sh df33a30c1dcc0ea832899c849be05fe9deb47433
> examples/vagrant/upstart/aurora-scheduler-kerberos.conf eec5ee3a2f041ae25fa664b80004e27ed8b5e2b0
> examples/vagrant/upstart/aurora-scheduler.conf 7e10b2c7690087bb150a9033cbd576ab82b1b185
> examples/vagrant/upstart/mesos-master.conf a2ed953d871a7b28444a188ee0fc152853c5b088
> examples/vagrant/upstart/mesos-slave.conf d97fa1fcf99580ef3f0997e9c78cb9775b91a818
>
> Diff: https://reviews.apache.org/r/44871/diff/
>
>
> Testing
> -------
>
> I can run `vagrant up`, end-to-end tests pass.
>
> Reviewers - you can do this as well by applying the patch. You will observe a long fetch on the first run (much like you would with the current repo if you wiped your local vagrant boxes). However, subsequent `vagrant destroy`, `vagrant up` cycles should be relatively fast, about 1m30s for me.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 44871: Speed up Vagrant provisioning by using a
custom base box.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44871/#review124125
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On March 17, 2016, 2:21 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44871/
> -----------------------------------------------------------
>
> (Updated March 17, 2016, 2:21 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Relevant docs on packer can be found here: https://www.packer.io/docs/
>
> To support this, i have created the [`apache-aurora` org](https://atlas.hashicorp.com/apache-aurora). If we move forward with this patch, i will be looking to add other committers to the org and improve the bus factor.
>
>
> Diffs
> -----
>
> .gitignore 1af09a251b3f76c13813033d32aa7efba9aef304
> Vagrantfile 2d6c2ae598e80035840f7e517e161be266b581dd
> build-support/packer/README.md PRE-CREATION
> build-support/packer/aurora.json PRE-CREATION
> build-support/packer/build.sh PRE-CREATION
> examples/vagrant/mesos_config/README.md PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-master/ip PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-master/roles PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/containerizers PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/hostname PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/ip PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/modules PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/resource_estimator PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/resources PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/work_dir PRE-CREATION
> examples/vagrant/provision-dev-cluster.sh df33a30c1dcc0ea832899c849be05fe9deb47433
> examples/vagrant/upstart/aurora-scheduler-kerberos.conf eec5ee3a2f041ae25fa664b80004e27ed8b5e2b0
> examples/vagrant/upstart/aurora-scheduler.conf 7e10b2c7690087bb150a9033cbd576ab82b1b185
> examples/vagrant/upstart/mesos-master.conf a2ed953d871a7b28444a188ee0fc152853c5b088
> examples/vagrant/upstart/mesos-slave.conf d97fa1fcf99580ef3f0997e9c78cb9775b91a818
>
> Diff: https://reviews.apache.org/r/44871/diff/
>
>
> Testing
> -------
>
> I can run `vagrant up`, end-to-end tests pass.
>
> Reviewers - you can do this as well by applying the patch. You will observe a long fetch on the first run (much like you would with the current repo if you wiped your local vagrant boxes). However, subsequent `vagrant destroy`, `vagrant up` cycles should be relatively fast, about 1m30s for me.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 44871: Speed up Vagrant provisioning by using a
custom base box.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44871/#review124103
-----------------------------------------------------------
Ship it!
Master (6537581) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 17, 2016, 9:21 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44871/
> -----------------------------------------------------------
>
> (Updated March 17, 2016, 9:21 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Relevant docs on packer can be found here: https://www.packer.io/docs/
>
> To support this, i have created the [`apache-aurora` org](https://atlas.hashicorp.com/apache-aurora). If we move forward with this patch, i will be looking to add other committers to the org and improve the bus factor.
>
>
> Diffs
> -----
>
> .gitignore 1af09a251b3f76c13813033d32aa7efba9aef304
> Vagrantfile 2d6c2ae598e80035840f7e517e161be266b581dd
> build-support/packer/README.md PRE-CREATION
> build-support/packer/aurora.json PRE-CREATION
> build-support/packer/build.sh PRE-CREATION
> examples/vagrant/mesos_config/README.md PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-master/ip PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-master/roles PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/containerizers PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/hostname PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/ip PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/modules PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/resource_estimator PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/resources PRE-CREATION
> examples/vagrant/mesos_config/etc_mesos-slave/work_dir PRE-CREATION
> examples/vagrant/provision-dev-cluster.sh df33a30c1dcc0ea832899c849be05fe9deb47433
> examples/vagrant/upstart/aurora-scheduler-kerberos.conf eec5ee3a2f041ae25fa664b80004e27ed8b5e2b0
> examples/vagrant/upstart/aurora-scheduler.conf 7e10b2c7690087bb150a9033cbd576ab82b1b185
> examples/vagrant/upstart/mesos-master.conf a2ed953d871a7b28444a188ee0fc152853c5b088
> examples/vagrant/upstart/mesos-slave.conf d97fa1fcf99580ef3f0997e9c78cb9775b91a818
>
> Diff: https://reviews.apache.org/r/44871/diff/
>
>
> Testing
> -------
>
> I can run `vagrant up`, end-to-end tests pass.
>
> Reviewers - you can do this as well by applying the patch. You will observe a long fetch on the first run (much like you would with the current repo if you wiped your local vagrant boxes). However, subsequent `vagrant destroy`, `vagrant up` cycles should be relatively fast, about 1m30s for me.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 44871: Speed up Vagrant provisioning by using a
custom base box.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44871/
-----------------------------------------------------------
(Updated March 17, 2016, 2:21 p.m.)
Review request for Aurora, John Sirois and Zameer Manji.
Changes
-------
Removed some large/unused packages to trim down the base box size.
Repository: aurora
Description
-------
Relevant docs on packer can be found here: https://www.packer.io/docs/
To support this, i have created the [`apache-aurora` org](https://atlas.hashicorp.com/apache-aurora). If we move forward with this patch, i will be looking to add other committers to the org and improve the bus factor.
Diffs (updated)
-----
.gitignore 1af09a251b3f76c13813033d32aa7efba9aef304
Vagrantfile 2d6c2ae598e80035840f7e517e161be266b581dd
build-support/packer/README.md PRE-CREATION
build-support/packer/aurora.json PRE-CREATION
build-support/packer/build.sh PRE-CREATION
examples/vagrant/mesos_config/README.md PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-master/ip PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-master/roles PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-slave/containerizers PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-slave/hostname PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-slave/ip PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-slave/modules PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-slave/resource_estimator PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-slave/resources PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-slave/work_dir PRE-CREATION
examples/vagrant/provision-dev-cluster.sh df33a30c1dcc0ea832899c849be05fe9deb47433
examples/vagrant/upstart/aurora-scheduler-kerberos.conf eec5ee3a2f041ae25fa664b80004e27ed8b5e2b0
examples/vagrant/upstart/aurora-scheduler.conf 7e10b2c7690087bb150a9033cbd576ab82b1b185
examples/vagrant/upstart/mesos-master.conf a2ed953d871a7b28444a188ee0fc152853c5b088
examples/vagrant/upstart/mesos-slave.conf d97fa1fcf99580ef3f0997e9c78cb9775b91a818
Diff: https://reviews.apache.org/r/44871/diff/
Testing
-------
I can run `vagrant up`, end-to-end tests pass.
Reviewers - you can do this as well by applying the patch. You will observe a long fetch on the first run (much like you would with the current repo if you wiped your local vagrant boxes). However, subsequent `vagrant destroy`, `vagrant up` cycles should be relatively fast, about 1m30s for me.
Thanks,
Bill Farner
Re: Review Request 44871: Speed up Vagrant provisioning by using a
custom base box.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44871/
-----------------------------------------------------------
(Updated March 17, 2016, 10:28 a.m.)
Review request for Aurora, John Sirois and Zameer Manji.
Changes
-------
Added a doc to explain the mesos package configuration.
Repository: aurora
Description
-------
Relevant docs on packer can be found here: https://www.packer.io/docs/
To support this, i have created the [`apache-aurora` org](https://atlas.hashicorp.com/apache-aurora). If we move forward with this patch, i will be looking to add other committers to the org and improve the bus factor.
Diffs (updated)
-----
.gitignore 1af09a251b3f76c13813033d32aa7efba9aef304
Vagrantfile 2d6c2ae598e80035840f7e517e161be266b581dd
build-support/packer/README.md PRE-CREATION
build-support/packer/aurora.json PRE-CREATION
build-support/packer/build.sh PRE-CREATION
examples/vagrant/mesos_config/README.md PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-master/ip PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-master/roles PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-slave/containerizers PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-slave/hostname PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-slave/ip PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-slave/modules PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-slave/resource_estimator PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-slave/resources PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-slave/work_dir PRE-CREATION
examples/vagrant/provision-dev-cluster.sh df33a30c1dcc0ea832899c849be05fe9deb47433
examples/vagrant/upstart/aurora-scheduler-kerberos.conf eec5ee3a2f041ae25fa664b80004e27ed8b5e2b0
examples/vagrant/upstart/aurora-scheduler.conf 7e10b2c7690087bb150a9033cbd576ab82b1b185
examples/vagrant/upstart/mesos-master.conf a2ed953d871a7b28444a188ee0fc152853c5b088
examples/vagrant/upstart/mesos-slave.conf d97fa1fcf99580ef3f0997e9c78cb9775b91a818
Diff: https://reviews.apache.org/r/44871/diff/
Testing
-------
I can run `vagrant up`, end-to-end tests pass.
Reviewers - you can do this as well by applying the patch. You will observe a long fetch on the first run (much like you would with the current repo if you wiped your local vagrant boxes). However, subsequent `vagrant destroy`, `vagrant up` cycles should be relatively fast, about 1m30s for me.
Thanks,
Bill Farner
Re: Review Request 44871: Speed up Vagrant provisioning by using a
custom base box.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44871/
-----------------------------------------------------------
(Updated March 16, 2016, 10:44 p.m.)
Review request for Aurora, John Sirois and Zameer Manji.
Changes
-------
Speculating that a broken docker install in the base image was causing e2e test failures. Updated docker in the base box and end-to-end tests are now green.
Repository: aurora
Description (updated)
-------
Relevant docs on packer can be found here: https://www.packer.io/docs/
To support this, i have created the [`apache-aurora` org](https://atlas.hashicorp.com/apache-aurora). If we move forward with this patch, i will be looking to add other committers to the org and improve the bus factor.
Diffs (updated)
-----
.gitignore 1af09a251b3f76c13813033d32aa7efba9aef304
Vagrantfile 2d6c2ae598e80035840f7e517e161be266b581dd
build-support/packer/README.md PRE-CREATION
build-support/packer/aurora.json PRE-CREATION
build-support/packer/build.sh PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-master/ip PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-master/roles PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-slave/containerizers PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-slave/hostname PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-slave/ip PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-slave/modules PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-slave/resource_estimator PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-slave/resources PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-slave/work_dir PRE-CREATION
examples/vagrant/provision-dev-cluster.sh df33a30c1dcc0ea832899c849be05fe9deb47433
examples/vagrant/upstart/aurora-scheduler-kerberos.conf eec5ee3a2f041ae25fa664b80004e27ed8b5e2b0
examples/vagrant/upstart/aurora-scheduler.conf 7e10b2c7690087bb150a9033cbd576ab82b1b185
examples/vagrant/upstart/mesos-master.conf a2ed953d871a7b28444a188ee0fc152853c5b088
examples/vagrant/upstart/mesos-slave.conf d97fa1fcf99580ef3f0997e9c78cb9775b91a818
Diff: https://reviews.apache.org/r/44871/diff/
Testing
-------
I can run `vagrant up`, end-to-end tests pass.
Reviewers - you can do this as well by applying the patch. You will observe a long fetch on the first run (much like you would with the current repo if you wiped your local vagrant boxes). However, subsequent `vagrant destroy`, `vagrant up` cycles should be relatively fast, about 1m30s for me.
Thanks,
Bill Farner
Re: Review Request 44871: Speed up Vagrant provisioning by using a
custom base box.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44871/
-----------------------------------------------------------
(Updated March 16, 2016, 8:51 p.m.)
Review request for Aurora, John Sirois and Zameer Manji.
Changes
-------
Addressed startup issues that jsirois and i encountered. This was an ordering issue, where init scripts from the mesos package were being used rather than the upstart scripts in our repo. In the latest revision of the patch, i dropped our upstart config and instead configure the package we are consume.
Unfortunately there's an issue i encountered down the road related to docker/devicemapper. This should not stall review, however.
Repository: aurora
Description (updated)
-------
_READY FOR REVIEW BUT NOT SUBMISSION - END-TO-END TESTS FAIL_
Relevant docs on packer can be found here: https://www.packer.io/docs/
To support this, i have created the [`apache-aurora` org](https://atlas.hashicorp.com/apache-aurora). If we move forward with this patch, i will be looking to add other committers to the org and improve the bus factor.
Diffs (updated)
-----
.gitignore 1af09a251b3f76c13813033d32aa7efba9aef304
Vagrantfile 2d6c2ae598e80035840f7e517e161be266b581dd
build-support/packer/README.md PRE-CREATION
build-support/packer/aurora.json PRE-CREATION
build-support/packer/build.sh PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-master/ip PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-master/roles PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-slave/containerizers PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-slave/hostname PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-slave/ip PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-slave/modules PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-slave/resource_estimator PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-slave/resources PRE-CREATION
examples/vagrant/mesos_config/etc_mesos-slave/work_dir PRE-CREATION
examples/vagrant/provision-dev-cluster.sh df33a30c1dcc0ea832899c849be05fe9deb47433
examples/vagrant/upstart/aurora-scheduler-kerberos.conf eec5ee3a2f041ae25fa664b80004e27ed8b5e2b0
examples/vagrant/upstart/aurora-scheduler.conf 7e10b2c7690087bb150a9033cbd576ab82b1b185
examples/vagrant/upstart/mesos-master.conf a2ed953d871a7b28444a188ee0fc152853c5b088
examples/vagrant/upstart/mesos-slave.conf d97fa1fcf99580ef3f0997e9c78cb9775b91a818
Diff: https://reviews.apache.org/r/44871/diff/
Testing (updated)
-------
I can run `vagrant up`, end-to-end tests pass.
Reviewers - you can do this as well by applying the patch. You will observe a long fetch on the first run (much like you would with the current repo if you wiped your local vagrant boxes). However, subsequent `vagrant destroy`, `vagrant up` cycles should be relatively fast, about 1m30s for me.
Thanks,
Bill Farner
Re: Review Request 44871: Speed up Vagrant provisioning by using a
custom base box.
Posted by Bill Farner <wf...@apache.org>.
> On March 15, 2016, 9:53 p.m., John Sirois wrote:
> > .gitignore, line 1
> > <https://reviews.apache.org/r/44871/diff/1/?file=1300417#file1300417line1>
> >
> > Not related, but noticing this is a lie iiuc. Should be 'Use /dist/ to ignore dist in project root.' (reference 'PATTERN FORMAT' section here: https://www.kernel.org/pub/software/scm/git/docs/gitignore.html).
Dropped the comment, i don't think it adds much and as you note - is incorrect.
> On March 15, 2016, 9:53 p.m., John Sirois wrote:
> > examples/vagrant/provision-dev-cluster.sh, line 125
> > <https://reviews.apache.org/r/44871/diff/1/?file=1300422#file1300422line125>
> >
> > Is this `/home/vagrant/aurora`? As things stand almost all paths - save for `pushd aurora` in the `prepare_extras` function - are absolute; so this relative path reads risky / uncertain.
Good point, changed to `/home/vagrant/aurora`. This was relying on the working dir and `update-sources` script to line up, which indeed seems risky.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44871/#review123815
-----------------------------------------------------------
On March 15, 2016, 4:59 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44871/
> -----------------------------------------------------------
>
> (Updated March 15, 2016, 4:59 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Relevant docs on packer can be found here: https://www.packer.io/docs/
>
> To support this, i have created the [`apache-aurora` org](https://atlas.hashicorp.com/apache-aurora). If we move forward with this patch, i will be looking to add other committers to the org and improve the bus factor.
>
>
> Diffs
> -----
>
> .gitignore 1af09a251b3f76c13813033d32aa7efba9aef304
> Vagrantfile 2d6c2ae598e80035840f7e517e161be266b581dd
> build-support/packer/README.md PRE-CREATION
> build-support/packer/aurora.json PRE-CREATION
> build-support/packer/build.sh PRE-CREATION
> examples/vagrant/provision-dev-cluster.sh df33a30c1dcc0ea832899c849be05fe9deb47433
>
> Diff: https://reviews.apache.org/r/44871/diff/
>
>
> Testing
> -------
>
> I can run `vagrant up`. Currently looking into a possible configuration issue in end-to-end tests, to be corrected before submitting.
>
> Reviewers - you can do this as well by applying the patch. You will observe a long fetch on the first run (much like you would with the current repo if you wiped your local vagrant boxes). However, subsequent `vagrant destroy`, `vagrant up` cycles should be relatively fast, about 1m30s for me.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 44871: Speed up Vagrant provisioning by using a
custom base box.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44871/#review123815
-----------------------------------------------------------
Ship it!
2:44 for a destroy/up after the initial image pull from Montana. Thats qualitatively much better than before!
The e2e ran green for me, albeit on my 2nd attempt after a trip home. I don't have details for you on the initial failure except for the inability of the client to find the scheduler.
The connection difficulty somehow went away on the second run.
I'm away until Sunday so this LGTM as it stands, but you may want to replace me with another reviewer if there are substantial changes.
.gitignore (line 1)
<https://reviews.apache.org/r/44871/#comment186092>
Not related, but noticing this is a lie iiuc. Should be 'Use /dist/ to ignore dist in project root.' (reference 'PATTERN FORMAT' section here: https://www.kernel.org/pub/software/scm/git/docs/gitignore.html).
examples/vagrant/provision-dev-cluster.sh (line 87)
<https://reviews.apache.org/r/44871/#comment186102>
Is this `/home/vagrant/aurora`? As things stand almost all paths - save for `pushd aurora` in the `prepare_extras` function - are absolute; so this relative path reads risky / uncertain.
- John Sirois
On March 15, 2016, 5:59 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44871/
> -----------------------------------------------------------
>
> (Updated March 15, 2016, 5:59 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Relevant docs on packer can be found here: https://www.packer.io/docs/
>
> To support this, i have created the [`apache-aurora` org](https://atlas.hashicorp.com/apache-aurora). If we move forward with this patch, i will be looking to add other committers to the org and improve the bus factor.
>
>
> Diffs
> -----
>
> .gitignore 1af09a251b3f76c13813033d32aa7efba9aef304
> Vagrantfile 2d6c2ae598e80035840f7e517e161be266b581dd
> build-support/packer/README.md PRE-CREATION
> build-support/packer/aurora.json PRE-CREATION
> build-support/packer/build.sh PRE-CREATION
> examples/vagrant/provision-dev-cluster.sh df33a30c1dcc0ea832899c849be05fe9deb47433
>
> Diff: https://reviews.apache.org/r/44871/diff/
>
>
> Testing
> -------
>
> I can run `vagrant up`. Currently looking into a possible configuration issue in end-to-end tests, to be corrected before submitting.
>
> Reviewers - you can do this as well by applying the patch. You will observe a long fetch on the first run (much like you would with the current repo if you wiped your local vagrant boxes). However, subsequent `vagrant destroy`, `vagrant up` cycles should be relatively fast, about 1m30s for me.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 44871: Speed up Vagrant provisioning by using a
custom base box.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44871/#review123821
-----------------------------------------------------------
Ship it!
Master (6537581) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 15, 2016, 11:59 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44871/
> -----------------------------------------------------------
>
> (Updated March 15, 2016, 11:59 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Relevant docs on packer can be found here: https://www.packer.io/docs/
>
> To support this, i have created the [`apache-aurora` org](https://atlas.hashicorp.com/apache-aurora). If we move forward with this patch, i will be looking to add other committers to the org and improve the bus factor.
>
>
> Diffs
> -----
>
> .gitignore 1af09a251b3f76c13813033d32aa7efba9aef304
> Vagrantfile 2d6c2ae598e80035840f7e517e161be266b581dd
> build-support/packer/README.md PRE-CREATION
> build-support/packer/aurora.json PRE-CREATION
> build-support/packer/build.sh PRE-CREATION
> examples/vagrant/provision-dev-cluster.sh df33a30c1dcc0ea832899c849be05fe9deb47433
>
> Diff: https://reviews.apache.org/r/44871/diff/
>
>
> Testing
> -------
>
> I can run `vagrant up`. Currently looking into a possible configuration issue in end-to-end tests, to be corrected before submitting.
>
> Reviewers - you can do this as well by applying the patch. You will observe a long fetch on the first run (much like you would with the current repo if you wiped your local vagrant boxes). However, subsequent `vagrant destroy`, `vagrant up` cycles should be relatively fast, about 1m30s for me.
>
>
> Thanks,
>
> Bill Farner
>
>