You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by "pkarashchenko (via GitHub)" <gi...@apache.org> on 2023/07/12 05:05:06 UTC

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9790: signal: SIGKILL or SIGSTOP cannot be caught

pkarashchenko commented on code in PR #9790:
URL: https://github.com/apache/nuttx/pull/9790#discussion_r1260588897


##########
include/signal.h:
##########
@@ -236,7 +235,10 @@
 #  define SIG_HOLD      ((_sa_handler_t)1)   /* Used only with sigset() */
 #endif
 
-#define tkill(tid, signo)  tgkill((pid_t)-1, tid, signo)
+#define GOOD_SIGNO(s)     (((unsigned)(s)) <= MAX_SIGNO)
+#define UNCAUGHT_SIGNO(s) (s == SIGKILL || s == SIGSTOP)

Review Comment:
   ```suggestion
   #define UNCAUGHT_SIGNO(s) ((s) == SIGKILL || (s) == SIGSTOP)
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org