[GitHub] [commons-configuration] kinow commented on a diff in pull request #188: CONFIGURATION-813: mailapi follow up

[GitBox <gi...@apache.org>]

kinow commented on code in PR #188:
URL: https://github.com/apache/commons-configuration/pull/188#discussion_r898350424


##########
src/test/java/org/apache/commons/configuration2/TestDataConfiguration.java:
##########
@@ -358,7 +347,7 @@ public void setUp() throws Exception {
         // email address
         conf.addProperty("email.string", "ebourg@apache.org");
         conf.addProperty("email.string.interpolated", "${email.string}");
-        conf.addProperty("email.object", createInternetAddress("ebourg@apache.org"));
+        conf.addProperty("email.object", new InternetAddress("ebourg@apache.org"));

Review Comment:
   I think this email was already in the code before this change. There might be more PII in other places, I'm +1 to removing it. Maybe we could do it in a follow up issue if that's easier.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org