You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2014/10/14 13:48:41 UTC

Review Request 26682: Nagios Alerts Fail When SSL Is Enabled For Some Services

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26682/
-----------------------------------------------------------

Review request for Ambari, Nate Cole and Tom Beerbower.


Bugs: AMBARI-7772
    https://issues.apache.org/jira/browse/AMBARI-7772


Repository: ambari


Description
-------

When SSL is enabled for HDFS, YARN, and MapReduce, Nagios alerts still reference the original, non-SSL host and port properties.

Additionally, the {{curl}} command in check_webui.sh must be altered so that a request to an SSL resource is automatically trusted and accepted.

Changes are required so that Nagios' params.py detects the http policy for each of the above services and correctly extracts those properties from the supplied JSON.

Although BIGTOP and HDP 1.x also have this problem, they will not be fixed since Nagios is on its way out. 


Diffs
-----

  ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_webui.sh e47a74c 
  ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_webui_ha.sh 1d0f5f3 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_webui.sh 011dcc7 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_checkpoint_time.py ab889d1 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_webui.sh e47a74c 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_webui_ha.sh 1d0f5f3 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/params.py aadc0e6 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-commands.cfg.j2 39bb636 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 ec375be 

Diff: https://reviews.apache.org/r/26682/diff/


Testing
-------

Ran end-to-end testing of 2 cluster installs. The first install was a normal, non-SSL environment. The 2nd install was an environment where SSL was enabled for HDFS, YARN, and MR. Verified that all alerts worked corrected for these services in the 2 clusters.

OK
----------------------------------------------------------------------
Total run:644
Total errors:0
Total failures:0


Thanks,

Jonathan Hurley


Re: Review Request 26682: Nagios Alerts Fail When SSL Is Enabled For Some Services

Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26682/#review56518
-----------------------------------------------------------

Ship it!


Ship It!

- Tom Beerbower


On Oct. 14, 2014, 11:48 a.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26682/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2014, 11:48 a.m.)
> 
> 
> Review request for Ambari, Nate Cole and Tom Beerbower.
> 
> 
> Bugs: AMBARI-7772
>     https://issues.apache.org/jira/browse/AMBARI-7772
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When SSL is enabled for HDFS, YARN, and MapReduce, Nagios alerts still reference the original, non-SSL host and port properties.
> 
> Additionally, the {{curl}} command in check_webui.sh must be altered so that a request to an SSL resource is automatically trusted and accepted.
> 
> Changes are required so that Nagios' params.py detects the http policy for each of the above services and correctly extracts those properties from the supplied JSON.
> 
> Although BIGTOP and HDP 1.x also have this problem, they will not be fixed since Nagios is on its way out. 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_webui.sh e47a74c 
>   ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_webui_ha.sh 1d0f5f3 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_webui.sh 011dcc7 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_checkpoint_time.py ab889d1 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_webui.sh e47a74c 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_webui_ha.sh 1d0f5f3 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/params.py aadc0e6 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-commands.cfg.j2 39bb636 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 ec375be 
> 
> Diff: https://reviews.apache.org/r/26682/diff/
> 
> 
> Testing
> -------
> 
> Ran end-to-end testing of 2 cluster installs. The first install was a normal, non-SSL environment. The 2nd install was an environment where SSL was enabled for HDFS, YARN, and MR. Verified that all alerts worked corrected for these services in the 2 clusters.
> 
> OK
> ----------------------------------------------------------------------
> Total run:644
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Re: Review Request 26682: Nagios Alerts Fail When SSL Is Enabled For Some Services

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26682/#review56507
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Oct. 14, 2014, 7:48 a.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26682/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2014, 7:48 a.m.)
> 
> 
> Review request for Ambari, Nate Cole and Tom Beerbower.
> 
> 
> Bugs: AMBARI-7772
>     https://issues.apache.org/jira/browse/AMBARI-7772
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When SSL is enabled for HDFS, YARN, and MapReduce, Nagios alerts still reference the original, non-SSL host and port properties.
> 
> Additionally, the {{curl}} command in check_webui.sh must be altered so that a request to an SSL resource is automatically trusted and accepted.
> 
> Changes are required so that Nagios' params.py detects the http policy for each of the above services and correctly extracts those properties from the supplied JSON.
> 
> Although BIGTOP and HDP 1.x also have this problem, they will not be fixed since Nagios is on its way out. 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_webui.sh e47a74c 
>   ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/NAGIOS/package/files/check_webui_ha.sh 1d0f5f3 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_webui.sh 011dcc7 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_checkpoint_time.py ab889d1 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_webui.sh e47a74c 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_webui_ha.sh 1d0f5f3 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/params.py aadc0e6 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-commands.cfg.j2 39bb636 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 ec375be 
> 
> Diff: https://reviews.apache.org/r/26682/diff/
> 
> 
> Testing
> -------
> 
> Ran end-to-end testing of 2 cluster installs. The first install was a normal, non-SSL environment. The 2nd install was an environment where SSL was enabled for HDFS, YARN, and MR. Verified that all alerts worked corrected for these services in the 2 clusters.
> 
> OK
> ----------------------------------------------------------------------
> Total run:644
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>