You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/03/07 04:13:13 UTC
Review Request: Set command executor id from task id.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9792/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
Now that executors can have names, this cleans up the command executor id format.
Diffs
-----
src/slave/slave.hpp c6970b230c80abd9f91a4359ef86b9f97b43764c
Diff: https://reviews.apache.org/r/9792/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request: Set command executor id from task id.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9792/#review17510
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 7, 2013, 3:13 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9792/
> -----------------------------------------------------------
>
> (Updated March 7, 2013, 3:13 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Now that executors can have names, this cleans up the command executor id format.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp c6970b230c80abd9f91a4359ef86b9f97b43764c
>
> Diff: https://reviews.apache.org/r/9792/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Set command executor id from task id.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9792/#review17525
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On March 7, 2013, 3:13 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9792/
> -----------------------------------------------------------
>
> (Updated March 7, 2013, 3:13 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Now that executors can have names, this cleans up the command executor id format.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp c6970b230c80abd9f91a4359ef86b9f97b43764c
>
> Diff: https://reviews.apache.org/r/9792/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Set command executor id from task id.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9792/
-----------------------------------------------------------
(Updated March 8, 2013, 2:23 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Quoting the command, rebased off trunk.
Description
-------
Now that executors can have names, this cleans up the command executor id format.
Diffs (updated)
-----
src/slave/slave.hpp c6970b230c80abd9f91a4359ef86b9f97b43764c
Diff: https://reviews.apache.org/r/9792/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request: Set command executor id from task id.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9792/#review17526
-----------------------------------------------------------
src/slave/slave.hpp
<https://reviews.apache.org/r/9792/#comment37198>
Do you want to quote the actual command? Or prefix it with 'sh -c' to indicate more clearly that this is what is being executed?
- Benjamin Hindman
On March 7, 2013, 3:13 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9792/
> -----------------------------------------------------------
>
> (Updated March 7, 2013, 3:13 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Now that executors can have names, this cleans up the command executor id format.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp c6970b230c80abd9f91a4359ef86b9f97b43764c
>
> Diff: https://reviews.apache.org/r/9792/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>