[GitHub] [helix] pkuwm commented on a change in pull request #1218: Fix ClusterManager thread leak

[GitBox <gi...@apache.org>]

pkuwm commented on a change in pull request #1218:
URL: https://github.com/apache/helix/pull/1218#discussion_r465915063



##########
File path: helix-core/src/test/java/org/apache/helix/integration/task/TestNoDoubleAssign.java
##########
@@ -42,7 +42,7 @@
 import org.testng.annotations.Test;
 
 public class TestNoDoubleAssign extends TaskTestBase {
-  private static final int THREAD_COUNT = 10;
+  private static final int THREAD_COUNT = 1;

Review comment:
       Since thread count is 1, I think `newSingleThreadExecutor` is what you need?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org