[GitHub] [zeppelin] jooyounghun commented on a diff in pull request #4426: [ZEPPELIN-5766] Window compilation (.appveyor.yml)

[GitBox <gi...@apache.org>]

jooyounghun commented on code in PR #4426:
URL: https://github.com/apache/zeppelin/pull/4426#discussion_r928924555


##########
zeppelin-web/karma.conf.js:
##########
@@ -67,6 +67,7 @@ module.exports = function(config) {
       'bower_components/ace-builds/src-noconflict/keybinding-emacs.js',
       'bower_components/ace-builds/src-noconflict/ext-language_tools.js',
       'bower_components/ace-builds/src-noconflict/theme-chrome.js',
+      'bower_components/ace-builds/src-noconflict/mode-javascript.js',

Review Comment:
   I also think the file was generated when building on window. But I don't know why the file is auto-generated. First of all, I pushed another commit with mode-javascript.js removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org