You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/02/11 17:15:50 UTC

[GitHub] [activemq-artemis] jbertram commented on pull request #3952: Fix for ARTEMIS-3509

jbertram commented on pull request #3952:
URL: https://github.com/apache/activemq-artemis/pull/3952#issuecomment-1036432301


   I don't think adding `synchronized` to these methods is a valid fix. This is going to impose a potentially significant performance penalty across the broker for just about any transaction. Also, you have not included a test to validate the fix and mitigate against future regressions.
   
   I recommend tracking down the root cause of the concurrent access in the STOMP implementation and adding protection there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org