[jira] [Created] (TS-1696) ESI build fails on fBSD

["Igor Galić (JIRA)" <ji...@apache.org>]

Igor Galić created TS-1696:
------------------------------

             Summary: ESI build fails on fBSD
                 Key: TS-1696
                 URL: https://issues.apache.org/jira/browse/TS-1696
             Project: Traffic Server
          Issue Type: Bug
          Components: Plugins
            Reporter: Igor Galić


For reference: http://ci.apache.org/builders/tserver-fbsd-trunk/builds/1672/steps/compile_3/logs/stdio


{noformat}
gmake[4]: Entering directory `/usr/home/buildslave27/slave27/tserver-fbsd-trunk/build/plugins/experimental/esi'
  CXX      docnode_test.o
cc1plus: warnings being treated as errors
test/docnode_test.cc: In function 'void checkNodeList2(const EsiLib::DocNodeList&)':
test/docnode_test.cc:85: warning: comparison between signed and unsigned integer expressions
test/docnode_test.cc:114: warning: comparison between signed and unsigned integer expressions
gmake[4]: *** [docnode_test.o] Error 1
{noformat}

It might make sense to convert {{_len}} to {{size_t}} - but there are some clever uses of negative {{len}} like here:

{code}
  inline std::string unescape(const char *str, int len = -1) {                                                                                                                                    
    std::string retval("");
    if (str) {
      for (int i = 0; (((len == -1) && (str[i] != '\0')) || (i < len)); ++i) {
        if (str[i] != '\\') {
          retval += str[i];
        }
      }
    }
    return retval;
  }
{code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira