You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/04/09 12:07:22 UTC
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4599:
Make 8.0.0 Core available. New protocol and register removed.
wu-sheng commented on a change in pull request #4599: Make 8.0.0 Core available. New protocol and register removed.
URL: https://github.com/apache/skywalking/pull/4599#discussion_r406157318
##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/TracingContext.java
##########
@@ -324,14 +324,7 @@ public AbstractSpan createExitSpan(final String operationName, final String remo
exitSpan = parentSpan;
} else {
final int parentSpanId = parentSpan == null ? -1 : parentSpan.getSpanId();
- if (StringUtil.isEmpty(remotePeer)) {
Review comment:
This deletion actually is not related to this PR. The lazy peer initialization is another feature :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services