You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by sjcorbett <gi...@git.apache.org> on 2015/06/05 15:49:23 UTC
[GitHub] incubator-brooklyn pull request: Provision latch
GitHub user sjcorbett opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/681
Provision latch
First commit is boring - it just simplifies `JcloudsLocationTest`.
Second commit adds `BrooklynConfigKeys.PROVISION_LATCH`, to block provisioning of locations until some criteria is met.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett/incubator-brooklyn provision-latch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/681.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #681
----
commit e509bf2547fb637d0435057c2081fe6efd1b1f7f
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date: 2015-06-05T13:45:08Z
Adds PROVISION_LATCH config
Behaviour as other latches. Used in MachineLifecycleEffectorTasks.
commit 2a81933b3ab27096f10e4af6873f3552688db351
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date: 2015-06-05T13:46:29Z
Simplify JcloudsLocationTest
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Provision latch
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/681#issuecomment-109298301
cc @alasdairhodge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Provision latch
Posted by alasdairhodge <gi...@git.apache.org>.
Github user alasdairhodge commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/681#discussion_r32227808
--- Diff: core/src/main/java/brooklyn/entity/basic/BrooklynConfigKeys.java ---
@@ -143,6 +143,7 @@
* component is up, but this entity does not care about the dependent component's actual config values.
*/
+ public static final ConfigKey<Boolean> PROVISION_LATCH = newBooleanConfigKey("provision.latch", "Latch for blocking location provision until ready");
--- End diff --
Yeah, I agree. I expect `PROVISION_LATCH` will eventually join `PROVISIONING_PROPERTIES` on some sort of `Provisionable` trait class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Provision latch
Posted by alasdairhodge <gi...@git.apache.org>.
Github user alasdairhodge commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/681#issuecomment-111163023
Nice addition. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Provision latch
Posted by alasdairhodge <gi...@git.apache.org>.
Github user alasdairhodge commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/681#discussion_r32227208
--- Diff: core/src/main/java/brooklyn/entity/basic/BrooklynConfigKeys.java ---
@@ -143,6 +143,7 @@
* component is up, but this entity does not care about the dependent component's actual config values.
*/
+ public static final ConfigKey<Boolean> PROVISION_LATCH = newBooleanConfigKey("provision.latch", "Latch for blocking location provision until ready");
--- End diff --
`SoftwareProcess` redefines the other lifecycle latches (referencing the ones here in `BrooklynConfigKeys`); should `PROVISION_LATCH` also be aliased there for easier discovery? I'm not convinced this is necessarily a good pattern, but inconsistency is worse.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Provision latch
Posted by alasdairhodge <gi...@git.apache.org>.
Github user alasdairhodge commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/681#discussion_r32227301
--- Diff: core/src/main/java/brooklyn/entity/basic/BrooklynConfigKeys.java ---
@@ -143,6 +143,7 @@
* component is up, but this entity does not care about the dependent component's actual config values.
*/
+ public static final ConfigKey<Boolean> PROVISION_LATCH = newBooleanConfigKey("provision.latch", "Latch for blocking location provision until ready");
--- End diff --
Oh wait, `SoftwareProcess` itself isn't consistent with which keys it aliases. Ignore me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Provision latch
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/681
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Provision latch
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/681#discussion_r32227500
--- Diff: core/src/main/java/brooklyn/entity/basic/BrooklynConfigKeys.java ---
@@ -143,6 +143,7 @@
* component is up, but this entity does not care about the dependent component's actual config values.
*/
+ public static final ConfigKey<Boolean> PROVISION_LATCH = newBooleanConfigKey("provision.latch", "Latch for blocking location provision until ready");
--- End diff --
I thought about it but figured the provisioning latch doesn't relate to the software-process-ness of an entity.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---