[GitHub] yuxihu commented on a change in pull request #13260: Support full convention in quantized pooling

[GitBox <gi...@apache.org>]

yuxihu commented on a change in pull request #13260: Support full convention in quantized pooling
URL: https://github.com/apache/incubator-mxnet/pull/13260#discussion_r235104416
 
 

 ##########
 File path: tests/python/quantization/test_quantization.py
 ##########
 @@ -214,7 +214,7 @@ def check_quantized_conv(data_shape, kernel, num_filter, pad, stride, no_bias, q
 
 @with_seed()
 def test_quantized_pooling():
-    def check_quantized_pooling(data_shape, kernel, pool_type, pad, stride, global_pool, qdtype):
+    def check_quantized_pooling(data_shape, kernel, pool_type, pad, stride, global_pool, qdtype, convention):
 
 Review comment:
   What is the default convention before this PR? By adding a new argument, you are testing "valid" and "full". Has the default case been covered with your change?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services