[jira] [Commented] (MESOS-6575) Change `disk/xfs` isolator to terminate executor when it exceeds quota

["James Peach (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15668934#comment-15668934 ] 

James Peach commented on MESOS-6575:
------------------------------------

A significant benefit of the {{disk/xfs}} isolator is that it doesn't kill the task, so I'm not very supportive of this. I suppose that it could be implemented as an additional feature flag, but I'm not sure why you would want this. IMHO the behavior of the {{disk/du}} isolator is pretty undesirable.

> Change `disk/xfs` isolator to terminate executor when it exceeds quota
> ----------------------------------------------------------------------
>
>                 Key: MESOS-6575
>                 URL: https://issues.apache.org/jira/browse/MESOS-6575
>             Project: Mesos
>          Issue Type: Task
>          Components: isolation, slave
>            Reporter: Santhosh Kumar Shanmugham
>
> Unlike {{disk/du}} isolator which sends a {{ContainerLimitation}} protobuf when the executor exceeds the quota, {{disk/xfs}} isolator, which relies on XFS's internal quota enforcement, silently fails the {{write}} operation, that causes the quota limit to be exceeded, without surfacing the quota breach information.
> This task is to change the `disk/xfs` isolator so that, a {{ContainerLimitation}} message is triggered when the quota is exceeded. 
> This feature will rely on the underlying filesystem being mounted with {{pqnoenforce}} (accounting-only mode), so that XFS does not silently causes a {{EDQUOT}} error on writes that causes the quota to be exceeded. Now the isolator can track the disk quota via {{xfs_quota}}, very much like {{disk/du}} using {{du}}, every {{container_disk_watch_interval}} and surface the disk quota limit exceed event via a {{ContainerLimitation}} protobuf, causing the executor to be terminated. This feature can then be turned on/off via the existing {{enforce_container_disk_quota}} option.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)