You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by "angela (Created) (JIRA)" <ji...@apache.org> on 2012/03/15 16:15:39 UTC
[jira] [Created] (OAK-16) Proper ValueFactory implementation and
Value handling
Proper ValueFactory implementation and Value handling
-----------------------------------------------------
Key: OAK-16
URL: https://issues.apache.org/jira/browse/OAK-16
Project: Jackrabbit Oak
Issue Type: Bug
Components: jcr
Reporter: angela
the GlobalContext contains the following code:
put(ValueFactory.class, new SimpleValueFactory());
that doesn't work as the ValueFactory needs to be bound to each session instance
in order to be able to deal with namespace mappings, paths, names etc....
michi, just told me that in addition the ValueConverted needs some focus as well.
and yesterday, i saw that Property#getType implementation in the jackrabbit-mikrokernel
was not correct...
just to mention a few issues....
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-16) Proper ValueFactory implementation and
Value handling
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290160#comment-13290160 ]
Jukka Zitting commented on OAK-16:
----------------------------------
bq. where should the check happen? oak-jcr or oak-core?
The check already exists in {{ValueHelper.convert()}}, it's just not effective since the relevant {{PropertyDefinition.getRequiredType()}} call currently returns {{PropertyType.UNDEFINED}} for all properties.
> Proper ValueFactory implementation and Value handling
> -----------------------------------------------------
>
> Key: OAK-16
> URL: https://issues.apache.org/jira/browse/OAK-16
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: jcr
> Reporter: angela
> Assignee: angela
> Fix For: 0.3
>
>
> the GlobalContext contains the following code:
> put(ValueFactory.class, new SimpleValueFactory());
> that doesn't work as the ValueFactory needs to be bound to each session instance
> in order to be able to deal with namespace mappings, paths, names etc....
> michi, just told me that in addition the ValueConverted needs some focus as well.
> and yesterday, i saw that Property#getType implementation in the jackrabbit-mikrokernel
> was not correct...
> just to mention a few issues....
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-16) Proper ValueFactory implementation and
Value handling
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290153#comment-13290153 ]
Julian Reschke commented on OAK-16:
-----------------------------------
{quote}in addition there are still some value related tck test failing. some of those
may be caused by missing validation either on oak-jcr or on oak-core... i need to take
a closer look at this again.{quote}
Indeed; {{SetValueFormatExceptionTest}} has many failures because nobody checks the type when overwriting the value. The test case asks for an immediate failure, so I don't think it's sufficient to handle that in a commit hook; where should the check happen? oak-jcr or oak-core?
> Proper ValueFactory implementation and Value handling
> -----------------------------------------------------
>
> Key: OAK-16
> URL: https://issues.apache.org/jira/browse/OAK-16
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: jcr
> Reporter: angela
> Assignee: angela
> Fix For: 0.3
>
>
> the GlobalContext contains the following code:
> put(ValueFactory.class, new SimpleValueFactory());
> that doesn't work as the ValueFactory needs to be bound to each session instance
> in order to be able to deal with namespace mappings, paths, names etc....
> michi, just told me that in addition the ValueConverted needs some focus as well.
> and yesterday, i saw that Property#getType implementation in the jackrabbit-mikrokernel
> was not correct...
> just to mention a few issues....
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-16) Proper ValueFactory implementation and
Value handling
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263564#comment-13263564 ]
angela commented on OAK-16:
---------------------------
the refactoring is almost completed. nevertheless i would like to keep the issue until we
have the reference values implemented (and properly validated) as well.
in addition there are still some value related tck test failing. some of those
may be caused by missing validation either on oak-jcr or on oak-core... i need to take
a closer look at this again.
> Proper ValueFactory implementation and Value handling
> -----------------------------------------------------
>
> Key: OAK-16
> URL: https://issues.apache.org/jira/browse/OAK-16
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: jcr
> Reporter: angela
>
> the GlobalContext contains the following code:
> put(ValueFactory.class, new SimpleValueFactory());
> that doesn't work as the ValueFactory needs to be bound to each session instance
> in order to be able to deal with namespace mappings, paths, names etc....
> michi, just told me that in addition the ValueConverted needs some focus as well.
> and yesterday, i saw that Property#getType implementation in the jackrabbit-mikrokernel
> was not correct...
> just to mention a few issues....
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-16) Proper ValueFactory implementation and
Value handling
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290168#comment-13290168 ]
Julian Reschke commented on OAK-16:
-----------------------------------
It is. :-)
> Proper ValueFactory implementation and Value handling
> -----------------------------------------------------
>
> Key: OAK-16
> URL: https://issues.apache.org/jira/browse/OAK-16
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: jcr
> Reporter: angela
> Assignee: angela
> Fix For: 0.3
>
>
> the GlobalContext contains the following code:
> put(ValueFactory.class, new SimpleValueFactory());
> that doesn't work as the ValueFactory needs to be bound to each session instance
> in order to be able to deal with namespace mappings, paths, names etc....
> michi, just told me that in addition the ValueConverted needs some focus as well.
> and yesterday, i saw that Property#getType implementation in the jackrabbit-mikrokernel
> was not correct...
> just to mention a few issues....
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-16) Proper ValueFactory implementation and
Value handling
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290162#comment-13290162 ]
angela commented on OAK-16:
---------------------------
isn't it rather a node type related issue in this case?
> Proper ValueFactory implementation and Value handling
> -----------------------------------------------------
>
> Key: OAK-16
> URL: https://issues.apache.org/jira/browse/OAK-16
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: jcr
> Reporter: angela
> Assignee: angela
> Fix For: 0.3
>
>
> the GlobalContext contains the following code:
> put(ValueFactory.class, new SimpleValueFactory());
> that doesn't work as the ValueFactory needs to be bound to each session instance
> in order to be able to deal with namespace mappings, paths, names etc....
> michi, just told me that in addition the ValueConverted needs some focus as well.
> and yesterday, i saw that Property#getType implementation in the jackrabbit-mikrokernel
> was not correct...
> just to mention a few issues....
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OAK-16) Proper ValueFactory implementation and
Value handling
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
angela reassigned OAK-16:
-------------------------
Assignee: angela
> Proper ValueFactory implementation and Value handling
> -----------------------------------------------------
>
> Key: OAK-16
> URL: https://issues.apache.org/jira/browse/OAK-16
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: jcr
> Reporter: angela
> Assignee: angela
>
> the GlobalContext contains the following code:
> put(ValueFactory.class, new SimpleValueFactory());
> that doesn't work as the ValueFactory needs to be bound to each session instance
> in order to be able to deal with namespace mappings, paths, names etc....
> michi, just told me that in addition the ValueConverted needs some focus as well.
> and yesterday, i saw that Property#getType implementation in the jackrabbit-mikrokernel
> was not correct...
> just to mention a few issues....
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OAK-16) Proper ValueFactory implementation and
Value handling
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
angela resolved OAK-16.
-----------------------
Resolution: Fixed
Fix Version/s: 0.3
> Proper ValueFactory implementation and Value handling
> -----------------------------------------------------
>
> Key: OAK-16
> URL: https://issues.apache.org/jira/browse/OAK-16
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: jcr
> Reporter: angela
> Assignee: angela
> Fix For: 0.3
>
>
> the GlobalContext contains the following code:
> put(ValueFactory.class, new SimpleValueFactory());
> that doesn't work as the ValueFactory needs to be bound to each session instance
> in order to be able to deal with namespace mappings, paths, names etc....
> michi, just told me that in addition the ValueConverted needs some focus as well.
> and yesterday, i saw that Property#getType implementation in the jackrabbit-mikrokernel
> was not correct...
> just to mention a few issues....
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira