[GitHub] [inlong] fuweng11 commented on a diff in pull request #7224: [INLONG-7220][Manager] Optimize OpenStreamSinkController implementation

[GitBox <gi...@apache.org>]

fuweng11 commented on code in PR #7224:
URL: https://github.com/apache/inlong/pull/7224#discussion_r1067664579


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sink/doris/DorisSinkOperator.java:
##########
@@ -81,7 +82,10 @@ public StreamSink getFromEntity(@NotNull StreamSinkEntity entity) {
         }
 
         DorisSinkDTO dto = DorisSinkDTO.getFromJson(entity.getExtParams());
-        Preconditions.checkNotEmpty(dto.getFeNodes(), "doris fe nodes is empty");
+        if (dto.getFeNodes() == null) {

Review Comment:
   Suggest to use` StringUtils.isNotBlank`.



##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sink/StreamSinkServiceImpl.java:
##########
@@ -414,37 +415,61 @@ public Boolean update(SinkRequest request, String operator) {
     @Transactional(rollbackFor = Throwable.class)
     public Boolean update(SinkRequest request, UserInfo opInfo) {
         // check request parameter
-        checkSinkRequestParams(request);
+        // checkSinkRequestParams(request);

Review Comment:
   Why not delete？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org