[jira] [Comment Edited] (REEF-439) Fix violations of HiddenField checkstyle

["Markus Weimer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/REEF-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611251#comment-14611251 ] 

Markus Weimer edited comment on REEF-439 at 7/2/15 12:45 AM:
-------------------------------------------------------------

Another style I've personally used in setters is to prefix the {{parameter}} with {{the}}. So, {{jobIdentifier}} becomes {{theJobIdentifier}}, for example.


was (Author: markus.weimer):
Another style I'ver personaly used in setters is to prefix the {{parameter}} with {{the}}. So, {{jobIdentifier}} becomes {{theJobIdentifier}}, for example.

> Fix violations of HiddenField checkstyle
> ----------------------------------------
>
>                 Key: REEF-439
>                 URL: https://issues.apache.org/jira/browse/REEF-439
>             Project: REEF
>          Issue Type: Sub-task
>          Components: All
>            Reporter: Mariia Mykhailova
>            Assignee: Mariia Mykhailova
>            Priority: Minor
>             Fix For: 0.12
>
>
> HiddenField checks that a local variable or parameter doesn't hide a class field. The way the check is configured it ignores constructor parameters. We have 200+ violations; they should be easy to fix, as the variables/parameters renamed are not externally visible.
> What is our coding style for new names of the parameters/variables? parameterName -> pParameterName?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)