You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@phoenix.apache.org by "Jeongdae Kim (JIRA)" <ji...@apache.org> on 2017/02/14 02:24:41 UTC

[jira] [Commented] (PHOENIX-3515) CsvLineParser Improvement

    [ https://issues.apache.org/jira/browse/PHOENIX-3515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864900#comment-15864900 ] 

Jeongdae Kim commented on PHOENIX-3515:
---------------------------------------

failed tests are not related to this patch. could anyone give me reviews for this patch?

> CsvLineParser Improvement
> -------------------------
>
>                 Key: PHOENIX-3515
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3515
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Jeongdae Kim
>            Assignee: Jeongdae Kim
>            Priority: Minor
>         Attachments: PHOENIX-3515.1.patch
>
>
> CsvLineParser creates a new parser(apache commons CSVParser) every single line. it seems terribly inefficient.
> I improved this issue by adding a new string reader to create a parser once and use this for all lines.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)