You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Roger Meier (Resolved) (JIRA)" <ji...@apache.org> on 2011/12/11 22:14:40 UTC

[jira] [Resolved] (THRIFT-705) Installed C++ header files depend on "config.h" which may have conflicting macros with the (autoconf based) C++ project using Thrift.

     [ https://issues.apache.org/jira/browse/THRIFT-705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roger Meier resolved THRIFT-705.
--------------------------------

    Resolution: Fixed

we use the following ifdef on every place.
{noformat}
#ifdef HAVE_CONFIG_H
#include <config.h>
#endif
{noformat}

please create a new issue if there is more... 
-roger

                
> Installed C++ header files depend on "config.h" which may have conflicting macros with the (autoconf based) C++ project using Thrift.
> -------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-705
>                 URL: https://issues.apache.org/jira/browse/THRIFT-705
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>         Environment: Any Thrift compatible C++ compiler environment.
>            Reporter: Teemu Koponen
>         Attachments: config-h-patch.diff, config_h_patch-r994950.diff
>
>
> The public, installed Thrift C++ header files depend on an autoconf generated system specific  'config.h' header file. Unfortunately, having this header file as a part of the library headers is generally troublesome.  For example, see:
> http://sources.redhat.com/autobook/autobook/autobook_96.html
> Attached is a patch that relies on an alternative, simpler approach based on AX_PREFIX_CONFIG_H, which adds a package prefix to both config.h file name and to the macros defined within:
> http://www.nongnu.org/autoconf-archive/ax_prefix_config_h.html
> The resulting thrift-config.h can be installed and included safely from C++ applications having their own config.h.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira